Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp314788rwd; Fri, 19 May 2023 21:14:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5CZmFdKo8o+OgQqaBN8piCW1WVCH5LUBSOb1Y1fNifm+bl904LQuT+8QxqaGLQkU9ZJNk1 X-Received: by 2002:a17:902:f54d:b0:1a6:45e5:a26a with SMTP id h13-20020a170902f54d00b001a645e5a26amr5964354plf.27.1684556048005; Fri, 19 May 2023 21:14:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684556047; cv=none; d=google.com; s=arc-20160816; b=rj1IQDPZCjTlG9TEkHWWdQ0/IxIdbLSCQ/y3Ph+AlWo/d2HNswZftEl+lRePpUBJ9U 3GkjUQRjzXCG/nNLJlyU4Zyxyfy5Hvbse5tbMX45JzbycZMBt8kGT9q/zf+nBN5eIkaM RyTUbc7nImJ91F4ZWcPa677gm/wkmS6mq9BbBCE7fdZBjaluiNmEFG2oJGB5yZgQl7gI OCN/8FQ7f2ZYnHrw3gZESZMlTfRNmEwOWdwsMv9W8eHSw7hMh4WqbbzM0wNByJGB1saP gElOUisDMdunDylshIRKDhv44rxrVEpl9T764Rpb/CgY2tdHCcfkwYkQmtJ2zTpSEhFk D2OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=CmsksxXD+n4C0QHv7Zr+S4D+BO8Q1gfodWsSUUJZRcs=; b=LxukCdjfBANm34ceiMWFAri18mYBtujbY93ogD4K2PSfX1hJeOaNotg97ApOkmxdRD m1oJUfi6usWUIzm5iKaDZgUjKrCMSVH8EVSHc43OwNxX6hrn9TG1LOTLW4uKGXg5DHMe S7Sto+lzuiLqd0i3YARkDFn1fKYMbqR/jI2aCiatLuqGxYZibyIbS+OfRB0rNQnQfxzd tIeaxZy+8pFVp7ZLaUUPS5ks5tcCqoqioUCuAKHwyPJvWvca55Y3ETvX/GrhW45Z9f8V SvE4J0EYrpYN5VKDs4vKrqAVJGUG8G5N2vn998EjNLiJeRIomnaxh/6U8PmCHBjNRuv5 uhQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=wYBYJCsc; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h5-20020a17090a130500b002536b553afdsi2818401pja.98.2023.05.19.21.13.55; Fri, 19 May 2023 21:14:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=wYBYJCsc; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229503AbjETEMe (ORCPT + 99 others); Sat, 20 May 2023 00:12:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjETEMd (ORCPT ); Sat, 20 May 2023 00:12:33 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C9D8137; Fri, 19 May 2023 21:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CmsksxXD+n4C0QHv7Zr+S4D+BO8Q1gfodWsSUUJZRcs=; b=wYBYJCsc9X5cOzCe7Siycq+sm4 JN0IA6hxZMgTuCVKWEpoKYrifkBMr0lWDMJSliRS83pvDqAMRzSEcIoE30caFN3f0l0Wnhj6TXJR4 hiyhP8Q94fnYNIzKFJ0ohLNCPB78puv9ksyLcaKPTITe+x+BewZc+oc2uDW0phzAEJ68Aj8FgdbJc HR1Y0l3w8gjGXTTg8lmV/SJ0NzR3kMvVYQo7UDE/zUSwRbMduraWcnVaKN8Tg5eCSXYEy2Zqz1xRW ubQnDeOPaapafV9c1oAHb8WqsUFEC+DnlcaPgNTtPiRbXnjFUAXxqJGQmxc71ODO1WV+qC49LD9w1 zSA8V69Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q0Dx7-000dWG-23; Sat, 20 May 2023 04:12:21 +0000 Date: Fri, 19 May 2023 21:12:21 -0700 From: Christoph Hellwig To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Theodore Ts'o , Andreas Dilger , linux-ext4@vger.kernel.org Subject: Re: [PATCH v21 18/30] ext4: Provide a splice-read stub Message-ID: References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-19-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-19-dhowells@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, May 20, 2023 at 01:00:37AM +0100, David Howells wrote: > Provide a splice_read stub for Ext4. This does the inode shutdown check > before proceeding. Splicing from DAX files and O_DIRECT fds is handled by > the caller. Not sure I'd call this a stub, but then again I'm not a native speaker. The patch itself looks good: Reviewed-by: Christoph Hellwig