Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp565820rwd; Sat, 20 May 2023 02:48:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4L2bLOWvZaG3e7EiYJMyvdbinY5NqniQlYOhMrf+IU20uKGp6RU5MT9bTHgiHQ3g8Bhvk+ X-Received: by 2002:a05:6a00:1707:b0:649:93a7:571b with SMTP id h7-20020a056a00170700b0064993a7571bmr7877290pfc.13.1684576099149; Sat, 20 May 2023 02:48:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684576099; cv=none; d=google.com; s=arc-20160816; b=LgQmCqkxyaUbpz74uA8VfF2hvCrPE7wHR55Jhg30XQaawh9PN0jrnJfo+l7uqIhcvB EdOCipAUo73R1BxuYqwrHCU6GhOPmWEA0yyX7fdrLUwuowgkNyXpN9b4M0F50wzwbFAB gZmHntzZBbImai+3Nm9jn0IOO9mo5UFp8D8WDE/FZI5MAp0wA1tC726LFMyM8Lr9S8yS 0Ht43cKGTAdJ8a06YEvOvP/lcIQtKlujCSAtoGwFBVcYJMswUVgrX3pxRusk6G4Rl7/h pAhkKAV7aB5vemuRNQESDikTM2cWx2Go8ZAHUWGZ1CGNMqk0S8xX6ieX5rpZvEfHT3F3 8dVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3KnyM9AOumUnXi/cdaRPygqsQinbgxlV9Rd39FAtx8I=; b=tc0gF7hzdH8Km9/2K17qRaXkdMmrLM/g5Q6er4UjDgEMGJQlOAB7TG2sAFAWoJlwYk QzZNiNY0YarmTqEv382TXbXeAXJ/JhfZv5RZGSJhFBT7gqYG9OGPxZVXyqmQ3HpG54rr Ynl1tzcLX3uvF6z2Qw2Rf8nSipElL4TgYs6w+lc6GeFi5TGrgHT+AFK/tUgs7r9dw4sn J9LCoKuAhCE2zGU/sB1aY13uoGQBVgdkNkVFWNJyDSf0+Q9vATnnxaU8iS1Wvplty+8Q uJs93OVVoDkU4HcPwe7b3/kagDzAJmrbmIg9XlEwYZCSgIPOtH9AK1lBm11d+UCAhMuV G6Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RCKu+qWL; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h189-20020a6253c6000000b00640f213b6fesi1266667pfb.240.2023.05.20.02.48.02; Sat, 20 May 2023 02:48:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RCKu+qWL; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbjETJli (ORCPT + 99 others); Sat, 20 May 2023 05:41:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjETJlg (ORCPT ); Sat, 20 May 2023 05:41:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F000D1BD; Sat, 20 May 2023 02:41:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8802960B6B; Sat, 20 May 2023 09:41:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90607C433EF; Sat, 20 May 2023 09:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684575694; bh=Qi34Xt1y6x93U61QykhNqil2JS5d/WED6AUV/H0U3cU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RCKu+qWLljLQMkOKKE7+IBqPv71gQvySDl07esuV8mxzFnjBimDFbJ+MeTXiImdwi LAo1oAYsycIi6Ngjivs8aWf09Cb9lAvSPT8V2b4vnr52AhA3wOa/eQDFYZZeo1f4LA 1dZwCOGQ7U8tRHWFm0WzUOBEiB2QJO1tfY0b2INLx6s4X3yorcUT+1egxyQYM79jmL VEwcuw7Dj4wzdbpCiR3/dZ5jcuQr/CBLIo4+1Q6Z325lA4XAokTZBbKp7ZzDfVTlP3 rPhjhxF3vQ/ENd4VZF5WlXEzG14C074CDwifY9/pZY9VpqGP7shdUgTnByBELcVTt2 V26DafIYZg3Tg== Date: Sat, 20 May 2023 11:41:27 +0200 From: Christian Brauner To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v21 08/30] splice: Make splice from a DAX file use copy_splice_read() Message-ID: <20230520-gepocht-akzeptabel-b117346c55b6@brauner> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-9-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230520000049.2226926-9-dhowells@redhat.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, May 20, 2023 at 01:00:27AM +0100, David Howells wrote: > Make a read splice from a DAX file go directly to copy_splice_read() to do > the reading as filemap_splice_read() is unlikely to find any pagecache to > splice. > > I think this affects only erofs, Ext2, Ext4, fuse and XFS. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: linux-erofs@lists.ozlabs.org > cc: linux-ext4@vger.kernel.org > cc: linux-xfs@vger.kernel.org > cc: linux-fsdevel@vger.kernel.org > cc: linux-block@vger.kernel.org > cc: linux-mm@kvack.org > --- Fwiw, O_DIRECT and DAX could've just been folded into one patch imho. Reviewed-by: Christian Brauner