Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1289826rwd; Sat, 20 May 2023 17:29:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7pDmfU9tsvA6YcBTPkootO5Sh38M8ZMzeN8Aiud4i7N93iFuWhSsje3bfTAizVuf5AhI9+ X-Received: by 2002:a05:6a20:3d95:b0:106:11fa:192c with SMTP id s21-20020a056a203d9500b0010611fa192cmr6368261pzi.61.1684628973783; Sat, 20 May 2023 17:29:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684628973; cv=none; d=google.com; s=arc-20160816; b=rE8e0iV0Tkw2sRHn0pUHuzh64p9fAm1NTkr1fftBQ31ER+nMlebe7usAOzzl6CWX+b CE4TAoqgvnBfUt6fxOvcEASUawoOu+N+7SszePib1CgBKXetzhyZtdNP7d7oBuyHDQbm feHUIiL2FWW19EykLpjed00fw14lYXmXJhOa3MAxsRQ+ALw/ZsRF3TXibbcrZBqInhti BVNBCu/2gH6zm7II5ZjTjYtcgMYwS87i/hGGqRS6aHa0HQuplyIIhF8jj/8tSzMVyeMO LmvGvwJkDgr26qHvAmz2V5w+1+oNSqwW4PFPfYJZGMKPhGxl3MgQvwAFw6SmYnQJo/GT h4kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3U2jQyV+om6cEvowDzLHU8bBjtTNByfdH+e84cJttjQ=; b=K9VKRDedyu+/ztvBnIWXbGS2Nh8wJyIxZO9OkkAHm/yC+t2UIRgzuCHx0gGKF37NVi +9Zg1mJbY5pzZShiicUMoQnnzQqr9F7mqxQBvuVO/FxoqeFlFKWAXmraPTYiV3gYqI6/ lc4zpRsWFWnKhOCwosRUUc+YcKz8M4KFJ+LnY6O/kBRarGpYbcfRESfJyyxQASOnUJkt sZtbOkYMTJQIAi6YyQHA50DOjaK6RIaB614GTq3qZqDsWpox0WkC/W9rJnjPYR9Za3GB GkY1hGGy76Ufqy13FAfmgHQB1+wT2IZ8+p4eYhYIpk46j+8tOII7/775oHnBtFxYTCf6 jNaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="oMMqD/ZU"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s69-20020a632c48000000b0053894c1bf06si1622321pgs.643.2023.05.20.17.29.20; Sat, 20 May 2023 17:29:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="oMMqD/ZU"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229570AbjEUA3K (ORCPT + 99 others); Sat, 20 May 2023 20:29:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229561AbjEUA3J (ORCPT ); Sat, 20 May 2023 20:29:09 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B7D4121 for ; Sat, 20 May 2023 17:29:08 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 34L0SRVZ026415 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 20 May 2023 20:28:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1684628911; bh=3U2jQyV+om6cEvowDzLHU8bBjtTNByfdH+e84cJttjQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oMMqD/ZUppgCgzKDvbbwVAi5CEoovEfF1QtZ0mMBKR4RhXidI3B7fc+NW3u/9nKyc LsQi19iJKHdVv0GmPowknFWlPn3BB27TwXP13cbb8op9sxdbezrXTtDoP0ZdAbz0BE ZvyOAOVBRXH4mAhrpeCpv7rLzbYliRhgbSAItfajtlSjs4Nq9Dj9fES2JT7BSn8LM+ irK4TekIClw7dLE/9zsnl+F7IjdK6A/BnHZgbgWHlOTPbYuLEtl5RRB/esBBW9F82E 5k16hXvFnB1AWJrjYnz2FM/QeLmDTL4agwbJWTjVLQR3bEQyJRAn00rb7NHMMsZP+w O9VIZ6uLT9EQg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id C696C15C02EE; Sat, 20 May 2023 20:28:27 -0400 (EDT) Date: Sat, 20 May 2023 20:28:27 -0400 From: "Theodore Ts'o" To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v21 08/30] splice: Make splice from a DAX file use copy_splice_read() Message-ID: <20230521002827.GB207046@mit.edu> References: <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-9-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230520000049.2226926-9-dhowells@redhat.com> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, May 20, 2023 at 01:00:27AM +0100, David Howells wrote: > Make a read splice from a DAX file go directly to copy_splice_read() to do > the reading as filemap_splice_read() is unlikely to find any pagecache to > splice. > > I think this affects only erofs, Ext2, Ext4, fuse and XFS. > > Signed-off-by: David Howells > cc: Christoph Hellwig > cc: Al Viro > cc: Jens Axboe > cc: linux-erofs@lists.ozlabs.org > cc: linux-ext4@vger.kernel.org Reviewed-by: Theodore Ts'o