Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp2250586rwd; Sun, 21 May 2023 16:57:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4NRk4oDzM9CP225LI25UnuletoW56BfcO6yIEvIPsMwcAsipdDmWPmid5V+Po0TGwTqVoV X-Received: by 2002:a05:6a00:23c7:b0:63d:2f13:200 with SMTP id g7-20020a056a0023c700b0063d2f130200mr12399732pfc.16.1684713458368; Sun, 21 May 2023 16:57:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684713458; cv=none; d=google.com; s=arc-20160816; b=X/aWCPjIPZT3cntIDw0IcxVOyOW3RDlFyBm1B5Xfl8frbko6GI3Q05xX1c73L/bgi0 pP0rftvkC0hmZm8+MCStV7GIWfCExSYhqRJPCKu4mxIdQsGLLyup7mLmEgDrI4Q9gR8H QYnECEEJ2JjnXxU4AMDPpq2DbhyoL4weRKunXfxSOX3KwEdSwbRExO7LW2mSwamMDmYL jsCtSNjOpsgunGgMjvMYeQMUgyIYuMdxey22tk6YXmw6BGW8a60xNq0rXJDeNUsPtNz0 5qpG/PnMnXZoLvhsmxL5pVMpnFTHEgCWuoAcJyandxQWTg2+u15KEaZiiskkYTfSqd1h 6u4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=hKSB8EoIIZdNDO3pwDZPENWgOr8qAdmee/t6mnJ6cuE=; b=WRmhBthZFH7X/MfiJrMR0xmfSsWVMlR9UENQh1N18YRaCY5IkL8waGFgvZtGQ6+fLJ CumzJZ4UoLH8xHgGCKkbIe4plRqW85BaRYfTytbrSJwwN80Fg9G5UgN/73OO7fZbhcOQ ljGkMYFcSDrCov5gUC16b8e07O5rAqNt3sMEiGY5976dyNOthp/cDC/sntf3+oKYJJTW rKl9lMyHLtQGQeLjXo5q2ceyicElShgEperwbzlsvM5fX4bdQWw+OpvG7MC+VruPJBUg 9Q5jegzFdDULyDPlA4uwLaV2nxI3CWHSAgQkHPxi3havM1OSXUTbhfFLgZvcBcxoHPm1 JWOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z0UIsZmH; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b6-20020aa79506000000b006430bec8238si3701561pfp.328.2023.05.21.16.57.26; Sun, 21 May 2023 16:57:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z0UIsZmH; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231149AbjEUX4k (ORCPT + 99 others); Sun, 21 May 2023 19:56:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjEUX4j (ORCPT ); Sun, 21 May 2023 19:56:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E8B9BB; Sun, 21 May 2023 16:56:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9791B61846; Sun, 21 May 2023 23:56:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 611D9C433D2; Sun, 21 May 2023 23:56:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684713398; bh=WK+H08Abjgxys0xDqd/U8tYXnOZJ3X8F5W55cIj1HCw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z0UIsZmHFp90UQn/0ZDZSobLdQtjW4rPu1tqdDMNYQsGw8zH8/kGrQZAEyUH335qN jx+PcuHH194DZCYw13SBnxFHv8qR/dJGf6af0XZolQ4pY4NwGz561+BSCiSdq+NMfp pP9GaP2rqUcoup1eDTQaC0u9ku+LtvdS5oXq+YIcnSZNrqaJQPgnGcdSglE7zJQQJ1 mDglCPYJILcH8STc9acJkDdPcqcszqdqt1XtSzFpR3uZ4Vt/dLyxoG0U8QpJUgK6tJ zPiZ0smPzXHGDHdVfPjHk4iQopmGL94L8nywJnqwdSEEkEN2OyqqJI94LwhMmFDAGq dnU/Dyd7Whn7A== Message-ID: <5703f49d-177a-a810-6f1c-b32aa1abcde7@kernel.org> Date: Mon, 22 May 2023 08:56:34 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 06/13] filemap: add a kiocb_invalidate_post_write helper Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, "open list:F2FS FILE SYSTEM" , cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230519093521.133226-1-hch@lst.de> <20230519093521.133226-7-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230519093521.133226-7-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 5/19/23 18:35, Christoph Hellwig wrote: > Add a helper to invalidate page cache after a dio write. > > Signed-off-by: Christoph Hellwig Nit: kiocb_invalidate_post_dio_write() may be a better name to be explicit about the fact that this is for DIOs only ? Otherwise looks ok to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research