Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp736033rwd; Thu, 25 May 2023 03:14:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ66+ve13wT1YvojzdZ3ca/umYij2Z+1eMCHTvmBfLLVHzw1R+IHck+EeqYsJjn1vWamsN4B X-Received: by 2002:a05:6a00:248f:b0:63d:5de3:b3f2 with SMTP id c15-20020a056a00248f00b0063d5de3b3f2mr7653329pfv.18.1685009664172; Thu, 25 May 2023 03:14:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685009664; cv=none; d=google.com; s=arc-20160816; b=vR8zsH6CsFj0OEtsrQ6LC4RWqtnY6ill4pP7Mkvj+0+bD0XUGuFVEgxjkpQwNsjyMa rBkPnYQ9TrR/nN/Wmr35wF70AqVDjr2ncU/YH0dp5mrCkGVFe3n6b/bV8Yi4zRsoWss5 cpIxgcM8r7GbzbIGb5g0M7Zb3rHU5pMDIqc6zPQXvj0RhvSVjwv4alJYjxNe+9+ZCekE C21sBiO+jC7ObeZ5tHgnJo5QxjRExt+tOJ3MP0nBg4K7wZ3HIrONXEFVAgoKPamSknAj xssmrbqTBDVF3xB7eD0aqV5FeRCaOZ4UGwXNAppTIyIniF7sQg9RtiILX/HgwUQIMTNP LDrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=IUR/eF3fmCh6yLsrTi60POyjHyPORNO396GBCktNTE8=; b=gzgnVgezCdM6WncW0UUqr5/9DtJq+IPwBaSivgdLisFPDSVxJpjdS2zpMWWvgzIxpS Xa2Hi+9wBZBLA+Z9ro7OhXqMnoJ0GWizeipXTak2zzHZH96t2PcmNSCGz1a2f14J4CK8 0S4eQnt4oAfGPksv4eOklrJk+GQSXTIYPUxK6RjMkp1hv6Rwdix0Urn1DdPvrRBUG354 89LEmiVN/3IlhepUna7GZf6RcBmrqUEm0SE/6r+2+8pWTdcn54RNLuy+waxy6qsy9LQe OKiqMqHOxcgVZgbrf5v3dRJitm8uWtt4p9bkd+orzKuGuWCrPHvCga+WyD5QbfCx1OHC GRTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k123-20020a628481000000b0064d675fc97csi1177391pfd.27.2023.05.25.03.14.11; Thu, 25 May 2023 03:14:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240775AbjEYKJy (ORCPT + 99 others); Thu, 25 May 2023 06:09:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235690AbjEYKJx (ORCPT ); Thu, 25 May 2023 06:09:53 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD09B12E; Thu, 25 May 2023 03:09:52 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 3423B68AFE; Thu, 25 May 2023 12:09:48 +0200 (CEST) Date: Thu, 25 May 2023 12:09:47 +0200 From: Christoph Hellwig To: Miklos Szeredi Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 10/11] fuse: update ki_pos in fuse_perform_write Message-ID: <20230525100947.GB30242@lst.de> References: <20230524063810.1595778-1-hch@lst.de> <20230524063810.1595778-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, May 24, 2023 at 09:07:22AM +0200, Miklos Szeredi wrote: > > - endbyte = pos + written_buffered - 1; > > + endbyte = iocb->ki_pos + written_buffered - 1; > > Wrong endpos. > > > > > - err = filemap_write_and_wait_range(file->f_mapping, pos, > > + err = filemap_write_and_wait_range(file->f_mapping, > > + iocb->ki_pos, > > Wrong startpos. Yeah, fixed for the next version.