Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Jan Kara <jack@suse.cz>
Cc:     "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org,
        Eric Whitney <enwlinux@gmail.com>,
        Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [PATCH] ext4: Fix fsync for non-directories
Date:   Tue, 30 May 2023 15:26:34 -0400
Message-Id: <168547476046.200310.8139638693593712041.b4-ty@mit.edu>
In-Reply-To: <20230524104453.8734-1-jack@suse.cz>
References: <20230524104453.8734-1-jack@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On Wed, 24 May 2023 12:44:53 +0200, Jan Kara wrote:
> Commit e360c6ed7274 ("ext4: Drop special handling of journalled data
> from ext4_sync_file()") simplified ext4_sync_file() by dropping special
> handling of journalled data mode as it was not needed anymore. However
> that branch was also used for directories and symlinks and since the
> fastcommit code does not track metadata changes to non-regular files, the
> change has caused e.g. fsync(2) on directories to not commit transaction
> as it should. Fix the problem by adding handling for non-regular files.
> 
> [...]

Applied, thanks!

[1/1] ext4: Fix fsync for non-directories
      commit: 47a71ba09a8473c81cb87ed11421ed2896f352d2

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>