Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp573494rwd; Wed, 31 May 2023 02:20:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Lyzh3mIY19bvrzMYF15Pn0jOxYFexP5qdCNKW8lzNQG6DkYkR5C0VkiwugWGnt8tsLwP3 X-Received: by 2002:a05:6a00:2e1a:b0:64a:9090:5147 with SMTP id fc26-20020a056a002e1a00b0064a90905147mr6308427pfb.10.1685524836307; Wed, 31 May 2023 02:20:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685524836; cv=none; d=google.com; s=arc-20160816; b=UoeI7+c1wjVDhlJZK6sMwPnzFB/AFBYf3njVT24c4GCG7y7yoRCa4WiUmjb7FEjj4X pmGWRelZzEFm0ZV7aSqcbxxRzHDf943vojcX5t+akYFaUrgy8GB+Dl6KFKMRjkwziN85 wHiFeXoz1Rzn6RBEJlrkHcopADKyDbvau1pofBqJWDKOfRyj4DG8A05H0ifjC6MtsR7t 9HwgemgdaMEOxBn9chatJP1rsHEMMwAmHWbGuBJDfQJKsHFzeKih1CzUirMvazT+qX5l suO0qiuGf1rkwFfsUAFcVpSm+SHEs2A38sGc1Vt9LMpyUUCw3HERTRw4hjv2QZyi3H0J znVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=JubkPk4gPDeN9b7yimB7oHd7wZ3DFjoxys5W0ASlmQk=; b=mz8UBus4KqpKrIPRklFCquXSv743zWypK2HRSOBEj8iXpRyovqXaFFNWmDG6tn57zy mcL89doC7G3E6/Fp1PpABHXWaZpN1+fHD7dAvRtqD7EObdVBKKE6abRd/TQcThq1NhkG 3JFukuSU+3Jsa4z4Fw+RTzGDg4geCgJDFPV3GgeCGND3VNIe75SOf1w20ZdF47/qcDoh Mq7ettgYfULWujX4pdvXkxplMIkURYv0QmKHYSRfBerZ99EMzuXTPXsGFuKKQmQA82+p 3IE7fIp6w9G6i1e/bMT0iAXxWaep0okdwM9OFDmBprjWpyJBfCUioprZVRtMtLmtUYLe J1qA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E4gFHy8T; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r1-20020aa79621000000b0063d33fc3e08si3309488pfg.79.2023.05.31.02.20.19; Wed, 31 May 2023 02:20:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E4gFHy8T; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235017AbjEaJKD (ORCPT + 99 others); Wed, 31 May 2023 05:10:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235336AbjEaJJp (ORCPT ); Wed, 31 May 2023 05:09:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3480AE54; Wed, 31 May 2023 02:09:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5389F638A1; Wed, 31 May 2023 09:08:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 414AEC433EF; Wed, 31 May 2023 09:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685524133; bh=axEkNRQxOw2SsrEsKVeeUf3LFs4+Ez60j1wdXzIL3N8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=E4gFHy8TJgSROxww8OVcO6e3p3dd7vo4i5KSweH0NOnDdcWZRx6VhzGl/tF5voshC UdmJJJ49kI5kmDv8uxIQcXuTasv67aBuZrAX/nFEXNjew8xfFV3/Tv9o4t/50sX560 4osRYtHft7VGmBwOugY2d3gckgf798HrCVdO8An/XzC3FA/TtXWsZVzkSXWlRu/3m1 UcmBmqSm6PgzPnQ6YZuJR6SC10cam6xiaiwNt5PMth2Lvq3oHSe/HVHMr8zaZl9OXp N3UA7Kz7at7Iul2UL15fIZVbY2+75CmNbSF/oiTJWoy68QDXpRnZJj8Do8LRZ7JegV xaP9uJgHiusmg== Message-ID: <54b4a89c-4023-526e-62e3-8f7fadc2861d@kernel.org> Date: Wed, 31 May 2023 18:08:50 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 09/12] fs: factor out a direct_write_fallback helper Content-Language: en-US To: Christoph Hellwig , Matthew Wilcox Cc: Jens Axboe , Xiubo Li , Ilya Dryomov , Alexander Viro , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org References: <20230531075026.480237-1-hch@lst.de> <20230531075026.480237-10-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230531075026.480237-10-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 5/31/23 16:50, Christoph Hellwig wrote: > Add a helper dealing with handling the syncing of a buffered write fallback > for direct I/O. > > Signed-off-by: Christoph Hellwig Looks OK to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research