Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1426971rwd; Wed, 31 May 2023 13:54:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4s5+j9rVM+Pxz1bprDt8b5BEauxtdVoEy4G88UzQPui9R3lFOHID5loJO+1f2GBtXGY+iE X-Received: by 2002:a17:90a:5a49:b0:255:67e3:98a with SMTP id m9-20020a17090a5a4900b0025567e3098amr6685896pji.11.1685566489899; Wed, 31 May 2023 13:54:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685566489; cv=none; d=google.com; s=arc-20160816; b=dueSALjFsZLiQ35rIXtT8DGKP6JA2qa45nkrQRJCPXZMLC3944vZVYxJH+ZEU4S3WG 9qMoPy9VmRwfNP/lQqxTKf4jy2iloMkJppnfO43sT+g7e5OH79BfRKJMpKxQfo4UlI08 qVkru0Or9LR9v2kNtbgHs9/imqkk1rwpvfOOpaigRXiidp52Spiea8wvYd/zdBk1gHIq vbifc6hhbL91g8wrPl3hM/iSN1qao6BneMyW5I0TLQd1SK4Cxvk/KaedqD6+UCdXv7zg TVSJoWCmgy8nC6ziri4c92sJ+3Pz0fd7XlAwgf8dnLlfNU31g6yvRTxYPcl2iQ3pLJWm no5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=H2MHMFRCtTpRq4HekvDMncZqof6fHitP/tkQ4Bwp4iw=; b=XLxnXTGkxHyyUZVHd943bsJJck6Nm6aze+TMm7TrIIphVvyQo7552UvQzX6QR6DcF/ BznC3G29rC7jAdYa13LY2o8J3jFI7lNst11OSv+5xPh3aDxaJonUQxrL2iiMqIqgI105 75xFy3a1dWeq1xf2Fkf/IBC+dw8QRqwxkMntrqtC0loTwUSp/4maEiQ1IpOKN7udhCk4 Tw83Sujbih++uW/CNLHw25zBf0wVOvjocoGgVLBd/YlteGUAxF/aGjPKYh3LT58qfVtH n1mKMmbAtYIe9PK4jUYoW0/M68my2D630tpy2qMXf7ZXmuMA2eyNDExHeIjsHKtZLkYn Hi9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qe10-20020a17090b4f8a00b0023d22d0f0fdsi1766413pjb.19.2023.05.31.13.54.04; Wed, 31 May 2023 13:54:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229934AbjEaUle (ORCPT + 99 others); Wed, 31 May 2023 16:41:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbjEaUlc (ORCPT ); Wed, 31 May 2023 16:41:32 -0400 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFB6D12C for ; Wed, 31 May 2023 13:40:46 -0700 (PDT) Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6261890b4d7so1658006d6.1 for ; Wed, 31 May 2023 13:40:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685565646; x=1688157646; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H2MHMFRCtTpRq4HekvDMncZqof6fHitP/tkQ4Bwp4iw=; b=fKD5ZVY7i6a0iCmyQh1lC0zIsIKDfx+5a9diwxps3pvkpUo7nfUWaloWYv9Eoz+v8S ObaG6t+vMJ7vNICjfMZBENZr+YQYH7S1H5naGGhLSlEvaex8WgBY7sQAW7t7uGX3Z3Gq PEV/02BKP/gVeIxxNnH0+FV4/p86V8USfvNH7kU31st5lqHTmDMsy8hbGgecpSsJ0s5F EbhXJe+keusaF24fAdn+FPK5+tohbzlp1qH5ztvdyHavIdqJf3dyao6dp5qhqPn2Eati AAS9bleRLmq7/UPgksQzgEN3ZYcxOgo9Y2HhEdOM92/ai7MY8TrVoh9ASqQMpGFKTK74 R4Mw== X-Gm-Message-State: AC+VfDxJtQMsUxfBI9VFDwAeCfue5AwHdYm/WOCnbmkAlCkVqf4ByWbO FfcIOXT1mQuU9APZYkdwQ5iO X-Received: by 2002:a05:6214:d85:b0:616:5f27:b96a with SMTP id e5-20020a0562140d8500b006165f27b96amr7207768qve.27.1685565645712; Wed, 31 May 2023 13:40:45 -0700 (PDT) Received: from localhost (pool-68-160-166-30.bstnma.fios.verizon.net. [68.160.166.30]) by smtp.gmail.com with ESMTPSA id s12-20020a05621412cc00b005fe4a301350sm6354991qvv.48.2023.05.31.13.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 13:40:45 -0700 (PDT) Date: Wed, 31 May 2023 16:40:44 -0400 From: Mike Snitzer To: Sarthak Kukreti , Jens Axboe Cc: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Theodore Ts'o , "Michael S. Tsirkin" , "Darrick J. Wong" , Jason Wang , Bart Van Assche , stable@vger.kernel.org, Christoph Hellwig , Andreas Dilger , Stefan Hajnoczi , Brian Foster , Alasdair Kergon Subject: Re: [PATCH v7 1/5] block: Don't invalidate pagecache for invalid falloc modes Message-ID: References: <20230518223326.18744-1-sarthakkukreti@chromium.org> <20230518223326.18744-2-sarthakkukreti@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230518223326.18744-2-sarthakkukreti@chromium.org> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, May 18 2023 at 6:33P -0400, Sarthak Kukreti wrote: > Only call truncate_bdev_range() if the fallocate mode is > supported. This fixes a bug where data in the pagecache > could be invalidated if the fallocate() was called on the > block device with an invalid mode. > > Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") > Cc: stable@vger.kernel.org > Reported-by: Darrick J. Wong > Signed-off-by: Sarthak Kukreti Reviewed-by: Mike Snitzer Jens, this one is independent of the rest of the patchset and should be ready to go upstream whenever you are able. Thanks, Mike