Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp898593rwd; Thu, 1 Jun 2023 07:59:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ60GOEuaWizSiiV9C80T1QlnPgaryd3QWJM2K3c/UmXyF2jHO5BLPXnJMDz8xPaTc5zeO06 X-Received: by 2002:a05:6a00:3923:b0:64d:42f6:4c7b with SMTP id fh35-20020a056a00392300b0064d42f64c7bmr10532703pfb.27.1685631581381; Thu, 01 Jun 2023 07:59:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685631581; cv=none; d=google.com; s=arc-20160816; b=s71bMvbD95xj0iiCm+uvO7mx53iCrbYHEZGLT1lyZslmmbIRFroJokPcpFio0mwRqZ /bsSgHcX9Mvhfjj+iwEYF7PVvxlU2GjEz/7zaKDYRUWY5tlju7o/JM0AzsIEVjIoupLp f6CYN5C/GzUZJxvrHQVpEBfd+sULGcJqdN9wmI1jIEYGr8dAxIxtE8SAHv0Ed1/SYf9u t3A8uUMTMrGogVfvUSBbz03+rbE4pNR32MMIcbUFNbAMrVXdXH12qPJNrc3b+imbEug8 C6YE6TBO3Lr08PMevsW+SoT+fIKiylaHyrtYMdkglWgatjgPnLkfjRA15pmk/xUZi1gL Hreg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ocmgG3AwXqD+xUhaoXDH/qEJqT72EouO1rvjHBr6Htk=; b=cuWOqObB/YZVu4DJG24TiszdpP8mrLfCyy8p64p+imfoV2CUYVrCHsNJcQCOkZ6IvO 5nuswrAlxcNBlgWAnGOguMRjM4rgjUjbxk81vVCJ6jPIlOited7TRSfTppxpQRDmt4fq B+7TbtTASJkt+yJGpyY+OJN24dmZv917cByFVCSVqF8ICIGWFdvzjV/6yXtPqX7ZmSfy sWiZzQbaXl3nsOG9lgsuP1mStqTqwcgAHnHPWYgatNSu6i2ImQ3AHD2QD+q/sbI+gYeF DW6MW0toEZ6c9LxGB2tPWnLaceK6/96mwmWYCW1HYUk0VWGXJ4rKj4I/rLOcJieR1+0C R0AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="VM8/Uu97"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l2-20020a622502000000b006466813eba9si5602347pfl.47.2023.06.01.07.59.25; Thu, 01 Jun 2023 07:59:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="VM8/Uu97"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232667AbjFAOwx (ORCPT + 99 others); Thu, 1 Jun 2023 10:52:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233632AbjFAOww (ORCPT ); Thu, 1 Jun 2023 10:52:52 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D6B8E2 for ; Thu, 1 Jun 2023 07:52:50 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-119-27.bstnma.fios.verizon.net [173.48.119.27]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 351EqMka013065 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 1 Jun 2023 10:52:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1685631145; bh=ocmgG3AwXqD+xUhaoXDH/qEJqT72EouO1rvjHBr6Htk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=VM8/Uu97seftS0qeq+6Ysp9BXkNhjUcaVl9U89FzKjVHN95D2/9uD9/Z0stw6GayT TLelYRPi4d2jWT53MdX2oZUfk1PoQcJx+Iz594HiUAahSJ9pKzl9apyvKB/+MjiztU bM2Ot+kBWhdNFklD0RSdcbI299bbFE+U8JB76uo6iEoCt4Ql/BS6rmFognIzCNnLq+ qexrwfUTKnCX32iQ9Da7QywUgvoU0558ckrfhgFf92/Sv7BzpVcMYqbv+yOze6k/Fl 6vE0tJLu/1VlEkWol5ckl73dRDgvmHCHXBgfYZlYhDQP/K7RMQlgIh7fIpwMQeSXj8 Is7CFhO77tRDA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 4753A15C02EE; Thu, 1 Jun 2023 10:52:22 -0400 (EDT) Date: Thu, 1 Jun 2023 10:52:22 -0400 From: "Theodore Ts'o" To: Jan Kara Cc: Al Viro , linux-fsdevel@vger.kernel.org, Christian Brauner , Miklos Szeredi , "Darrick J. Wong" , Jaegeuk Kim , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, stable@vger.kernel.org Subject: Re: [PATCH v2 1/6] ext4: Remove ext4 locking of moved directory Message-ID: <20230601145222.GB1069561@mit.edu> References: <20230601104525.27897-1-jack@suse.cz> <20230601105830.13168-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601105830.13168-1-jack@suse.cz> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jun 01, 2023 at 12:58:21PM +0200, Jan Kara wrote: > Remove locking of moved directory in ext4_rename2(). We will take care > of it in VFS instead. This effectively reverts commit 0813299c586b > ("ext4: Fix possible corruption when moving a directory") and followup > fixes. Remind me --- commit 0813299c586b is not actually causing any problems; it's just not fully effective at solving the problem. Is that correct? In other words, is there a rush in trying to get this revert to Linus during this cycle as a regression fix? I think the answer is no, and we can just let this full patch series go in via the vfs branch during the next merge window, but I just wanted to make sure. Thanks! - Ted