Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1504990rwd; Thu, 8 Jun 2023 20:17:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6hDzQ4EenWAlVYidtKmLIpThq4CBzrJNmV/YdJSzSbUgHi9A4pfyqvKlQ6W+urhQ/Mh3p3 X-Received: by 2002:a05:6a20:8626:b0:100:15c4:23af with SMTP id l38-20020a056a20862600b0010015c423afmr16975pze.60.1686280653115; Thu, 08 Jun 2023 20:17:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686280653; cv=none; d=google.com; s=arc-20160816; b=FQwQBqCBluVfNxWochHYmlO7Cu9oydKY9/pXAtnPpDkhX1K65ZDLS7Ah5TnKfbluCF E22+bmwzzS8PSViWbLBhpoiJDZ9J11W9oq405OgmJew9y+rDYepbsS9c9M3IKAvXqt1B JjdaY6V9gQBFBILjUJBx15g234Z2Tz1bvxkFi/nRHPAOkf8wqNKO5x34HDY+U+OoNC59 MsxLKHnLHg113xzRCIC08t4xEtxGNtXwT+kpxJLKXQdb78It/cAEt5OIc3wpBWwWmi0k T/WGAHyuh5EgCkC4V3/lha2g2OEiGjSmQb8yTTnSeEaIMYd+uZvzDiv0nZ3WGeQAXnN9 q8Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eo2h/+7FrLj+iah4+fevq6IpoeMhN5aGJnWzkhXmtp0=; b=ZlEt4LmJLUH2Y539Gk7WPPGXu+hEwhk65bj0CAYxwdX708VDGmWk1oU8+WesCjdvxT ApNJ8d0YLipVkwZIlvP/0WC0HbgWb4ZjhknMX7I87kGSAcczSRslodUYBkG5mhBFRYsu zF/KwBLYffgx5/FNDWpYF6ubwB45VhnFHxODSfq/CmMvBgWRD3c49BlcHPEZ6LSl15S6 aRoFYB8vGr/ytFsANt34yPEnfTYuvpH6ua3wj4LfSK15RYIhHSkjPm7YSkXOACdHorbs t89t0yNH9tFqOuT5ZpaBtnUh5CZGbriH2pA3aLsLJZj7bHVX+3FLEQr4cK/8Y9UCNDO4 Szow== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=bkSuwuay; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r9-20020a632b09000000b0050f66d3f72csi1901933pgr.532.2023.06.08.20.17.20; Thu, 08 Jun 2023 20:17:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=bkSuwuay; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238001AbjFIDPQ (ORCPT + 99 others); Thu, 8 Jun 2023 23:15:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237916AbjFIDPG (ORCPT ); Thu, 8 Jun 2023 23:15:06 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE22E30FF for ; Thu, 8 Jun 2023 20:15:04 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-82-39.bstnma.fios.verizon.net [173.48.82.39]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 3593Ell7024529 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Jun 2023 23:14:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1686280489; bh=eo2h/+7FrLj+iah4+fevq6IpoeMhN5aGJnWzkhXmtp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bkSuwuay2JCjfqnAzgCKCtTSQTsn5YGp4XT2q68E/+KPpb9FLmMbctfK02W6sl7dW mySUcPq3mgOjr4Ed3VfDrzKqWwJ8p3XXlJnaWyvD+uOtNOwc8tqa7ID4jC0CT84NnD zPZN94wkWO2jv67SDzrmICoUB26l3XcBut5ts0pEOAKoD0YaazZIdoQ2ibtD6fcLGU ZPugb+4MULQkakSConX1B2H/mAj7WXyTtnX0GHaYvO2UIpkSY/mexHpnw21CeuAqvs zvkBF7e8i+EebVM8UMZh1Ual39goU2+/Vv88nyoWbxfZssUk0BWhr/caN7hjD/jBk4 ZwGOHAbb4wxLw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id CBB5615C02DD; Thu, 8 Jun 2023 23:14:46 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Matthew Wilcox , "Ritesh Harjani (IBM)" Cc: "Theodore Ts'o" , linux-fsdevel@vger.kernel.org, Ojaswin Mujoo , Disha Goel Subject: Re: [RFCv2 0/5] ext4: misc left over folio changes Date: Thu, 8 Jun 2023 23:14:44 -0400 Message-Id: <168628045802.1458216.9443792235653947442.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 15 May 2023 16:10:39 +0530, Ritesh Harjani (IBM) wrote: > Please find v2 of the left over folio conversion changes. > It would be nice if you could also review Patch-2 and Patch-4. > > v1 -> v2 > ========= > 1. Added Patch-2 which removes PAGE_SIZE assumption from mpage_submit_folio. > (IMO, this was a missed left over from previous conversion). > 2. Addressed a small review comment from Matthew in the tracepoint patch to take > (inode, folio). > 3. Added Reviewed-by from Matthew. > > [...] Applied, thanks! [1/5] ext4: kill unused function ext4_journalled_write_inline_data commit: 40fa8be3852ff7a7b3708c6a69c9eacf98da6612 [2/5] ext4: Remove PAGE_SIZE assumption of folio from mpage_submit_folio commit: 732572e95427fe9f68197c60074b750242b84944 [3/5] ext4: Change remaining tracepoints to use folio commit: 263619455efcd0deb1f8c24f2895f48751a1d679 [4/5] ext4: Make mpage_journal_page_buffers use folio commit: 13004fbc85f58b05cfeb72372b418b6aa1caddc5 [5/5] ext4: Make ext4_write_inline_data_end() use folio commit: 04a8b77b66c5bea74b60cc2f5230a851b4ade096 [6/6] ext4: Call fsverity_verify_folio() commit: 60469ab9340529a607574a7b6ab6483217607a75 Best regards, -- Theodore Ts'o