Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1747973rwd; Fri, 9 Jun 2023 01:17:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5UOPBsODBdw3JEsoyTiQH5jx6JwNOEQNJT0oEpzH8RHLwsr7pS5aZBNSJoqH88wojykRTJ X-Received: by 2002:a17:902:ce8a:b0:1ae:305f:e949 with SMTP id f10-20020a170902ce8a00b001ae305fe949mr425103plg.6.1686298670582; Fri, 09 Jun 2023 01:17:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686298670; cv=none; d=google.com; s=arc-20160816; b=k+D1iMj40oiSb7doqXoRfmb1gX8Q14+xcxknq17fLYRPI9j3U+2/hky1QiX7siHoff 7TttAFSX7AuQrTnLEbO3elKPuC639VLWSY1YJgq0j5NjSSRuQhqjgU4y0bFVXP3kDFBW Tr5JaWYh5b/9JxsC5og0nhW3NWRYZutPCaMlUAnT59r7vJWyEWzLGNzVXK5ndxez9aif YBnjP9R7BnpFITraLXUHrCfKjvSy607/xJCLQXP8dSUvzGG1Jp7c7Hn68ipuB6Cku1VQ ZAGw9zKRf4F+tUSZM5B73WJOsZQjbsxxw7VbMFeUDCcZub+lCCuL1Cj5OvkOz+uIu+LG hgZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=QNtyRTBKmGqMhQEutu38ddqj3FUsHgKGwQBophB3zCI=; b=E/U3kwsnA8AiryMx+bDn7JTVQIcJlTBxtTVEY3QzAJ37yibFWfCuyQ3t90b+Fn5JC0 Vqs43B8CHhHSkukJcffDshgokmK2ciw5WqNaHnMjcKGf+QMzIFHdFNs9tigIAnEb05lL 9dt3BXQa1C10kUzqe5vPWJbVNTKAqaRrGeMbDrNKhWxS99c8HqSeRNewHlfWpzYnjG0/ w/zbRPDmKd3jkZvwLrfNc38VXShVIqWpwRV70Sd+sHRIs5jVJP9kzmGCORTrV6SA6Avz Gq5Y2Quwk7KsG1tlXDCL9kV4Cw34817WIIB0U2h1tcfsSSijkI8LbLXo+g3F2UW1RvFB 2tCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s2-20020a170902c64200b001ae45f0c55esi2333675pls.14.2023.06.09.01.17.30; Fri, 09 Jun 2023 01:17:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239872AbjFIIGv (ORCPT + 99 others); Fri, 9 Jun 2023 04:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239786AbjFIIGj (ORCPT ); Fri, 9 Jun 2023 04:06:39 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE53335BD; Fri, 9 Jun 2023 01:05:17 -0700 (PDT) Received: from kwepemm600013.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Qctly6kJpz18Lnb; Fri, 9 Jun 2023 15:59:58 +0800 (CST) Received: from [10.174.178.46] (10.174.178.46) by kwepemm600013.china.huawei.com (7.193.23.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 9 Jun 2023 16:04:47 +0800 Subject: Re: [PATCH v3 0/6] ext4: Fix stale buffer loading from last failed To: , , , CC: , , References: <20230315013128.3911115-1-chengzhihao1@huawei.com> From: Zhihao Cheng Message-ID: Date: Fri, 9 Jun 2023 16:04:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20230315013128.3911115-1-chengzhihao1@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600013.china.huawei.com (7.193.23.68) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org ?? 2023/3/15 9:31, Zhihao Cheng ะด??: > Patch 1 fixes reusing stale buffer heads from last failed mounting. > Patch 2~4 reconstructs 'j_format_version' initialization and checking > in loading process. > > v1->v2: > Adopt suggestions from Tudor, add fix tag and corrupt 'stable' field > in patch 1. > Reserve empty lines in patch 4. > v2->v3: > Split block device checking cleanup into a new patch (2th). > Add 'Reviewed-by' tag in patch 3-6. > > > Zhang Yi (4): > jbd2: remove unused feature macros > jbd2: switch to check format version in superblock directly > jbd2: factor out journal initialization from journal_get_superblock() > jbd2: remove j_format_version > > Zhihao Cheng (2): > ext4: Fix reusing stale buffer heads from last failed mounting > ext4: ext4_put_super: Remove redundant checking for > 'sbi->s_journal_bdev' > > fs/ext4/super.c | 15 +++++++------ > fs/jbd2/journal.c | 53 +++++++++++++++++--------------------------- > include/linux/jbd2.h | 33 ++++++++++++--------------- > 3 files changed, 42 insertions(+), 59 deletions(-) > Hi Ted, will this patchset be merged in next window?