Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Jun 2023 13:03:39 +0000
From:   Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
To:     Josh Triplett <josh@joshtriplett.org>
Cc:     Theodore Ts'o <tytso@mit.edu>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
        "Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH v3] ext4: Add a uapi header for ext4 userspace APIs
Message-ID: <ZIMjGKQdalBAeyQJ@glebfm.altlinux.org>
References: <680175260970d977d16b5cc7e7606483ec99eb63.1680402881.git.josh@joshtriplett.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <680175260970d977d16b5cc7e7606483ec99eb63.1680402881.git.josh@joshtriplett.org>
Precedence: bulk

Hi,

On Sun, Apr 02, 2023 at 11:37:42AM +0900, Josh Triplett wrote:
> Create a uapi header include/uapi/linux/ext4.h, move the ioctls and
> associated data structures to the uapi header, and include it from
> fs/ext4/ext4.h.
> 
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
> 
> Sorry for the churn; I didn't encounter these errors in local
> test builds.
> 
> v2:
> - Add UAPI header to MAINTAINERS
> - Fix include paths in UAPI header
> - Formatting fix for EXT4_IOC_SHUTDOWN
> 
> v3:
> - Leave compat ioctls in the private ext4.h header. It appears that some other
>   UAPI headers already follow this pattern, with compat defined privately. For
>   instance, quota and ethtool both follow that pattern.

Do you intend to keep the compat ioctl definitions in the private header?

[...]
> --- /dev/null
> +++ b/include/uapi/linux/ext4.h
[...]
> +/*
> + * ioctl commands in 32 bit emulation
> + */
> +#define EXT4_IOC32_GETVERSION		_IOR('f', 3, int)
> +#define EXT4_IOC32_SETVERSION		_IOW('f', 4, int)
> +#define EXT4_IOC32_GETRSVSZ		_IOR('f', 5, int)
> +#define EXT4_IOC32_SETRSVSZ		_IOW('f', 6, int)
> +#define EXT4_IOC32_GROUP_EXTEND		_IOW('f', 7, unsigned int)
> +#define EXT4_IOC32_GROUP_ADD		_IOW('f', 8, struct compat_ext4_new_group_input)

It appears that the ioctl definition for EXT4_IOC32_GROUP_ADD is provided,
but there is no corresponding definition for the
compat_ext4_new_group_input structure nowhere in the uapi headers.

-- 
glebfm