Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Jun 2023 07:47:00 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Ritesh Harjani <ritesh.list@gmail.com>
Cc:     Christoph Hellwig <hch@lst.de>, tytso@mit.edu,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: set FMODE_CAN_ODIRECT instead of a dummy
 direct_IO method
Message-ID: <20230613054700.GA14648@lst.de>
References: <20230612053731.585947-1-hch@lst.de> <87wn0853pw.fsf@doe.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wn0853pw.fsf@doe.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Tue, Jun 13, 2023 at 11:00:19AM +0530, Ritesh Harjani wrote:
> why do we require .direct_IO function op for any of the dax_aops?
> IIUC, any inode if it supports DAX i.e. IS_DAX(inode), then it takes the
> separate path in file read/write iter path.
> 
> so it should never do ->direct_IO on an inode which supports DAX right?

do_dentry_open rejects opens with O_DIRECT if FMODE_CAN_ODIRECT is
not set.  So we either needs to set that manually or because there is a
->direct_IO if we want to keep supporting O_DIRECT opens for DAX
files, which we've traditionally supported.