Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Jun 2023 11:34:52 +0200
From:   Jan Kara <jack@suse.cz>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     tytso@mit.edu, jack@suse.com, linux-ext4@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>,
        Zhihao Cheng <chengzhihao1@huawei.com>
Subject: Re: [PATCH -next] jbd2: remove unused function '__cp_buffer_busy'
Message-ID: <20230614093452.j47ntd4slhvra2yr@quack3>
References: <20230614004443.56937-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230614004443.56937-1-yang.lee@linux.alibaba.com>
Precedence: bulk

On Wed 14-06-23 08:44:43, Yang Li wrote:
> The code calling function '__cp_buffer_busy' has been removed, so the
> function should also be removed.
> silence the warning:
> fs/jbd2/checkpoint.c:48:20: warning: unused function '__cp_buffer_busy'
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5518
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Ted is now debugging other issues possibly caused by the patch series
making this function unused (CCing its author). If we need to respin to the
series, we might as well just fold this fixup into it. But otherwise the
patch is obviously good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/jbd2/checkpoint.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c
> index 9ec91017a7f3..ba4ae74c7167 100644
> --- a/fs/jbd2/checkpoint.c
> +++ b/fs/jbd2/checkpoint.c
> @@ -40,18 +40,6 @@ static inline void __buffer_unlink(struct journal_head *jh)
>  	}
>  }
>  
> -/*
> - * Check a checkpoint buffer could be release or not.
> - *
> - * Requires j_list_lock
> - */
> -static inline bool __cp_buffer_busy(struct journal_head *jh)
> -{
> -	struct buffer_head *bh = jh2bh(jh);
> -
> -	return (jh->b_transaction || buffer_locked(bh) || buffer_dirty(bh));
> -}
> -
>  /*
>   * __jbd2_log_wait_for_space: wait until there is space in the journal.
>   *
> -- 
> 2.20.1.7.g153144c
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR