Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1255346rwd; Thu, 15 Jun 2023 08:12:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4IUUObzaVDkYGJa3hoP5hlaOb5j/+/C/u63wZxScpEEZYiwDuBEcsSbbTAYi+IP8++Qm3G X-Received: by 2002:a19:5611:0:b0:4f8:442a:bc15 with SMTP id k17-20020a195611000000b004f8442abc15mr1317058lfb.19.1686841979025; Thu, 15 Jun 2023 08:12:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686841978; cv=none; d=google.com; s=arc-20160816; b=WNbU7KFY6saqDkw1Hk17o7yd9eYlCuSkEuwAJJrSF91LsD0g9HCbrNtLNujuCZVyXz +1ipDbWuFLgyBJq798cBxFSpJbP6GjUVOL/OlmbMI6H/sfrw7lnxwGtaZb3vY3/o13NQ zMgNnHBVorq0V5wyFcaeUzGSLsF5gLjbcpBTr+TSgZczHZSdGIdKpUNObMJKjdNVu659 5kZ7TmfbGT0FP+Dv/fCKnZRiBZPoSbSr8oH5I6PW4kwZ13wn6KsfCzvB1smx6COZduDQ nCB+SkOeybEtYQaf8wu3AjMcBWCENtp6fG01KE+2sHKY+e48w+Qt2v7pLM/oLocAqCqT DjFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qC8NN7fxuUhWVEK//rGqo7hDx93g+QEST3XI0PJlCX8=; b=r6y9gyJdB1hET2nrZIyMtJbcStPT+G+1t/9/0ET2ZaZStAM3ZGl+CpufByOWfI8jOz 14QujwDuNeNUBwDPLofrj8b0u1BzbHSnrPg+WR8Drs1n59mY51Dw6umlVQhcrPyQGuJK 3iWmYsYmXyb48H+KwYUpVRjHBTfbSVzbtyLQcEOLIOzO1JE3fEVzzZZUSEDicho2JPL1 cbjPP51E2rc4B6UcbNY/gZPxClELBomqY/nG2KrfKjiau6/UHhmmOEojx6PJqHvj8n4C zeEz3397LdBLFBebhF1Fdelhq8JgovqBw92KYwxsL/ZoOls3ZeYyCwS8SjVFAMWi1MQw SUEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=aGyFglYY; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x17-20020a170906805100b009785ddb557esi6467733ejw.547.2023.06.15.08.12.27; Thu, 15 Jun 2023 08:12:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=aGyFglYY; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240130AbjFOPAV (ORCPT + 99 others); Thu, 15 Jun 2023 11:00:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345203AbjFOPAJ (ORCPT ); Thu, 15 Jun 2023 11:00:09 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E04E2943 for ; Thu, 15 Jun 2023 08:00:06 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-128-67.bstnma.fios.verizon.net [173.48.128.67]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 35FExxcY026885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jun 2023 11:00:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1686841201; bh=qC8NN7fxuUhWVEK//rGqo7hDx93g+QEST3XI0PJlCX8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aGyFglYYM63OuQIWyB497lOyC9/RksmWL9lKbUnwjD3VPvKT3ampziYm2zb/SsR33 fsu0S/44Og6tVXtiTQfRlYtcp7fXc0J+RsUPqydl0Li5/zuW32+d/socbCuBaqiE2K 7k4sTg9EUDByTa1Rng3E3KkGFKNCPalCcCDb2TG7hkcXKjQwv0k8IZGL2jxFd5jrju YH+1PQX35qHZdZzEiXsZ4PDw8ov4ZefrQ0iXh1GyAPyzMrPfeEUbbN1D0fnlTUukS4 8A+Ks9ZdUp+iEizMTGJVUBFYQIT9USM4eUrV5SUmnx1fGhPMI6NWW1hFFBiVnEObcU 4PzUjxS9gV/oQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id D153E15C02DD; Thu, 15 Jun 2023 10:59:59 -0400 (EDT) From: "Theodore Ts'o" To: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, "Fabio M. De Francesco" Cc: "Theodore Ts'o" , syzbot+4acc7d910e617b360859@syzkaller.appspotmail.com Subject: Re: [PATCH] ext4: Drop the call to ext4_error() from ext4_get_group_info() Date: Thu, 15 Jun 2023 10:59:54 -0400 Message-Id: <168683994079.282246.8360074850989025705.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230614100446.14337-1-fmdefrancesco@gmail.com> References: <20230614100446.14337-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, 14 Jun 2023 12:02:55 +0200, Fabio M. De Francesco wrote: > A recent patch added a call to ext4_error() which is problematic since > some callers of the ext4_get_group_info() function may be holding a > spinlock, whereas ext4_error() must never be called in atomic context. > > This triggered a report from Syzbot: "BUG: sleeping function called from > invalid context in ext4_update_super" (see the link below). > > [...] Applied, thanks! [1/1] ext4: Drop the call to ext4_error() from ext4_get_group_info() commit: f451fd97dd2b78f286379203a47d9d295c467255 Best regards, -- Theodore Ts'o