Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1272686rwd; Thu, 15 Jun 2023 08:24:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70ahYjJjCaodIdu6S3bBW+7jGa324GfSAfXHmHN5iK9rWDT+s09i+FZQbtqau1wLZ1o0PL X-Received: by 2002:a05:6830:205a:b0:6b2:aca4:cb23 with SMTP id f26-20020a056830205a00b006b2aca4cb23mr16068965otp.0.1686842670471; Thu, 15 Jun 2023 08:24:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686842670; cv=none; d=google.com; s=arc-20160816; b=UZKEBC4YmkKvmUUxPNyMNcfmYxvSFeTmmjnGulI0kyszmw2yEAga2/9rF7NBayJMwY B7fglvI9/kuvdSZ7+Y27eo0YtTpCciegUEshLzin8017zH59FCUUeHjuHEOyHvRPr7g5 369QgmTQSoLeHx/0ZOu1z9ioT3epNkwkgmfeiAziM+s36PmAmZPqhbh8zK56TgTrY0qe rVDS9nkfRpaLdkjlHQTFrPs1G+HxCTVLbtQer+5Uze8tvBe2pgg31s6vSMQeAZNg+QcE LjsGjYtxD26vE0NrYbca3yFFcCh1mKyolaoFNV3xdAv7Dxgbd5s5De8mOEyQIFNXCuWe PF2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tgle4UqVECPLWQfg/ZwxNkNJR442spWrhIwFYeeKZCY=; b=jjhFsIGcCL2BgT733h++D6cXSEf9erGqpXzlO7bLurm2azvFkB7cyvsC01e38S6b1+ fy43Lmv5Bosq6N458YTP4HDwDCSKNV5KDOWAfYjxXEZF4wRzsUeMI4dLSaywLnH61D8S ETbBf2TIDPAGG1rt6G8sIlqAhBt1PXJCJnV0/45zMPl9CWf+2mxkgdalFOwitxUatIHP sbvGlydKhYJNjFpDi6LuhnxElQ8PWWGdaYRgHMvg9wtCk0nWpk6TUCgaWM/nALS9X49p PXIGSZxoFZlqGpBTx+AwM8EBp0fTKcAwKGjgtDPYzisuxagXgfhxzYDM6bGHVCSMQR7k yydA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Ikc+QaXQ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p19-20020a637413000000b0053ef51d3fa8si3595438pgc.401.2023.06.15.08.24.16; Thu, 15 Jun 2023 08:24:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Ikc+QaXQ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238879AbjFOPAg (ORCPT + 99 others); Thu, 15 Jun 2023 11:00:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244879AbjFOPA3 (ORCPT ); Thu, 15 Jun 2023 11:00:29 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC681273C for ; Thu, 15 Jun 2023 08:00:27 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-128-67.bstnma.fios.verizon.net [173.48.128.67]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 35FExxAe026886 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 Jun 2023 11:00:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1686841202; bh=tgle4UqVECPLWQfg/ZwxNkNJR442spWrhIwFYeeKZCY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Ikc+QaXQlvQ3x3NFjmeKou5uxhvqZkJ1q1Zn0r1YZw8av5OTMZUNM2ci7frlFJCDR 3C7u33pbPL5N+ZwCyQiODtXUqUDg9nMxaBQBGvoVmjgZaXwnzeMaC6rOm9a04dBjs/ x8myv+eERKdyBvtH+iDjkmarhviwCkvYZlSkxp5TPk1NQxSdxItup4bxBAXb74YVIi A3IaaAshV4XqgwJqnczbRSAMBiUjx4O93uHe03gNI8TpmMYdIDiCboo0Qh3QuVbQMi RNgEXbQvqoyhJxi+DfOXD+bZdBbloXizAocYX31GnxivcbZS4jiUWE/T/p80/+qrXE 01F7Q1b9OxKLA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id CF96215C02DC; Thu, 15 Jun 2023 10:59:59 -0400 (EDT) From: "Theodore Ts'o" To: adilger.kernel@dilger.ca, jack@suse.com, tudor.ambarus@linaro.org, Zhihao Cheng Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH v3 0/6] ext4: Fix stale buffer loading from last failed Date: Thu, 15 Jun 2023 10:59:53 -0400 Message-Id: <168683994076.282246.1635937592564086219.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230315013128.3911115-1-chengzhihao1@huawei.com> References: <20230315013128.3911115-1-chengzhihao1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, 15 Mar 2023 09:31:22 +0800, Zhihao Cheng wrote: > Patch 1 fixes reusing stale buffer heads from last failed mounting. > Patch 2~4 reconstructs 'j_format_version' initialization and checking > in loading process. > > v1->v2: > Adopt suggestions from Tudor, add fix tag and corrupt 'stable' field > in patch 1. > Reserve empty lines in patch 4. > v2->v3: > Split block device checking cleanup into a new patch (2th). > Add 'Reviewed-by' tag in patch 3-6. > > [...] Applied, thanks! [1/6] ext4: Fix reusing stale buffer heads from last failed mounting commit: ffea255f4052e6416a4b5738925337afbccd795a [2/6] ext4: ext4_put_super: Remove redundant checking for 'sbi->s_journal_bdev' commit: a8f17d78525adf325c80f9dd1db469d337a5ce49 [3/6] jbd2: remove unused feature macros commit: 870a42846c1055c4ff9dfd492a0929c52a367d63 [4/6] jbd2: switch to check format version in superblock directly commit: 6014c2204f10b1199e15ab61aa30274a14999b1d [5/6] jbd2: factor out journal initialization from journal_get_superblock() commit: 51bacdba23d85af2a9a145d97bfb77e6e85c98ad [6/6] jbd2: remove j_format_version commit: 1f15ee267c0498016cc4aee2cdcc18e56ff42bae Best regards, -- Theodore Ts'o