Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp7269821rwd; Mon, 19 Jun 2023 21:51:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5mDdYREXgX5ZI3GFjOgHRtbInBcAUl/fAb+ZolcF9Dno83bwy+KF30SBJc0qHX15/dnR+P X-Received: by 2002:a17:902:ce81:b0:1b5:522a:1578 with SMTP id f1-20020a170902ce8100b001b5522a1578mr9847365plg.29.1687236697516; Mon, 19 Jun 2023 21:51:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687236697; cv=none; d=google.com; s=arc-20160816; b=lR9fiEQrKor1m1GIDeUdBxQqYQmnHAP+AZg+tH4RoC5kdH/1bWb7plaDWBpVwvoWpt n/bJRbDo/5N7WE7+pZ/fNQcQFtQTT+F7j3lTCJSko4nBJQcIiA+aOFS/01uCUhhg2m0l ji9sAeV13S5I/5rdb2+FrD3MuU7XKT+FcpZUVxKXuGVv8iqGfICNNTyyjkAg9k4YJHFD tV5gwR/XaEo3YicGKdC0qmA/JPLR9HfAh9jMuUD3kTtCxFnYotP3td0Y2pBzq0xeeDQk qe1VU5EQGc7iHNYJTU8oDnfaBBq3hHasUUMUbHpCHFHdtEdowT6C/XISOEnWFlgOaPWv G6eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=IknKG44npt6jxBFUIhJKG3zkCeaSqWhLLEP9jum9THAzE1p2X70Do+Fv3cd2pQdxLS gux1PS0HwZpgWlVw9odBvOJdMeb7s6Z/VDOlkD0a9DQQgu5a8T7yxL/IBqhMO4nyASA8 jZ92BTdkL1Uj1S/Wa3klK2pzyL1JnVwvRQxRdHcgDobp7k2zmWRFcLGOnYqgsLvAuYzx gdRE0Uszy8bDgflxI8cp7NfN3mrMub4HDXeXIaz1nZpbhIFsVAAigOaZnWb5Fe9+ROJt vpodyztvLqAn6tKoW4CaRYWPWJiv+3vueu0vnQ3bjJ56efcqmVtfY3UllVzlfy/jRRX5 sk1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QeiChVQT; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a170903244800b001b66f1d121bsi1203273pls.255.2023.06.19.21.51.21; Mon, 19 Jun 2023 21:51:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=QeiChVQT; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229597AbjFTErh (ORCPT + 99 others); Tue, 20 Jun 2023 00:47:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbjFTErg (ORCPT ); Tue, 20 Jun 2023 00:47:36 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1B1DF1; Mon, 19 Jun 2023 21:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=QeiChVQT7tf/l7Q1r7WXDXzuDc TUlhW2KdJXT9248CtsyQTjKq+l52rQWzR5Xz/uDubkihDnIMkUIRceZXMDDMMkpojDdqnjPkoCd99 lU3070zo3zB/bo0FtUjgrKJL1VdZHp7A5Ccs75otFSejpC2zp3b1r8Jeij/2+oy1c/crzCoUsk5Lp xDeim6QG6dfaAgLHxCtuMBGC5voKWbIuUnJQ6LQfPk40wKBK3lRAL1qmPj44rMJbbZDzDbJKMyjvE ptf9lH/2i2JuzSRnRXWmifvnt7K+1fSokzjd0Lw1CZBNfZWal94utyqLlc8r5iqmprb2r6nm+4mXA gTh8vzVw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qBTGy-00A8nf-1Y; Tue, 20 Jun 2023 04:47:20 +0000 Date: Mon, 19 Jun 2023 21:47:20 -0700 From: Christoph Hellwig To: Bean Huo Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, beanhuo@micron.com Subject: Re: [PATCH v2 1/5] fs/buffer: clean up block_commit_write Message-ID: References: <20230619211827.707054-1-beanhuo@iokpp.de> <20230619211827.707054-2-beanhuo@iokpp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230619211827.707054-2-beanhuo@iokpp.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig