Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp12442818rwd; Fri, 23 Jun 2023 06:17:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Vxo3TeOi/dReWNv8D1moo32+FIMD6LFRNz7YXtJNkOavzLjho12P7JRGLF0IMKzLg9BD6 X-Received: by 2002:a17:902:ab5c:b0:1b0:522d:8ff4 with SMTP id ij28-20020a170902ab5c00b001b0522d8ff4mr18863166plb.21.1687526219849; Fri, 23 Jun 2023 06:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687526219; cv=none; d=google.com; s=arc-20160816; b=gcjE/822u1M6U1GTfQOTd1laBfXeU2HJSkAgsrf3h5g/l94BCjCusTmSJt0cAq5WpS tlS9xK8f+v7cN+DO7a4eMfVXO1/8DzB+gDyZiS/c6UjShO2QxYY+gxNp0fM6i+au3ZfN +d7o3/kUhQ3TNL8n+utciw+FbUdRrg7c/YKZ1zCABP41s9k1ODYN7ElK3KE9EMOtI48M 3KPyPSzWa4fFPraoRnkFiyGf4K9UylMuZogh/HdimzzqRw8HbhlYhHiPfyHuDPec0QJp x5XDQzysbP7/e4EPX6lse4Z4nDpCK5IaUzQ3U1gsX4dCXLCZmV+3eVOUO3O9J+w755xA 78MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ztC9JD/gutKJP42tTw7xRzDnyP1Mlz22AqRtCxWHul4=; b=pHUY0u24eLQCBUxGNWy2vMnFfnB0biRQOQCWcxswwWWw1rAsFZ7a9kj4Df5sTNYQf4 MmDY3P6s4cY2qYdR681GAfWvbKk2jJoF/9FzMNvribSY1ZGGNq9bsFfBfbbIduAFMVuG WYTCUc8czSsGxtoPfHE3UgbPXuY2iCVhdxiJIu2bt7rdlC70DEjIKNB39fZpx1D091nr BkzW+PckItkR1bNfGhBnsItggarwNGP/ekVSD3RF+XlDxHCv5nO/omRMkUtyrIWj8Wkv Z3POD9nWyprFgedUmpIHdHiLPs4NvNHxNYys2rLjyxw0E4BboxiymoL4ssDZxyjVhpkx ASfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=iReOyCzg; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020a170903024800b001b69de1eae1si2025686plh.620.2023.06.23.06.16.46; Fri, 23 Jun 2023 06:16:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=iReOyCzg; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231688AbjFWNNY (ORCPT + 99 others); Fri, 23 Jun 2023 09:13:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231703AbjFWNNS (ORCPT ); Fri, 23 Jun 2023 09:13:18 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52FE82685 for ; Fri, 23 Jun 2023 06:12:52 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1b5079b8cb3so1370345ad.1 for ; Fri, 23 Jun 2023 06:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687525972; x=1690117972; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ztC9JD/gutKJP42tTw7xRzDnyP1Mlz22AqRtCxWHul4=; b=iReOyCzgXqjGHDqep4+7Y02y+2KsxvqbysTBx4QdxMakwFT9O9Z6y8UTRhYCpdiwGk ivfBmaLpXRLdsg2xXtWNoGf0LJW9OuaoWVHjbG5+PmrhjKOTehTkz5xr7u03dJPl3Vvf epR4VYk9iCpPZkMT+p54jmiUndhguXzeWsKZiPn3OwVHy+V1VU+7xSZ1lgncoZQcneJS pVLxKUfpwqKrHzPfUfH95joX35kksCvYI/qVSfPkEqAU61Mo8RwQARiYkcVaAbzt+5qk cYcyAi42FXf01kq9CxVaIQAWB9c34fULDSPKve/N0V/DkCTafLxv3dWbsj8Ke3WxSlSL ozRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687525972; x=1690117972; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ztC9JD/gutKJP42tTw7xRzDnyP1Mlz22AqRtCxWHul4=; b=YQFCu77RJh8wPLOiUzfqtDFi7hj+/LkIjVErXn6yl/dxjRetupY/elQ1d1C7nCyd1n QZhrd4GmDjJjthcO02qiOuSJQNdi5b6u3AX05URDJah7quq+6FTj/USIMn6gfR7e7wgT tctsTyKZFPlzSIlx0MsykDDd1CaGc/rQz9QufSfeq9EUhWCsAya2tuYWVLc6IQMO1jFq sZ+kFBNxIBEPBnA23Xn344tl5+70cXuGd2FdXYQRs915g6yV4vZ4loNYlw8Ev0nliIJA mwR7otqyTYkcZn73AmRyGlo1MUFUQ/u77CjmH/qFtwIu2iVfRRDR/CUNr6lUep0Ev8l3 +LTw== X-Gm-Message-State: AC+VfDw1Llybh80/2sZHJHel2FNSgd7WW+3NDTqRoTRSsj2r/05zYN4r N10sKEF7zKEQm4lXp0tepVDFFg== X-Received: by 2002:a17:902:dac6:b0:1ac:656f:a68d with SMTP id q6-20020a170902dac600b001ac656fa68dmr25602985plx.4.1687525971804; Fri, 23 Jun 2023 06:12:51 -0700 (PDT) Received: from [10.4.168.167] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id c15-20020a170903234f00b001b694130c05sm5473889plh.1.2023.06.23.06.12.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 06:12:51 -0700 (PDT) Message-ID: <792beadd-7597-ec8c-e3b1-d8274d68d8c1@bytedance.com> Date: Fri, 23 Jun 2023 21:12:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 29/29] mm: shrinker: move shrinker-related code into a separate file Content-Language: en-US To: Vlastimil Babka , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-30-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi Vlastimil, On 2023/6/22 22:53, Vlastimil Babka wrote: > On 6/22/23 10:53, Qi Zheng wrote: >> The mm/vmscan.c file is too large, so separate the shrinker-related >> code from it into a separate file. No functional changes. >> >> Signed-off-by: Qi Zheng > > Maybe do this move as patch 01 so the further changes are done in the new > file already? Sure, I will do it in the v2. Thanks, Qi >