Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp15783515rwd; Mon, 26 Jun 2023 00:59:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Fw2NcsdsLydP+3K/0gq1MBPeRrgOKAmL8nWHhlL5dAtdXYh2jRqP3aqdZM5Ud3/59VpeV X-Received: by 2002:a17:90b:251:b0:25b:d304:6eaf with SMTP id fz17-20020a17090b025100b0025bd3046eafmr16020246pjb.24.1687766353899; Mon, 26 Jun 2023 00:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687766353; cv=none; d=google.com; s=arc-20160816; b=muU6MXGjsudwOyZ+zt2RDDKfV9rEFXVvfiNdLZwS33Dp3kcw2m8IjBh7iOXCqbRFno DVcIy6Sbp5nq0RhGiR7NYaCUQ+8eh2sq9TOnZ7LAwfMzZBtzyYhwng0WjcAzYYZ9eSyz /s69oP0eNRF+On8NwVdYqoUvEix+IL0oep1ShsWKzM+UxavrHvFNCCWtzYu6vWF5obSo cgEXi0iG4RzgMZzMscbT2Qy2C711pYlQMce6Ws2Vu6qORN1F1mF1Y8q3Xd1nBujDwHdc a7h8hPk4wr7aH4VTpl0/21QExl+3WxFrOy4e2FTz5kjceKFbcYi5OeQ/TODxEe96XetB Ls+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; fh=z/mnerhCvhn2RQAq80JXut3yGAEX6OfGp4SaI0BqZH8=; b=AI6QEv1whImqKeYYW3lRba5J8tZ7xDZj9TwljOkSK8hD0p6Kw9wAB3o+bByLYDsauQ OA6iIVU1Xa8y2fJ62npf1uU1vdBsayBVb8hy9JudUaSxBXSH2ZVw1AC65EhJsua4bV6Z z/v43E7PJNdMT94mZkgZr8xE2gvZ3cPo4h4+bnGY1ugM97y2LQZRzk8T3/fykWsBQW8T fTKxFPYEhooShs5L/zAihUm9/YQhjUg+s1F27i4B98ZZuWuvsgeNDHYVFx6Fq8jUvWMs 2yVYZARu0xAgoQTirDGSLEpW1a3tx+ik4eZVCfB72sUZoRFAY7nD66oa5h9lx+qvqa6M eh2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=28oUjHSF; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x17-20020a17090a789100b0025998ebdc4csi4647107pjk.60.2023.06.26.00.58.59; Mon, 26 Jun 2023 00:59:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=28oUjHSF; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229612AbjFZHzt (ORCPT + 99 others); Mon, 26 Jun 2023 03:55:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjFZHzs (ORCPT ); Mon, 26 Jun 2023 03:55:48 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1250D10A; Mon, 26 Jun 2023 00:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=28oUjHSFcWmcy2P/nVXM2Rn9NV EQvw1iHh6E8pNHSj1ngK70AHxAUx4A4VaWSBv0AxASL0u9VAjSGlhzy44wFkirMzKJ8i8OLHYfIfq MqXdj6akZOk7J12Nq+aXl9D+1H3e1C5CRmITDg7Cuxpww/IxWtmXx0TCqVhyP1Pw9XDF6dE4rnkpn dY5tcbs7B5S3XKsog2ojglLgh56zCGc/5Ls9Q3of1me0PkQNSyTijKaqX+NJpCk8WQur+Z33KoD6X X7rK9xsqxXYiv0fl4Uo868I+mP5laI12Ubu8P1zvXPDGcDfcy5Yn2eDxVj6w62TSJwfXbDV+UKbhR BDD3zugg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qDh4N-009bI4-2V; Mon, 26 Jun 2023 07:55:31 +0000 Date: Mon, 26 Jun 2023 00:55:31 -0700 From: Christoph Hellwig To: Bean Huo Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, willy@infradead.org, hch@infradead.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, beanhuo@micron.com Subject: Re: [RESEND PATCH v3 1/2] fs/buffer: clean up block_commit_write Message-ID: References: <20230626055518.842392-1-beanhuo@iokpp.de> <20230626055518.842392-2-beanhuo@iokpp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626055518.842392-2-beanhuo@iokpp.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig