Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp15784104rwd; Mon, 26 Jun 2023 00:59:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4FQ1LqM4S1F8Up7+RnJVxsYfF5MSZGXJW8+c1k27Mi1Vhy0UvBEzPHG6JuRN6O8aLiJhmu X-Received: by 2002:a05:6808:124e:b0:3a1:b938:e9df with SMTP id o14-20020a056808124e00b003a1b938e9dfmr8019546oiv.31.1687766387863; Mon, 26 Jun 2023 00:59:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687766387; cv=none; d=google.com; s=arc-20160816; b=c4XueLRiAd8a0neQjzoOZC1Fb9Xs2ujnxwei02oe5Z7QRH+A4JOO6ehXiuJIObUCko kWnKma6vpp0e46OzXDkNmUc09Dng0gTILLGOyMazIKWY570QX6j0YzqU8AJpJJU8ASjH Lrkuy2BMYVjKcWqzwjQ82SKlww60enULGLp/1mOVHEI4itnFdW7MoHmsxLk/l46C9s12 0uNiQYul8Mbz/RSTr0xupfPaOjaWuZ5Z07s6HhLxJfkuQzYkf+DTPNhQNKrzSb4sgHqP TPqL84xM8DZSQDcxS0szwhr87qnkn+hOkz+wIl2xIsqbG34ieKYfmEVgAvi/1Bwn1qGq RJtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; fh=z/mnerhCvhn2RQAq80JXut3yGAEX6OfGp4SaI0BqZH8=; b=gTWYKZZpVxIPy72K41hXvBg2pwOG1YjdorfO7H064pzg2az7/lEAz4hKAWtb2tu1hu eY2MCW2u/u0KJ7xxzduW/haEWmva9eDydvXGyBPaXMHN+LTZXu17dqS7w9c5wLncrt7y E0+/za0F5v6B6tDP76KTEuUHgQFr+7bsvJvS92D5UgC3jCo3kgt20VM1T/H28wlr6RsG X9NBtgoBcPSiZss7jFXMA+kTA551c/KcVZidRZqdeGtee8P2Q3hUt4ZIvZ2orTYPQzvV /bbzUfZBDKhmgiMZOUzs080ry/6sOGVVVl/im3CIKP7HZKHZwe6VxKLcy3uhUVQ3Dc5v NENQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=koVawv21; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s65-20020a635e44000000b00553b9b18870si4695017pgb.570.2023.06.26.00.59.35; Mon, 26 Jun 2023 00:59:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=koVawv21; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229629AbjFZH4K (ORCPT + 99 others); Mon, 26 Jun 2023 03:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjFZH4K (ORCPT ); Mon, 26 Jun 2023 03:56:10 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A5551B0; Mon, 26 Jun 2023 00:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=koVawv21+4nk5EmTbsanG4scAf ZitGqUvhvb1pqnPUhBu8dq18h3NwC/QTNsIILUylVoEZCpMnZtvi1lb+uVfA1T6WIwkc6Gg1JAz/e mfetdA1UmIoPkuTvY3Pf9m8xgyCC/v1Wtt9grLUvTSVhnFB94EITb2VhmuQIwbACiW2XYQJQvVb44 axh4/1XFEP/blscM5RSV62nkUxG0UkKipGI3oezFI/uZUMVCca7frZ0UEN3AKB6mOXss8OFgFAymn JArOJ92nkFhJIEIkoH6UStLcAan3QGemr4oMhZOaIIK+qxoAdMtOfzingDwxJUwRDQg3srsRb20NF KiJxWXBg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qDh4m-009bLM-0z; Mon, 26 Jun 2023 07:55:56 +0000 Date: Mon, 26 Jun 2023 00:55:56 -0700 From: Christoph Hellwig To: Bean Huo Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, willy@infradead.org, hch@infradead.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, beanhuo@micron.com Subject: Re: [RESEND PATCH v3 2/2] fs: convert block_commit_write to return void Message-ID: References: <20230626055518.842392-1-beanhuo@iokpp.de> <20230626055518.842392-3-beanhuo@iokpp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626055518.842392-3-beanhuo@iokpp.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig