Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp16065644rwd; Mon, 26 Jun 2023 05:25:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5dgwaVYNXu2ORjLILCGMC3sCl/2bGYIVVqnH5MPUK8jlgftcuIif2mu7+TbllV5fjtTsa3 X-Received: by 2002:a17:902:7591:b0:1b1:76c2:296a with SMTP id j17-20020a170902759100b001b176c2296amr2799047pll.60.1687782334096; Mon, 26 Jun 2023 05:25:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687782334; cv=none; d=google.com; s=arc-20160816; b=CMvMDMD33Fx1PfDO4ECugzq8wU7nW6VnR4+mPfi9f3ukqZbqer9/KvOicqjPOBflj2 yQAN54MndFqNhAXFvslIUhtpPU90vOVjj7hcVwC8dBi27AzjRFAPKTzGDgDs3Cp2b4xR bz3lP/h1k9Y3TosEx6ADab3d+iaSSS7eQOyIoiaIJ4ZkIbGQq7aVFGMDQaG7d6PxuTpb FVcsZchO5v3jHEPDqnThWfX4nfgp/6AHcZdWBus7Cy8bbxuvsAJ188s1QS4FwlNLx4XE EsXvnXKpWrV/UWS03azZKVwtdzs1z4aVUrnU4HZupuG8dZ3jbgQpNNXcAmH/Gjd1b0FF lKWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QsSJMAZtVZXkWomlSrdllY9FMvN+dViDBTPbQidYo/8=; fh=KbcW+xK4MR+6OGSK/NfF91lsRWYfvFy9fmrpE1i8miI=; b=yQhOtURJ5pZWiSCrhASWv6h4ZpIPXiYZ66BbjggRYiKbtJs6MOZGsscBc2zjA/wPHU K+xuqsoIo7V2GIjy69XuS+UG73azalbdNs3Tay2Bgx5zW2XWPL2m/PnGz794BzdAuFey IxSAZq4t97MBZSYdv7n5g5aGHFQzM/cIQEN2Wtf6w4zuF5xeSTeWiDD6hsDBlGti1WOq +p0XAxvu1dyfWHIuQqYYh5/+kmQmL03BiGu8n34hfufW/QyUK7k/Ts0DSuinCord7Q2q gm0mHDjrYj0fTZppuRGIkKNlwToot+U9pysrL2cp6I5y2eSmNZb8t6F2peUwqaTGNZjd FUzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=aWgYj0Ep; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i6-20020a170902c94600b001b34159f341si5053590pla.596.2023.06.26.05.25.21; Mon, 26 Jun 2023 05:25:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=aWgYj0Ep; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbjFZMXe (ORCPT + 99 others); Mon, 26 Jun 2023 08:23:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjFZMXV (ORCPT ); Mon, 26 Jun 2023 08:23:21 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DEA835A5; Mon, 26 Jun 2023 05:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QsSJMAZtVZXkWomlSrdllY9FMvN+dViDBTPbQidYo/8=; b=aWgYj0EptSZlfXLuEr483t+nU+ q8UEuBBhZLAzD0uNIL1JvRlmKknboUmTrQZo88tKIbVAtmLlOIVej5LP5OhvOY9LMzyJu53XAxFp+ UOlravYeXRzFTBtKsApaa7IASSoeS0c1MLmx2PcK211ACZRQZwCKruz7n+knj1LwRYzGMqyI/4kQB K/JGjwnUki/32tsMPJh2LrnxjrGnA0IigXWv9l1s50SB15bTh0jzi44yxTP20c1Kb0P/poghgI39l IqXo7IQ76qkGkF/3w6uVzL3jADP8FwgeGHiaBU5gkJZ057UYX4KEd7HEmTRny1ITai+3m2LjsM6Xn 6eQcyuUw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qDlDV-001heE-V9; Mon, 26 Jun 2023 12:21:13 +0000 Date: Mon, 26 Jun 2023 13:21:13 +0100 From: Matthew Wilcox To: Bean Huo Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, hch@infradead.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, beanhuo@micron.com Subject: Re: [RESEND PATCH v3 1/2] fs/buffer: clean up block_commit_write Message-ID: References: <20230626055518.842392-1-beanhuo@iokpp.de> <20230626055518.842392-2-beanhuo@iokpp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626055518.842392-2-beanhuo@iokpp.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jun 26, 2023 at 07:55:17AM +0200, Bean Huo wrote: > From: Bean Huo > > Originally inode is used to get blksize, after commit 45bce8f3e343 > ("fs/buffer.c: make block-size be per-page and protected by the page lock"), > __block_commit_write no longer uses this parameter inode. Reviewed-by: Matthew Wilcox (Oracle) I'm expecting that Andrew will pick up these patches. Unfortunately, you've sent them right at the beginning of the merge window, so I wouldn't expect that they'll be picked up for two weeks.