Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp16065952rwd; Mon, 26 Jun 2023 05:25:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6xC83sjz14DxgNjY+Pd/T/meha2DNg7LTFMhCo//vPYk0DV4vzgGwtco4Dca1CR1Ug9UJA X-Received: by 2002:a05:6a20:3954:b0:126:aa77:a118 with SMTP id r20-20020a056a20395400b00126aa77a118mr7048480pzg.16.1687782350126; Mon, 26 Jun 2023 05:25:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687782350; cv=none; d=google.com; s=arc-20160816; b=vfn3X8dKyJQuFT2YR/8MhFi8lYk+7kDOwK6HDyIyahYt1rbi3WB8MNyS+lMplvRla6 Ykhj6a3xX7ccGSGfnpOjORisE5CpZ6mvKFmbJZ/6WmnLx3KU3pfLmpbGSGFnfGaPP+Y4 59HAffOMt3cqReBNC4tyh3jszRLCNRL8AJo36qeGCqjdPm1ulPKPc8UNIy9JTS0VjKdP Hmmo/WDpID4k1PMP8/LXwXTSoN6dGxfcJf6L8Rr6bj4kKG+YieQ29g8hb2kHK4qucXfR 7x50yVZ1MQExlNTayYQWg7Ke1/geeRosojnsk+/7/BQ3UgU1pu/pBjxyEwjzzXA1RiR2 82BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QW8TEI4qH5XCRgSwvkSbDgPot3AE97HrQk+bQXZ3kvQ=; fh=KbcW+xK4MR+6OGSK/NfF91lsRWYfvFy9fmrpE1i8miI=; b=OD0jjqUJP43ymW4ne7rJt6BxXP/efGJeUyK+mfo3r+dSF31ntrcYfTqDo6dnJorMSV akRhoS+lJlOPi74dZLe+V8qzELuBb4tWNr6tJxLpm0QtB6jMyng67D6/VshB5GHrICxr 62WpewhkGS+Tzx+po+quGtvcENUR5FHTlEBy7IkG4M171uKyGb8/nxoFdjrE5eU5a1eL cOxXdPro7Lse6JcN0QbQVrbNzP8OEAFHbDIZfKWGWvgvw8+K5MvwLmwbAitkGfLNZ+Ys XDG+L4QlJcxWS9Aibke8L+R5Hhf5owm8nRJ3gwpDXMvlwL3biKQyYNipiv8IvVFJCYq1 toVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="QitTNH+/"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ct19-20020a056a000f9300b006650ccb39e9si4736572pfb.294.2023.06.26.05.25.37; Mon, 26 Jun 2023 05:25:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="QitTNH+/"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229844AbjFZMXp (ORCPT + 99 others); Mon, 26 Jun 2023 08:23:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbjFZMXZ (ORCPT ); Mon, 26 Jun 2023 08:23:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38E362720; Mon, 26 Jun 2023 05:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QW8TEI4qH5XCRgSwvkSbDgPot3AE97HrQk+bQXZ3kvQ=; b=QitTNH+/N/BFpZARCix979ERxI b6Iptj9RWzhdn7qboGO3PfmG88sySWpFQ2qT7DxL6W+TgoK93OCGrZ1g/1d9gVnCI0B0voOq1+wi/ 2exEGgCCYkK+z0TLkLYcK9ItLpUdUx/rADWxvJaYAoEpjSfEcLR22gjwGgwzRaHgQh3DozSZc2YZX mvpwRPq8SaZz869b/ZAgYhCx1yZu/SJ4bQImIQCs/8vW+0RrxPmf6Q2fEN0soDXZnS+61zR0HGNzq bdIJIApXUsUtOEcKJOzovxhjVcHrowVDprRtfLJNJwgyGToLhiAPQoQw6eNi0FcTb2kRzeWvAstA1 CZWkyyNg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qDlDp-001hfs-4K; Mon, 26 Jun 2023 12:21:33 +0000 Date: Mon, 26 Jun 2023 13:21:33 +0100 From: Matthew Wilcox To: Bean Huo Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, hch@infradead.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, beanhuo@micron.com Subject: Re: [RESEND PATCH v3 2/2] fs: convert block_commit_write to return void Message-ID: References: <20230626055518.842392-1-beanhuo@iokpp.de> <20230626055518.842392-3-beanhuo@iokpp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626055518.842392-3-beanhuo@iokpp.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jun 26, 2023 at 07:55:18AM +0200, Bean Huo wrote: > From: Bean Huo > > block_commit_write() always returns 0, this patch changes it to > return void. > > Signed-off-by: Bean Huo > Reviewed-by: Jan Kara > Acked-by: Theodore Ts'o Reviewed-by: Matthew Wilcox (Oracle)