Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp27705356rwd; Tue, 4 Jul 2023 06:48:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlGLgBv4SXXgXJ6W8vwUkAlqgFfLOP+9CeAmrjIkM4L0iyHXIuNCEcWIMbKF+oiN6f9MFmxQ X-Received: by 2002:a92:c608:0:b0:343:13e1:68ad with SMTP id p8-20020a92c608000000b0034313e168admr15283573ilm.10.1688478514876; Tue, 04 Jul 2023 06:48:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688478514; cv=none; d=google.com; s=arc-20160816; b=MQAGae6J2xmnZcWYa5oRKkDuzoAn/Dn7xn04BFLrk28RUPHwGzus4sZwWrq+hQzsWy oQtR6Wl4T8arpMkx0EKWRupnwesI0KOIF9pzIZdBYjMCKvGjnv+ER7oUdM/jpuYSPTmE 572+3Oa20pZBGlbxw8dAj6exRH3vMi6eN6o3g2tbKYPM2XV4CC93oU3W1DyK4zxos4+v ijmbV4aFeDB7Rvx28liDVHdv4OVc4yrE6+ZoKidIu/NKxlUqYGg/o5LEW+dPb4k4BGFo 6MyoiU6AbGQKF6BNotp2q6m3dzc+srxi7KPxOWsd7uS/qaOvxD3SdlmhqX/aAnZR8d9f txcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=VQg5bZW07zdZv76QugzvbU67otWjm671FyvyK73Bxhs=; fh=Uq/HK0tePPZ4uFSrjmAoQ+8fm8HBRKIYZPcFTEYnhm4=; b=Zs6NQLUWCCnLiOBYlh1wvtObGPhj107bApp22wgkzS2/puupkisgwOh8x3LCIX1OzW jIYgvP5Dey7huBI1B1Cm60Gd0ah44dc+qPiFAI9x9x3PoTmKQU41Tx6QL+c0f47nQirU 9R5kIRTMML+0dfpDx7h1X3raplQA/MHZ/qclZ+VNC5E7gWXT6uT8R+OCIxXnVzM4MHbS +q9JomqLRpNzzxUEJAc69goht63UjoZo+PQ1Rf3dxLx1RGXsZdVfLrDJHMytbphHudRi uVxLzc3jP4wpaM3LXXw73z8eFupvVWsGHGMsqlSljf7WUkwimvSy5Yirlt9SFv+HDmlI pL3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b15-20020a630c0f000000b00553ad455581si20961913pgl.296.2023.07.04.06.48.21; Tue, 04 Jul 2023 06:48:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231565AbjGDNoL (ORCPT + 99 others); Tue, 4 Jul 2023 09:44:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231444AbjGDNoG (ORCPT ); Tue, 4 Jul 2023 09:44:06 -0400 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 218A8E6E for ; Tue, 4 Jul 2023 06:44:06 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4QwPCP2MQQz4f3mJp for ; Tue, 4 Jul 2023 21:44:01 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgD3rLASIqRk9WjENA--.31120S13; Tue, 04 Jul 2023 21:44:03 +0800 (CST) From: Zhang Yi To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: [PATCH 09/12] jbd2: drop useless error tag in jbd2_journal_wipe() Date: Tue, 4 Jul 2023 21:42:30 +0800 Message-Id: <20230704134233.110812-10-yi.zhang@huaweicloud.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230704134233.110812-1-yi.zhang@huaweicloud.com> References: <20230704134233.110812-1-yi.zhang@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgD3rLASIqRk9WjENA--.31120S13 X-Coremail-Antispam: 1UD129KBjvdXoWrKFWrWry3GrWUGF15Zr4xJFb_yoWfZFXEqa 10v3yxW39xtr47A3yrC3yUursY9rs7ur1kWw1ftw4DKrWUJ3ZIqFn7tryjqryxuw1kKrW7 X39Fkr40qa9rKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbTkFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUAVCq3wA2048vs2 IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28E F7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr 1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0D M2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjx v20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMx C20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAF wI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20x vE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxK x2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI 0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUl2NtUUUUU= X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, MAY_BE_FORGED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Zhang Yi no_recovery is redundant, just drop it. Signed-off-by: Zhang Yi --- fs/jbd2/journal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 065b5e789299..cc344b8d7476 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -2506,12 +2506,12 @@ int jbd2_journal_flush(journal_t *journal, unsigned int flags) int jbd2_journal_wipe(journal_t *journal, int write) { - int err = 0; + int err; J_ASSERT (!(journal->j_flags & JBD2_LOADED)); if (!journal->j_tail) - goto no_recovery; + return 0; printk(KERN_WARNING "JBD2: %s recovery information on journal\n", write ? "Clearing" : "Ignoring"); @@ -2524,7 +2524,6 @@ int jbd2_journal_wipe(journal_t *journal, int write) mutex_unlock(&journal->j_checkpoint_mutex); } - no_recovery: return err; } -- 2.39.2