Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp31781013rwd; Fri, 7 Jul 2023 04:29:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlF53/n8yCcSZIjA5Xv892JLjd6CN09RSlIz6jxvyZ1v00zi7dtclm6oaXGq6rfpjtuKi16n X-Received: by 2002:a92:4a0e:0:b0:345:b40e:43b3 with SMTP id m14-20020a924a0e000000b00345b40e43b3mr5003626ilf.12.1688729379345; Fri, 07 Jul 2023 04:29:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688729379; cv=none; d=google.com; s=arc-20160816; b=A8YuOAc9dwhIhlZUI1c1yb9eQyiQgEMZG57t7t9dTZvUbYHIUSt0HbEHDYjXrxMBkZ J+qQYdecMS10eXM7o8yWGRJ8KGs2aSjGQqh8jniL+UGGl7+QZbxZ6GbfROLCW6aWU5ff 9yZ0G75CZa3pVO5/JwcBWftTV2nUMyVJQhHAh4AEZ46BB+l0RRS0pmxUlQH0E9OP3pOl 97zJAOWFQSSlwGds4c+Wy/Jnl5jVXSzWHym1oYzY3XyW88DxOHXg2kL6AMehgg+uLl8W WSTe7Ty3kCng58oc/kqluDiOW1KA6nIQilDwp/s3yMHBAaB7Tvt98ZzMN5uEBfkqQWZN OBDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RUfYUy8/J6JDn9FoGNDP036sYhvQ7qr7NPrif4Grdk0=; fh=j2Q12IXzOppU3qEPEa8JFyyD74O/uHqK96pcKXID0Og=; b=nfUP/7S35uA6Zp0+AHDp6hsPxysj0ZigUDp57g0RQq9PXAAZSYY7RdQ8EoGQr5KmfY WuTy4nqlILSTOpBxIp3mkFpVBp+bgA79/5LqFLw63Uamkr+YBtQ42UP6gDzTolNLYQ9L CkUa1DbOvABZpa6cw7S+E+AnXgiZTWfw19hzb21tFnAfO7W7fT+DVpb56xUw7O8LN49U jM9MseVGyzEt5vCDihvzIqJRVbgGbVwLXz7hG8Q2ks5ZlEQLlmJNRb8LpeCC+W/hldkz 0A289C61/159PEZPK6/I1i/dOyUZsCS+bz33XR/evKrkETLJ/jFV3VW4NDfjV1WRrrYW R8+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=W8BupQP6; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g123-20020a636b81000000b0054fd9f2dfebsi3583035pgc.704.2023.07.07.04.29.19; Fri, 07 Jul 2023 04:29:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=W8BupQP6; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232637AbjGGL3Q (ORCPT + 99 others); Fri, 7 Jul 2023 07:29:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbjGGL2r (ORCPT ); Fri, 7 Jul 2023 07:28:47 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 317AC9E; Fri, 7 Jul 2023 04:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RUfYUy8/J6JDn9FoGNDP036sYhvQ7qr7NPrif4Grdk0=; b=W8BupQP6fTnw1maVtPw7n0FTsE YYE/luqofOMT0IhbP2TwnItjey780Gaej+IMiW55ud+2XaULxiO0l44TVjXxHDze0xRAuH+mluyhr 7ui49FHiGFXBu/ov7yuPVdyKZ6eJKL+3QsdTV3Gb1KlNN/rv7nlB69UacHrPvm/XuXzbJNEgBM50m lj+5xIDBkcqtRkKNokX0ONlo/QTCRQkdYA2xSwzuGzgo4ax7OTAfgkKR0gXaMSjd0fblhIFZkcy3O uLWO9DupcrKt+pDlGpSx+Miz6qpzw/HtoMbVHr58WOYYIaYLstJnc/oPaBlHCJkaDsT5H35KaxEXD vOIi6ADg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qHjdh-004Vpz-0w; Fri, 07 Jul 2023 11:28:41 +0000 Date: Fri, 7 Jul 2023 04:28:41 -0700 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions Message-ID: References: <20230629165206.383-1-jack@suse.cz> <20230704122224.16257-1-jack@suse.cz> <20230706161433.lj4apushiwguzvdd@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230706161433.lj4apushiwguzvdd@quack3> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jul 06, 2023 at 06:14:33PM +0200, Jan Kara wrote: > > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode, > > void *holder, const struct blk_holder_ops *hops); > > void bdev_release(struct bdev_handle *handle); > > I'd maybe use bdev_close() instead of bdev_release() but otherwise I like > the new naming. We're using release everywhese else, but if Jens is fine with that I can live with close.