Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1227223rwp; Thu, 13 Jul 2023 07:58:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlFqAwefkOyFacMWwmc6lGrHw8rKbYiybwbWWtauuOIti1ab24fP84PtXXqwDWXprLsyCMp4 X-Received: by 2002:a05:6a00:244d:b0:66e:fd84:c96d with SMTP id d13-20020a056a00244d00b0066efd84c96dmr1616819pfj.13.1689260336039; Thu, 13 Jul 2023 07:58:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689260336; cv=none; d=google.com; s=arc-20160816; b=mK8qYwb8RTwuuFcZQWf0WpSzUJosKs+6z9J7k3ZbBdvpId3d3YeIaAwjGTrT18zXmp eARScDcpbtScGNmgGhCgQc01Zw9AR31/Dne5X7s5u7K4DtJjd4gS0hvKRownCDcZ95n0 fISy1HhhbYcOvj7mEH4nY4bBMeUYu9JJ6E+x7pNvnHsg5GBudO+/cJ3q782/E2bq/XT8 2hhNx/hNKfuTpmCiqYTJmiRythYma56IpQb5RmFsSsywwYFmwbStFIZBOC5PpNK0Z/B/ jkvop09dEiA8DGXPhhNtKCjTMpv4zQP0Yb+aA/t14sR2XUfYO6EM0rBrKs6Qtd9I+Dxv iUOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eYuaEagulq7Vxq4xssHucTWaWl34VzjA4qgAICEF4yg=; fh=7MWNHW/Yf1AzBC3TMwk+1TtWOc6eKZKmg59J7m4hxF0=; b=qkxlVzZknh/tThI2DawmNbwXPGqGVA5ZL1WxdV0Z2ZN7jPogsca9wDOYAZ7DNT4/TF Y7ZtQpUbH80Jc+CkO8N0tKY9jqXdiV1XFybaQSr+5LMEz1K8J8DcXRcdiqpBsh9wz80L DwnRaE9E0VI7SmXmMkydyxOo6ls2SATdviWG9gvItOozpZGOQOdGfor+0DdvrAch8i7B 7GUxG+Ma2Rl83WG/929UtNVFYAWL+n1YTkN4FBI/A7QANKdZViLWhwU5JbDbTugwK1Hd ynP6/9ko4da8ZE+ab22Fh4Ly4lrtt0HJrWoOZdK9KN6z8D3JtK0MsN0ob9JnYCZzDxnK 3+5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=OdRNzaG+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a63f508000000b0054fdb18c877si1278725pgh.607.2023.07.13.07.58.35; Thu, 13 Jul 2023 07:58:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=OdRNzaG+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbjGMOz0 (ORCPT + 99 others); Thu, 13 Jul 2023 10:55:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230516AbjGMOzZ (ORCPT ); Thu, 13 Jul 2023 10:55:25 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E69E2719 for ; Thu, 13 Jul 2023 07:55:16 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-82-193.bstnma.fios.verizon.net [173.48.82.193]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 36DEtB0q026882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Jul 2023 10:55:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1689260112; bh=eYuaEagulq7Vxq4xssHucTWaWl34VzjA4qgAICEF4yg=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type; b=OdRNzaG+VPuPZ661uvfM+K7p7v7pzSZ8mbO6uiidjRb0QOIDN7hdsKlxxTcspLWbp F+si+o67PsImwu5ImSuixOediOwdLht0vPgb5+z/5Jdxf1jh+cT+/KTyRX2dpfOv5v XXnLnCL/2vt7KzzuRHaK+9yEgBwKP5f6yQqm7fLGa8+41EtuC6g0lbxmH1Eh3/W/oB 7bxjFTKEWF00zr6Mf2kQF17Qyp4YhDIhS5JahmdUZK/0RZQA+LOmplP3vNqmPIVvKe JO41M2hVgb9GstS4AUzWp1zT05kBeJ9nyMHf8r2WP8B8DG6ebNpYjNa6T6itKj7/KG Y+HWFrS7OqeHg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 00F6A15C0280; Thu, 13 Jul 2023 10:55:10 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Eric Whitney Cc: "Theodore Ts'o" Subject: Re: [PATCH] ext4: correct inline offset when handling xattrs in inode body Date: Thu, 13 Jul 2023 10:55:06 -0400 Message-Id: <168926009829.3728471.16954986792300189725.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230522181520.1570360-1-enwlinux@gmail.com> References: <20230522181520.1570360-1-enwlinux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 22 May 2023 14:15:20 -0400, Eric Whitney wrote: > When run on a file system where the inline_data feature has been > enabled, xfstests generic/269, generic/270, and generic/476 cause ext4 > to emit error messages indicating that inline directory entries are > corrupted. This occurs because the inline offset used to locate > inline directory entries in the inode body is not updated when an > xattr in that shared region is deleted and the region is shifted in > memory to recover the space it occupied. If the deleted xattr precedes > the system.data attribute, which points to the inline directory entries, > that attribute will be moved further up in the region. The inline > offset continues to point to whatever is located in system.data's former > location, with unfortunate effects when used to access directory entries > or (presumably) inline data in the inode body. > > [...] Applied, thanks! [1/1] ext4: correct inline offset when handling xattrs in inode body commit: 48ef88508c16866ec9641fdda38642aa1f776fd4 Best regards, -- Theodore Ts'o