Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp10628985rwp; Fri, 21 Jul 2023 02:15:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlFULqxwBNSbys+TbrhZUfSTYDUHITJZ6mKi/bijdSlG3pYMDbiqmhkmalTB9ZOjRH9s/yrX X-Received: by 2002:a17:907:7750:b0:992:4250:5462 with SMTP id kx16-20020a170907775000b0099242505462mr1339446ejc.50.1689930904306; Fri, 21 Jul 2023 02:15:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689930904; cv=none; d=google.com; s=arc-20160816; b=LdfZTA32/nCPTkj+A1BnEXKf9RJuXC/dhZdYY4AYGYfgnCXoIQSLsM5QZ+ajUOE/Xf fr9KyRb2sJX4JC/5+gKBCZnpndmaOLpBneWUoSV+GzuYTRDOCFVTGP3SrWvLNBBymLU/ aJJc7XoIl0uKfmE4SMKhxgRAMwZp36LyFAt6B8xUDb4j2cJmD8DBs2vSv2f3q6N8Ymvx MVnuQVNFtn3Dg7dTBLEc+pk6tthtckfLbbk/gYfbmD1+eoUVJ+GC+As88X7dURM2c1OG vkPA9RI2C/NWzgQKb/qRoFuUz5XDWpwR26eN+a1YuZaGkfIrtFgJ2hjojvuXOHHTH3Oh KKSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=27Nzqrah1zLOAhZ2Ey/0gVNZdx8OwSov1Dt4BP72qi0=; fh=MlGqaUnvBjpXmiP990bdf+mzv9VjPrVaE5OVdv29XYE=; b=A6I5ZO9AFSlKt/6NPBorc4hO1YcKnq2BLlKT3fpQiugTw7EchNWfYsPBdo+6gHlrWO odP0X7Xn4S7m+UzJtqd7P6q9+VeSHQpUOKj6aE+v+xDbV2i/vQ1FJ3g4cJfDvL4Dsxkw AcEXDLUQjVtJrY2EljdPvlxm1fMmXJQoJals/LpZmclebuihjlljHhVqXr8aCgG5+59T gJ0H4MK953wqFxbDAZUkI0i17qrsyamTQZjW+iOGBTEvRLHEdYkt83Nf7gWF5tNzSbs1 1oL593t3oBXrpe88uZgWnG8GTEHzWXuaZxT086ujWayhBYF6kHkaqptvGKWEiM6flJmo G7Kw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gx24-20020a170906f1d800b009930ef7f05dsi1765971ejb.908.2023.07.21.02.14.39; Fri, 21 Jul 2023 02:15:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231593AbjGUJJw (ORCPT + 99 others); Fri, 21 Jul 2023 05:09:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231441AbjGUJJo (ORCPT ); Fri, 21 Jul 2023 05:09:44 -0400 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8F1D1984; Fri, 21 Jul 2023 02:09:43 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4R6kJx5GS3z4f3s6V; Fri, 21 Jul 2023 17:09:37 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgAHvrFPS7pkqi7fOQ--.527S12; Fri, 21 Jul 2023 17:09:40 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca, ritesh.list@gmail.com, ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: shikemeng@huaweicloud.com Subject: [PATCH 10/10] ext4: correct some stale comment of criteria Date: Sat, 22 Jul 2023 01:10:07 +0800 Message-Id: <20230721171007.2065423-11-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230721171007.2065423-1-shikemeng@huaweicloud.com> References: <20230721171007.2065423-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgAHvrFPS7pkqi7fOQ--.527S12 X-Coremail-Antispam: 1UD129KBjvJXoWrury8Xr1rGF17Aw4DWFWDXFb_yoW8JrW5pr 13KFyxGF1fXw15ua1Du3WkWw4Dua1xWFyUJrySvr4FvFy3JFWfuayDtFykZry8AFs3Xw1Y yrW5ZFW7G3WUu37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUPF14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2jI8I6cxK62vIxIIY0VWUZVW8XwA2048vs2IY02 0E87I2jVAFwI0_JF0E3s1l82xGYIkIc2x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0 rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6x IIjxv20xvEc7CjxVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xv wVC2z280aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFc xC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_ Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2 IErcIFxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVW8JVW5JwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JV WxJwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTRKfOw UUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org We named criteria with CR_XXX, correct stale comment to criteria with raw number. Signed-off-by: Kemeng Shi --- fs/ext4/mballoc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index b04eceeab967..e30494f3d289 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -2778,8 +2778,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) /* * ac->ac_2order is set only if the fe_len is a power of 2 - * if ac->ac_2order is set we also set criteria to 0 so that we - * try exact allocation using buddy. + * if ac->ac_2order is set we also set criteria to CR_POWER2_ALIGNED + * so that we try exact allocation using buddy. */ i = fls(ac->ac_g_ex.fe_len); ac->ac_2order = 0; @@ -2836,8 +2836,8 @@ ext4_mb_regular_allocator(struct ext4_allocation_context *ac) /* * Batch reads of the block allocation bitmaps * to get multiple READs in flight; limit - * prefetching at cr=0/1, otherwise mballoc can - * spend a lot of time loading imperfect groups + * prefetching at cr below CR_FAST, otherwise mballoc + * can spend a lot of time loading imperfect groups */ if ((prefetch_grp == group) && (cr >= CR_FAST || -- 2.30.0