Received: by 2002:a05:6358:701b:b0:131:369:b2a3 with SMTP id 27csp3940000rwo; Mon, 24 Jul 2023 20:34:10 -0700 (PDT) X-Google-Smtp-Source: APBJJlFWDpICJ6RK9U9V6+L8uGI4Dlrv9XvgJJCBVfYPi3uayvXz5JEP93PZRga/OnBhwq2V4e3Y X-Received: by 2002:a17:902:eccb:b0:1b9:e9b2:124b with SMTP id a11-20020a170902eccb00b001b9e9b2124bmr10010243plh.64.1690256049522; Mon, 24 Jul 2023 20:34:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690256049; cv=none; d=google.com; s=arc-20160816; b=dM91tPP1v2mW2u9lsd2QSThezW3Ygj+xwuNz4Z8u/t1yHnL5rT85PinZHeVsXH4GYO uVqLx2gvHrkcl2H3Yb0V2WbQL3cHdHbiGT6v5xgn5Ay4wv0VHbE7h9Ug1tcg9gz//WCD D1DFj72j5s2ZEfWLeflWRes4THxOo97EGcvG+ig676vdN5YZvmAQJtg/AfYjaWUl5syn LqEPQfRwcUuT+UK8etT0mnA30ISTTykNq6SXICF0FLxoX+ARKYQg/iktIipiPYBb2g8K DuoKQh7o28bt+8Hn0ikShQFFfxotgWqFPQWskABXKj6T64WN8aC2kSCgbYPnsPi2PgTB W6QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version:dkim-signature; bh=keHNwQXyGxB+2fa9SqrEE3DvQ5TME2b5TMHAzSBP2pw=; fh=RvgzbgbFi8YE5twR3MXmN7BmvGsZiN0rPmDxTkhnCfM=; b=u/LhKjKrTCBVCfKKQdinDVAZbCL+itXMYMYt4ic11izpoGziLXn/dZmvOCsT0tkgF1 noL4CltXfFh743s2Ai6EoKWL7BlVi6gsIBvVY9hBw94yML/ER+aItjxrxH9UMEhv6Zrm hJQ+n0Cu77m9IlSZgk7hEmHQUv6AXzFgYExoH9pJY44uFgckJzvwe8NYyarf4rna81JU cKe4pb/zaYm6xuTW4py/LZEnJwBOegR73Oo8PdZyvDlmGqh80wyYlvexTq4ZmnNhxo+O X84gT8BPq6u0FS1dTVJ7if/J5YCIl2l3UM19W1DSpisJiUkh/F/lMIL9y7+vkFQYDqAG 3jrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=HAeGJ99i; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kj11-20020a17090306cb00b001a6f0eab385si9879590plb.55.2023.07.24.20.33.55; Mon, 24 Jul 2023 20:34:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=HAeGJ99i; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbjGYD1Y (ORCPT + 99 others); Mon, 24 Jul 2023 23:27:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229847AbjGYD1T (ORCPT ); Mon, 24 Jul 2023 23:27:19 -0400 X-Greylist: delayed 540 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 24 Jul 2023 20:27:16 PDT Received: from out-57.mta0.migadu.com (out-57.mta0.migadu.com [91.218.175.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18F261704 for ; Mon, 24 Jul 2023 20:27:16 -0700 (PDT) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690255094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=keHNwQXyGxB+2fa9SqrEE3DvQ5TME2b5TMHAzSBP2pw=; b=HAeGJ99i5xFhmj3CijzGTxYLYsS22+UCkxr4poXrv7YrVuJ+ys1PsTwIPg8xpWVSxn9zir H57AkKYqiD1vOZNVzVNI7GcU+WBHpxaXuuBnNpw5g5o1ZYYgFiQKUmRNmm30EbXVxytcjf W5muscH4uShV5wnAUhi90ZLbjVnLzlo= MIME-Version: 1.0 Subject: Re: [PATCH v2 02/47] mm: shrinker: remove redundant shrinker_rwsem in debugfs operations X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230724094354.90817-3-zhengqi.arch@bytedance.com> Date: Tue, 25 Jul 2023 11:17:24 +0800 Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , LKML , Linux Memory Management List , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <210C013C-AB14-45BC-AB2E-199FF7F5E523@linux.dev> References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-3-zhengqi.arch@bytedance.com> To: Qi Zheng X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org > On Jul 24, 2023, at 17:43, Qi Zheng wrote: > > The debugfs_remove_recursive() will wait for debugfs_file_put() to return, > so the shrinker will not be freed when doing debugfs operations (such as > shrinker_debugfs_count_show() and shrinker_debugfs_scan_write()), so there > is no need to hold shrinker_rwsem during debugfs operations. > > Signed-off-by: Qi Zheng Reviewed-by: Muchun Song Thanks.