Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] jbd2: Remove unused t_handle_lock
To:     Wang Jianjian <wangjianjian0@foxmail.com>,
        <linux-ext4@vger.kernel.org>
References: <tencent_CB3115278E9ED6BD081097E5753433452107@qq.com>
From:   Zhang Yi <yi.zhang@huawei.com>
Message-ID: <8138c559-325c-a4e3-1018-ca76ba185081@huawei.com>
Date:   Wed, 26 Jul 2023 19:19:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <tencent_CB3115278E9ED6BD081097E5753433452107@qq.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/7/24 22:58, Wang Jianjian wrote:
> Since commit 4f98186848('jbd2: refactor wait logic for transaction
> updates into a common function'), this lock has been no use.

Hi, I don't think the commit is correct, it should be
f7f497cb7024 ("jbd2: kill t_handle_lock transaction spinlock").

Thanks,
Yi.

> ---
>  include/linux/jbd2.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index d860499e15e4..8199235dbaf3 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -636,11 +636,6 @@ struct transaction_s
>  	 */
>  	struct list_head	t_inode_list;
>  
> -	/*
> -	 * Protects info related to handles
> -	 */
> -	spinlock_t		t_handle_lock;
> -
>  	/*
>  	 * Longest time some handle had to wait for running transaction
>  	 */
>