Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp231160rwb; Thu, 27 Jul 2023 11:50:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlEmzcLWI3G0i8+Jr/WBFHXToEa8KwsiUf++JHCciJi5fwouH1uaKo93kCC4fxBgxi1eyoMQ X-Received: by 2002:a17:907:a048:b0:99b:d784:f8f8 with SMTP id gz8-20020a170907a04800b0099bd784f8f8mr39469ejc.69.1690483819939; Thu, 27 Jul 2023 11:50:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690483819; cv=none; d=google.com; s=arc-20160816; b=yja2GRVPWh/HwwdkjnYjeMLJxyXZSy9AAecfW/jBAIzBQAcoiEopJKydDx2OSxzGpj ADe6A80Q+JIUtu/hk7SP9X3NQ50FT9fM79ot020vHam+lj9WAxvZDMgCUCI9LgmhgK5L vwSroSH0jYCiQNcoxA4Cyrl1h9KjHNYmTHSzxyoGXhoNvBwg4HLmNODqI01XpwR4lvRO AO+hx+F4hn22oPlT4MiqmPD/wL5nz4/L78XEl0wzDGWkO76LVMFFoh1j5iX5nMw8or0Q d+qVMn1ibXYDEp6CnlMZ2VwMD1L0t3uUE6/glvZgCNNU9tix9gsCIYduO/XNrdmQZ7OJ CUxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:organization:subject:cc:to:from:dkim-signature :dkim-signature; bh=F8/V8iHGHSv+JkjaulJJfd0u7+FldJFTn2B4741bG7s=; fh=sFluyqB/f4enjTdn6I7USaAEhJWEO0v5PsaQdMELXvU=; b=KZXP5/iH0sR3IZuXqb50MM4JNX3l+BZclnUIL3CuwOFaOMb8g7Z3vPKXNQ2ywjZRen KdoOtiRCKwdOZeQ5U05UIywZCyh9BWihm65OVgH2tQrbM6dmRZfG8R5+Oitzx87+X8bK bf/jrtaP2eGJYSljomRhpJI0lrcWORDrt6QFurPA535DnFLWKOMYH72D3sFtPyIKDW0y Lhyrc/FQExEZu29kMeBPyzWCzwuOgKcpKIN/B2RiUU3+TdJfTNoWdCJkYNCvXcWGg+1O mw/ThxZ6uWBGVccj/EmRHl7Xi8Dj8M3l/sZHomKYg97Q53hi2c/P24xdSiTytISTb+dV hRWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=pY7xJfdu; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a4-20020a1709065f8400b0099bc0489b51si1515249eju.28.2023.07.27.11.49.39; Thu, 27 Jul 2023 11:50:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=pY7xJfdu; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbjG0SkA (ORCPT + 99 others); Thu, 27 Jul 2023 14:40:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjG0Sj7 (ORCPT ); Thu, 27 Jul 2023 14:39:59 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDBE82D5D; Thu, 27 Jul 2023 11:39:58 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8394821A6C; Thu, 27 Jul 2023 18:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690483197; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F8/V8iHGHSv+JkjaulJJfd0u7+FldJFTn2B4741bG7s=; b=pY7xJfduW/6AevRW1gpBnw2+o/lalqgiGdpIpgb8a36fV0VPJQbFJpeKD/+iHajpAxFQoZ WxDrI+mh2W7AghNhOiiYqd00cY2hnkBeuUtKKh3EqFU4K2blkRL6eM/DJRuF30KmLelK8Z cAJ69xSHsw1KGSoZ/V3fdghqT55UXFI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690483197; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F8/V8iHGHSv+JkjaulJJfd0u7+FldJFTn2B4741bG7s=; b=ZLBm2/R+T5G/C7PnCLDJwK+SOfa4pb3gmcixk2m0cqwJVAMWXz9y7botWgDEYF2IHH2wph Qjor1waHfaUejSCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3D579138E5; Thu, 27 Jul 2023 18:39:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id N016Cf25wmTfCQAAMHmgww (envelope-from ); Thu, 27 Jul 2023 18:39:57 +0000 From: Gabriel Krisman Bertazi To: "Theodore Ts'o" Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, ebiggers@kernel.org, jaegeuk@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v4 0/7] Support negative dentries on case-insensitive ext4 and f2fs Organization: SUSE References: <20230727172843.20542-1-krisman@suse.de> <20230727181339.GH30264@mit.edu> Date: Thu, 27 Jul 2023 14:39:55 -0400 In-Reply-To: <20230727181339.GH30264@mit.edu> (Theodore Ts'o's message of "Thu, 27 Jul 2023 14:13:39 -0400") Message-ID: <87cz0d2o78.fsf@suse.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org "Theodore Ts'o" writes: > On Thu, Jul 27, 2023 at 01:28:36PM -0400, Gabriel Krisman Bertazi wrote: >> This is the v4 of the negative dentry support on case-insensitive >> directories. It doesn't have any functional changes from v1. It applies >> Eric's comments to bring the flags check closet together, improve the >> documentation and improve comments in the code. I also relooked at the >> locks to ensure the inode read lock is indeed enough in the lookup_slow >> path. > > Al, Christian, any thoughts or preferences for how we should handle > this patch series? I'm willing to take it through the ext4 tree, but > since it has vfs, ext4, and f2fs changes (and the bulk of the changes > are in the vfs), perhaps it should go through the vfs tree? > > Also, Christian, I notice one of the five VFS patches in the series > has your Reviewed-by tag, but not the others? Is that because you > haven't had a chance to make a final determination on those patches, > or you have outstanding comments still to be addressed? Hi Ted, Thanks for helping push it forward! I'm not sure if I missed Christian's tag in a previous iteration. I looked through my archive and didn't find it. Unless I'm mistaken, I don't think I have any r-b from him here yet. -- Gabriel Krisman Bertazi