Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp1380986rwb; Fri, 28 Jul 2023 08:37:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlFl+cwZyhFQkPH6+hoPpft4c2OVGWEkIxDcKu3Ql2ugDFQOBnZeCnPV0ag5m+St/WzIgSCG X-Received: by 2002:a05:6830:447:b0:6bc:88da:af44 with SMTP id d7-20020a056830044700b006bc88daaf44mr1627847otc.6.1690558620642; Fri, 28 Jul 2023 08:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690558620; cv=none; d=google.com; s=arc-20160816; b=uZaubd7TqM9i7+nwtXP+Ky8QRU187qztW8eEtpqNO9tut8nUhdgS5odquEEEoGlHFG rdLcviPDP4Bar7o38mty4cI9gWJtwzdBWNJSqroGnS1g3R91XEeYSrqIeu2+MLf8k58X 8kM3xjfWysrVYHqh/gaYgisGM4WzvoGpIl7hoP3toZ0BBeKsNJ9S41Twlg0oZRg8c0Rp TswRLvxzQIfq6cSj7u09JCmMX4GG1S4KdqxA+paRM6uRLTugWwhTy6eaBJbilG6I5w+t qHUfzlDeyu+yXiH7KaLcjztZXZyoy9OUGlFRnua7J0bwe5Kb44WsOr/NK4ElzQAZXU6R jwzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:organization:subject:cc:to:from:dkim-signature :dkim-signature; bh=sA4eJEf2xtyfEhJkx23SMukgQxsneaFm9EcZ0cTMKRI=; fh=NIwNXwX6brzxlQapCcJ1Hi9JlyjIGJYd1MeT8UEMi34=; b=uxhBzgo1CJa2L0ToXGDGs7XycWwuPWIGz+Q6FzOItzA5jSFALAvj8FTC9cikVaX0i8 L3ZrkkLY4owH8dLz3nSwOMMVimOJerHGju4HYqK0gY/KkFo4Gz50rxlG8J1XtVFQNKWZ Y9Hpchnnowont8GdGlhGwBRLE9m2qvSnGW5uAIFIE9uoDCiEzmuSI401O1cjclGWUjqe zn9OG8neihYZwVAsdyeelp7N92v66njimut9fPOI+hxVMWdY5b3GKdFTnZPX1ZHNMTmE riGDCp/c2KQrAdc3AnCjIWThwxYcK2pL8nbHV/Nuda9GhXenGW+IBWSeL32G7+l/BT3A CL4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=iQPTmO15; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=YCoC3Q3V; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a27-20020a63705b000000b005639fa704c3si3203289pgn.764.2023.07.28.08.36.44; Fri, 28 Jul 2023 08:37:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=iQPTmO15; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=YCoC3Q3V; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235015AbjG1PKM (ORCPT + 99 others); Fri, 28 Jul 2023 11:10:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236826AbjG1PKL (ORCPT ); Fri, 28 Jul 2023 11:10:11 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA33346B9; Fri, 28 Jul 2023 08:09:49 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C029921995; Fri, 28 Jul 2023 15:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690556987; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sA4eJEf2xtyfEhJkx23SMukgQxsneaFm9EcZ0cTMKRI=; b=iQPTmO15cm6iO2LUNlg3WXCC7CJjexQsl8DFdCm1Pc2irpbHp7oJdIOSqiLWCLzfxAdxqi vwTk1wdaXkGF2PZ6/HQfK3AujXJn/T96Fk38LlR1Ug0VaA9xLVCxhdmELjg+nGzR7VpmOL 5Ry7NJVS3JDlYbwcRtzZF8UxVQGDcTc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690556987; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sA4eJEf2xtyfEhJkx23SMukgQxsneaFm9EcZ0cTMKRI=; b=YCoC3Q3VNtgGzzPxNZnYCl5uUrm9iaukksnbNGYCyRsNl5bWUzElVwPvPg/ClmoVOJ7BhU frCH2Q6CRI73M6BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8B0F3133F7; Fri, 28 Jul 2023 15:09:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3qp1HDvaw2RWPAAAMHmgww (envelope-from ); Fri, 28 Jul 2023 15:09:47 +0000 From: Gabriel Krisman Bertazi To: Christian Brauner Cc: viro@zeniv.linux.org.uk, tytso@mit.edu, ebiggers@kernel.org, jaegeuk@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Gabriel Krisman Bertazi Subject: Re: [PATCH v4 3/7] libfs: Validate negative dentries in case-insensitive directories Organization: SUSE References: <20230727172843.20542-1-krisman@suse.de> <20230727172843.20542-4-krisman@suse.de> <20230728-beckenrand-wahrlich-62d6b0505d68@brauner> Date: Fri, 28 Jul 2023 11:09:46 -0400 In-Reply-To: <20230728-beckenrand-wahrlich-62d6b0505d68@brauner> (Christian Brauner's message of "Fri, 28 Jul 2023 15:06:30 +0200") Message-ID: <87r0os139h.fsf@suse.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Christian Brauner writes: > On Thu, Jul 27, 2023 at 01:28:39PM -0400, Gabriel Krisman Bertazi wrote: > > Wouldn't it make sense to get rid of all this indentation? I'm ok with making this change. I'll wait for more reviews and Eric before sending a new version with this done. Thanks! -- Gabriel Krisman Bertazi