Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 28 Jul 2023 21:34:22 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Gabriel Krisman Bertazi <krisman@suse.de>
Cc:     viro@zeniv.linux.org.uk, brauner@kernel.org, tytso@mit.edu,
        jaegeuk@kernel.org, linux-fsdevel@vger.kernel.org,
        linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
        Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [PATCH v4 2/7] fs: Add DCACHE_CASEFOLDED_NAME flag
Message-ID: <20230729043422.GC4171@sol.localdomain>
References: <20230727172843.20542-1-krisman@suse.de>
 <20230727172843.20542-3-krisman@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230727172843.20542-3-krisman@suse.de>
Precedence: bulk

On Thu, Jul 27, 2023 at 01:28:38PM -0400, Gabriel Krisman Bertazi wrote:
> From: Gabriel Krisman Bertazi <krisman@collabora.com>
> 
> This flag marks a negative or positive dentry as being created after a
> case-insensitive lookup operation.  It is useful to differentiate
> dentries this way to detect whether the negative dentry can be trusted
> during a case-insensitive lookup.
> 
> Reviewed-by: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> 
> ---
> Changes since v2:
>   -  Rename DCACHE_CASEFOLD_LOOKUP -> DCACHE_CASEFOLDED_NAME (Eric)
> ---
>  fs/dcache.c            | 8 ++++++++
>  include/linux/dcache.h | 8 ++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/fs/dcache.c b/fs/dcache.c
> index 98521862e58a..5791489b589f 100644
> --- a/fs/dcache.c
> +++ b/fs/dcache.c
> @@ -1958,6 +1958,14 @@ void d_set_fallthru(struct dentry *dentry)
>  }
>  EXPORT_SYMBOL(d_set_fallthru);
>  
> +void d_set_casefold_lookup(struct dentry *dentry)
> +{
> +	spin_lock(&dentry->d_lock);
> +	dentry->d_flags |= DCACHE_CASEFOLDED_NAME;
> +	spin_unlock(&dentry->d_lock);
> +}
> +EXPORT_SYMBOL(d_set_casefold_lookup);

d_set_casefolded_name()

> +static inline bool d_is_casefold_lookup(const struct dentry *dentry)
> +{
> +	return dentry->d_flags & DCACHE_CASEFOLDED_NAME;
> +}

d_is_casefolded_name().  Or even better, just write 'dentry->d_flags &
DCACHE_CASEFOLDED_NAME' directly in the one place that actually needs this?

- Eric