Received: by 2002:a05:6358:c692:b0:131:369:b2a3 with SMTP id fe18csp5934413rwb; Tue, 1 Aug 2023 09:50:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlFClixupSJoBMaiBmvl/mJ8am2qiYDUHhmpuRHdz4mqdYPgwYsvu8Vy8DOzuauOqvv/9c3q X-Received: by 2002:a05:6a21:498e:b0:12f:dc60:2b9e with SMTP id ax14-20020a056a21498e00b0012fdc602b9emr12753636pzc.48.1690908659177; Tue, 01 Aug 2023 09:50:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690908659; cv=none; d=google.com; s=arc-20160816; b=O7Jv0tNt2d8MuqD6FMq1xmBSuhrZoaTMl3VugCAqukZoNZR82aA0JFkAGVrVH4VybW AUnO+4EFAxgcO6JdQnAiB0qn+SAKiyRMLLOHZMdfLTCyqRFhpA0Pke2EQeuiyZ2WykKB 9JSjFHrNKH3KlrIbeK+Wtej+lxGp3lJgFS/zCYF65Hx/TOyDH1h2Xb3uFPd/D0Ls3DLG 1AFu+4arbFRVIMNAyyzsb3NapQfkw1gtSlll6LdIG6VzOzM1A0TWFJdYFyREHKpgYfQG cRHHQO5FqRBPKqx8qEWWKb3G5lg1dS+EgagQ0/KTWBNYGyFi8t1em4jT60F/SlYo4Uie BMDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=9bO4EMps/8stuDZiI8Gpdidb8h9+MIAhmvaNg3KYj1s=; fh=SXdXRdMuMPvq/NPem2k05NBAUSTSv33iwuo2SCYwe78=; b=U6hHyOPZm9jRKOwvnYSRNGjzqE6HsnYNA7lG6DekjKMTIO8Yroaq0xIVCdG/b12C8p 8yjbQ4JxM8QC7CYWYenGqOXbeFey6Nls5cmkR0C1JQEEzMZw9WSSnq8Ra1dc8BoHUpRS M0kFD7P0sR9TQFmwgfg349uM5E2R5q13ywD/ViKt+GsSdAL6MOFcxphEEAsTA8KYpqlB Euf8wDDvDIX/oTWJmPwH5WIxSW35x8pDCrCf37If5/AI0SMPiWv+9NJBK+95NJcgyML7 fSwJmQHTZ74ZKoslReJfmBjIepq6V7QLoj5klXTqFXIqYZ5VdM3hVnAMeYQEznn6A19p uRcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=o4UnwJgp; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ea24-20020a056a004c1800b006872f156f0dsi4330847pfb.89.2023.08.01.09.50.31; Tue, 01 Aug 2023 09:50:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=o4UnwJgp; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbjHAQTL (ORCPT + 99 others); Tue, 1 Aug 2023 12:19:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229641AbjHAQTK (ORCPT ); Tue, 1 Aug 2023 12:19:10 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43DE21BD3 for ; Tue, 1 Aug 2023 09:19:07 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-63d170a649eso38275366d6.3 for ; Tue, 01 Aug 2023 09:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690906746; x=1691511546; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9bO4EMps/8stuDZiI8Gpdidb8h9+MIAhmvaNg3KYj1s=; b=o4UnwJgpk8yeTzZUK1FZTs65eYsnacdGTDhjwzMy+DqQRhE2jTupyokcvRFqP1MKuo qAu+yNtKzWXdHC5YGT3qGXgvBJ0yvodc24S05t5lVNoUZlrjld+c3ZYg84ALagFSl5E1 0e1IPmRVyqT2GVIRYdARMkHo0CkuvhYNhdAmnof9UiM53aClnQ1FS5ZSzeTK2gVSd53B 063XdvfBsZ51WyTLXABYzSrXYL1XyijHBazCJn4+IrTGw38FuZoFnqi2U6TZNyoEfv5r ytN07iG/2nB0AbEtc586oI3xWMZoIT8TzfHqCOMBm0ZBpqNjIRXHSeGMlbbE1pfY9N/D MP5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690906746; x=1691511546; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9bO4EMps/8stuDZiI8Gpdidb8h9+MIAhmvaNg3KYj1s=; b=k5ThTQNZigc+SwjpHLVxwLRcVyPLTzdtMZEX7HFItkosBrGVwcBF6FZd6RfEJV25W/ U4qeN0xzIgNsWkIBv7hkhfQb+BftDPOsBYj/FPA5MxQcHkZDO7GTXs1RJ7XAW+kkZ3aT o9I0sqNsc8fZyIotGv8VoBIlZXRPp/ZnJfg4lsz1JMw5TZKTUuIhe0k2gFGc0p37Ind6 /wg/lr/ZGKVaoh82qtjUjNZ0aOvNA2inxnBgm87y9xf38FcEsBYlcIPalAKe4qtZVLgt HA8UwgNU6Hlt9H6vcHLZCM1uhZxPkWAOV1UtI8Q5SVG/Ze005JhuqeC8rTZnGQrv6q2f IaFA== X-Gm-Message-State: ABy/qLadPyTfzjYVn+xrk+/+IB0WF8ZpaT39ZRWkCNrcLZ2eM59hX1/w bhhFmC6YBj1V18zUsu0CXsUGIyl6igBvY2DcuzrF6A== X-Received: by 2002:ad4:5847:0:b0:635:fa7b:6c22 with SMTP id de7-20020ad45847000000b00635fa7b6c22mr10424824qvb.55.1690906745972; Tue, 01 Aug 2023 09:19:05 -0700 (PDT) MIME-Version: 1.0 References: <20230725043310.1227621-1-suhui@nfschina.com> In-Reply-To: <20230725043310.1227621-1-suhui@nfschina.com> From: Nick Desaulniers Date: Tue, 1 Aug 2023 09:18:55 -0700 Message-ID: Subject: Re: [PATCH v2] ext4: mballoc: avoid garbage value from err To: Su Hui Cc: tytso@mit.edu, adilger.kernel@dilger.ca, nathan@kernel.org, trix@redhat.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jul 24, 2023 at 9:34=E2=80=AFPM Su Hui wrote: > > clang's static analysis warning: fs/ext4/mballoc.c > line 4178, column 6, Branch condition evaluates to a garbage value. > > err is uninitialized and will be judged when 'len <=3D 0' or > it first enters the loop while the condition "!ext4_sb_block_valid()" > is true. Although this can't make problems now, it's better to > correct it. > > Signed-off-by: Su Hui Thanks for the patch! Reviewed-by: Nick Desaulniers > --- > v2: > - modify commit message > > fs/ext4/mballoc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 21b903fe546e..769000c970b0 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -4084,7 +4084,7 @@ void ext4_mb_mark_bb(struct super_block *sb, ext4_f= sblk_t block, > struct ext4_sb_info *sbi =3D EXT4_SB(sb); > ext4_group_t group; > ext4_grpblk_t blkoff; > - int i, err; > + int i, err =3D 0; > int already; > unsigned int clen, clen_changed, thisgrp_len; > > -- > 2.30.2 > --=20 Thanks, ~Nick Desaulniers