Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp2348356rwo; Thu, 3 Aug 2023 08:11:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlFdLW4k2DJP0tMdtHix7ozQcYEPtEz0j4IFHUQWJvFUaFTSgIdbv/ruvguLUheJUsmGy7M+ X-Received: by 2002:a05:6a00:174a:b0:66c:6766:7373 with SMTP id j10-20020a056a00174a00b0066c67667373mr22264954pfc.23.1691075469493; Thu, 03 Aug 2023 08:11:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691075469; cv=none; d=google.com; s=arc-20160816; b=yLH/SMem4bJZkbxBbJY+HZY65ysw1AMHQlFMKb99dcpjiXmFjf/3gnF7o4g10slmfO 0saRh9QoUkQe8U0VZiEQIt9PEyEtPNrxF0zkwMzQHdX0ptaCCA8eqy6yaNaC49GrCqsu cHKXFZ9ldsxPcdjPVT/x3Gls54tQfc/upWK22Z0DIhblBhkl9xOyEgd0xV3JQRnXJlFa JpmKdOaMiGZfqd55mgLCjaoEWzm9DQ0AdS2L5m6g/nWuK61XpDumlCEc3exijxnjRkQs XyTF2Uqi7uSOv3YurgmRm/xfB1iDPjao11eQzht4+kakAAEflCeCiUNk5mutVxuUhNUS tbbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XK7KMm3UiyXrs0/XRn2UB9Xi80A1mq2T3nlAar3pszY=; fh=mKemRkvkcm3qLPfYxOeS2doC06g/02MVjD7+pp09xH4=; b=QK+0YgjnFC3wQfZjXG2bMeg0XG+FCt7PNgbwm3iK/aRG9Dbw1MgURHPx+avg/39ndV rXZ5Ey6Tx+mo6Puh70fIYHOAyDENbFwSq4HCIr99ptfJxA1v9ubHPNrmt1FdpXKJ+j3B OyX3xPddw2YEgtSzTuar57vT/Sbjhok6BLEheIPdwFPhFnwfsuki1CZlzFnw+HM4mZL/ HSwc238D1/vVUiAVuT3HQY5c/dQamCXLrPit8888MbqM6r27uCzZNv09foMYsnAZsZza R4Y/kDdbHW3fMC8eL6VUKUbRs4si06vdCch6xbbNHqp06UM4Zy5qLd3OoBcoKsZB/jzh PaQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=YN3g4rzI; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o9-20020a63fb09000000b005644828f3dcsi10747pgh.164.2023.08.03.08.10.28; Thu, 03 Aug 2023 08:11:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=YN3g4rzI; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236813AbjHCOjN (ORCPT + 99 others); Thu, 3 Aug 2023 10:39:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236797AbjHCOi5 (ORCPT ); Thu, 3 Aug 2023 10:38:57 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D19001FF3 for ; Thu, 3 Aug 2023 07:37:41 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-112-100.bstnma.fios.verizon.net [173.48.112.100]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 373Eb59h009287 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 3 Aug 2023 10:37:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1691073428; bh=XK7KMm3UiyXrs0/XRn2UB9Xi80A1mq2T3nlAar3pszY=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type; b=YN3g4rzIkFY5xEBieAiV3LMInWpGF3gonVt4WhUtyy/7yJSpydF6AGG6RKJrVfLkQ XUTdZrR4VadG999S8sSkKebeatlZtA0/YrZL4x9PvQQKcw1kiHem0LEo2w7Vsxyroo DR9pDIJDNFRyUiGkMA5Wrv0fvdK+qTlVfqyAM8M7BCOtdgnvDS10pltpakr/s8DvfB Obr8wSx0xGu/ZzAVVA4lFgi1kcRr+PAd4GHtKBIHgY77+Y6EwtjC7HdfM2RcNrcViY dFh6WffL0ZW7BZsMdrytvhYFHpWDB2JEQVjh6kRbtfRl2r+bv7UHXDXnUoMzwJLR7i Itid2w5TMiAzg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id B040A15C04F3; Thu, 3 Aug 2023 10:37:05 -0400 (EDT) From: "Theodore Ts'o" To: Jan Kara , Guoqing Cai Cc: "Theodore Ts'o" , HUST OS Kernel Contribution , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fs: jbd2: fix an incorrect warn log Date: Thu, 3 Aug 2023 10:37:03 -0400 Message-Id: <169107341682.1086009.6038933080699741994.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230413095740.2222066-1-u202112087@hust.edu.cn> References: <20230413095740.2222066-1-u202112087@hust.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, 13 Apr 2023 17:57:39 +0800, Guoqing Cai wrote: > In jbd2_journal_load(), when journal_reset fails, it prints an incorrect > warn log. > > Fix this by changing the goto statement to return statement. > > Also, return actual error code from jbd2_journal_recover() and journal_reset(). > > [...] Applied, thanks! [1/1] fs: jbd2: fix an incorrect warn log commit: 1d40165047456923fa4343d519353d9440cd68df Best regards, -- Theodore Ts'o