Received: by 2002:a05:6358:700f:b0:131:369:b2a3 with SMTP id 15csp2594555rwo; Thu, 3 Aug 2023 11:43:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlGOxiy2Zyl1DEClWPnkzDHQZ9bdwdnCwXTrGwH7Ub9NliMZoF+LscR39Jw22MRhmK5q0C0c X-Received: by 2002:a19:2d1e:0:b0:4f9:5519:78b8 with SMTP id k30-20020a192d1e000000b004f9551978b8mr6788130lfj.63.1691088192288; Thu, 03 Aug 2023 11:43:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691088192; cv=none; d=google.com; s=arc-20160816; b=bv6pEyY/BHbAWS46joNFUGW6YkTsI5C8V3bRK4QOz3GFidLBAdoiUwrtgAHtHFfiod nWkoG2jDUeCN8ZN7nhZWF938V2f+hEpJttaLeDDQ4Cqa0JoHOujOTVdKNz+YuWWEew3c NG2U8EkrUFw23cRIPq8HquVnkT9o4Gn3++0q43KV4jSfd+2LUiLFIf/jR8gGF4Pbvqa3 v6wSJlme1r6GxOiPZh5Bbxk8Gh69Q3Z2bnAbpycQW2v/0Uz49RGmBxy4FHyd9+g2h56K Szqd7nbbpAi7BFskzTVMthjN8/+T8rV93KTFcR0tsc2YlTGhQxZocKC1qSw+nosEgzmJ qFoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q7SObbTF1yfGSH6tv6wtRCFB84lk2kXVjxLa8BAfcQg=; fh=TSIUzfHoMbtlq9AZT2KN2c7+//wIJMQ4+yn9Y1L5788=; b=BN5f2lYI67We3YjympNX4rQVc6YPt+gKIy6kY7/CGqnIaKlKSXL5BAPXFTpjfybKsx gGBn/lyz3yIBIznpLhyxxFb973/77gawKzHbrWNG2L0bKLzVNoupbEwBTfud62cn03nX 73UTu9KPbtSQaEsFltPNVcJAA9NL5t7dWQ3XedJPAMT4yuMZFT5KpvXF+Jn6MUPcyb4g aVtGeKBUYJAsinbrnR6LrIzVl+HkyjKj0lux8sdajTVGR6FAAfHK8KXmnip/tUdk8kfL /ptBUPJ8hctiH56G34uBjtw5CnVIdEMPVKdpka0T5Hd0HFxZAcyiDeW/THFvscDzKOY7 KSpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MfiQ2gN2; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o13-20020a170906860d00b00992d753205csi234520ejx.658.2023.08.03.11.42.45; Thu, 03 Aug 2023 11:43:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MfiQ2gN2; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231372AbjHCSK7 (ORCPT + 99 others); Thu, 3 Aug 2023 14:10:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231432AbjHCSKq (ORCPT ); Thu, 3 Aug 2023 14:10:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29D3C1704; Thu, 3 Aug 2023 11:10:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 740A561E67; Thu, 3 Aug 2023 18:10:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 888DDC433C9; Thu, 3 Aug 2023 18:10:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691086237; bh=l09B4wLLhFie262qfmXA0CveYXOk2JvcJhfIRHAAK4o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MfiQ2gN2z2YzxyG/O3d7GtOXWQ2m6fL49xtZB4NWZWBeLVPdsc4kAabQ8itROH1It 21T7P0djO9aOpJ5WwnCRkrrEtUHf3uKDbJ1mew383Lt/fdb86kisMz4kq2oDhmj+Cm qurmwE1LM1WqgSAR9efG5Fq8Jmbkdlj14b21Xuzk8HjcYIDPRI7lsMh0d3Vha5yCln hqeMFKrHRptRejegCyC4bSWm4MvvIMFg9H5P/Pc9QiSz1UCps/9lt5Vhh/F+Sfy4Tb Nq31kTyt7Nxxjms3i402ilz2UjoNv7r6S2nPEZ6K3nTsNAyvejcB145/0RXS80IINs Cqrwcv6sNoi5A== Date: Thu, 3 Aug 2023 20:10:25 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Al Viro , Jan Kara , Chris Mason , Josef Bacik , David Sterba , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Chao Yu , Ryusuke Konishi , "Darrick J. Wong" , Jens Axboe , linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust Message-ID: <20230803-zecken-oberhalb-e30c55d66648@brauner> References: <20230802154131.2221419-1-hch@lst.de> <20230802154131.2221419-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230802154131.2221419-6-hch@lst.de> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Aug 02, 2023 at 05:41:24PM +0200, Christoph Hellwig wrote: > Check for sb->s_type which is the right place to look at the file system > type, not the holder, which is just an implementation detail in the VFS > helpers. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Reviewed-by: Christian Brauner