Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp355790rwb; Fri, 4 Aug 2023 14:01:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaBqUP6Vji3gwCgEqk6dsyjtEZrKyU3JqbdS4H5xtYOJ30JkbXcUzYp3BA1EplKVS2cUtk X-Received: by 2002:a05:6a20:6a1c:b0:13e:1712:4c01 with SMTP id p28-20020a056a206a1c00b0013e17124c01mr3268932pzk.42.1691182881304; Fri, 04 Aug 2023 14:01:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691182881; cv=none; d=google.com; s=arc-20160816; b=t8gz9hip3d8+NxFOuMMx4h0l9/QPDpDIdfNu6bWqYnGX8QUGrZpZQ+HxtXyH1yuYkZ 27Mi6oToJv1lPRYOsNW90xspk8IxJaqY8I56/vAZoJPBqg4uS8loJyeL+J2XmrsAqI64 avILc9TD9mc9iLdXKC7L+S8AN+yHxH+FnMXPba0oYqoS4X9VeSMwkqwWFMMy0AV9BjLo TdZNFYNfNNU930Hmkw61OM3CE9s6UzORch23XhjQVRipLxZ5yicRh6Y9ieRkYU47psqN YZaLZ0LhB6t+P8WIBaX3g2iS56vkNvHVwJzNOusUUdbalL8F2SUcPIP9FeFC5nR0X6uC H77w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=i+Cv8ZO3I5bUEr/K4+xoZ/gjA4JFPErOdbDf0LaFzCo=; fh=tbfguDJjNiBBIP8rxz454WFFRMiSKLzD/jT1+a3JOUA=; b=TvWYD1VxjmCzl86kAvlQ1dbglKNr/GAMpTPTd9Yf1Emsed72Ck4JyOWBXLrLvBHcK2 G079m2rLFdmnDZXJ9V3GQaXS0deq2DwUgJvyacsbcwLGCqkkaJkwGS9IZ9nNTTsmeQ66 PsBAugNCncvnDDLDCos+YBs37bJ3RJ7nYsxhMXxiLxhPyA70fPmdXKLgxpgD82Vm/JOy laFzZ7aGoIOE2KecFhKSNoiYsgWp1shSER8tUH2yJc6moC/FcFU7EcFap/vdtu3lFxi5 gNu6d8jU4mJX7XioNpAyNV6060lhk2Ngmk5K8TF3uclUMHHCAPibOFDAZxb057GmCXch wj5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=LhpVy8vB; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n189-20020a6327c6000000b00563522a7b7asi2366797pgn.14.2023.08.04.14.00.19; Fri, 04 Aug 2023 14:01:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=LhpVy8vB; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229967AbjHDUfM (ORCPT + 99 others); Fri, 4 Aug 2023 16:35:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbjHDUfK (ORCPT ); Fri, 4 Aug 2023 16:35:10 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C8694C28 for ; Fri, 4 Aug 2023 13:35:10 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-112-100.bstnma.fios.verizon.net [173.48.112.100]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 374KYOoW025102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 4 Aug 2023 16:34:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1691181272; bh=i+Cv8ZO3I5bUEr/K4+xoZ/gjA4JFPErOdbDf0LaFzCo=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=LhpVy8vBk/XSt8GuwK8JeXWAhbhaGHwiCvogm7byiRopRon8u+Fy2XpuWbDJ/DJqp 1MMHjMZrvP/bsYQt+4oPnfh3oX7+RXyu/JpuSynvYo8OM1HCFI//PZ6OtV7t48eW1k NczmO7BbNuqBpq+Z1Q/3jmfHsAXJRjU74h7ISZ3IYJA5kgGBxhqB59mAzguEkGCU4Q Bwd2anIeqw6Ugk0Z9GGvE76JN2snxvF4uJsmny2lVz8LKkRpZ1vWGxJrBJy7Lvy0+7 VCsPzXGzk5tcsNFAq0U09qFE0XG9yw9L2KHuZ/yc1old2bUvgfhBiWegJLllkThH6J DmzoegwwJSRQg== Received: by cwcc.thunk.org (Postfix, from userid 15806) id D311615C04F1; Fri, 4 Aug 2023 16:34:23 -0400 (EDT) Date: Fri, 4 Aug 2023 16:34:23 -0400 From: "Theodore Ts'o" To: Christoph Hellwig Cc: Al Viro , Christian Brauner , Jan Kara , Chris Mason , Josef Bacik , David Sterba , Andreas Dilger , Jaegeuk Kim , Chao Yu , Ryusuke Konishi , "Darrick J. Wong" , Jens Axboe , linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 05/12] ext4: make the IS_EXT2_SB/IS_EXT3_SB checks more robust Message-ID: <20230804203423.GC903325@mit.edu> References: <20230802154131.2221419-1-hch@lst.de> <20230802154131.2221419-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802154131.2221419-6-hch@lst.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Aug 02, 2023 at 05:41:24PM +0200, Christoph Hellwig wrote: > Check for sb->s_type which is the right place to look at the file system > type, not the holder, which is just an implementation detail in the VFS > helpers. > > Signed-off-by: Christoph Hellwig Acked-by: Theodore Ts'o