Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp891333rwb; Sat, 5 Aug 2023 03:20:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRyf9UYSBKAPIom41rgI1vVZyIig+K0h8GMq3TO7GAQf+iq+SgIAY/QURTmOPLTghzK6kt X-Received: by 2002:a54:470f:0:b0:3a7:44da:d5e4 with SMTP id k15-20020a54470f000000b003a744dad5e4mr5118886oik.51.1691230824042; Sat, 05 Aug 2023 03:20:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691230824; cv=none; d=google.com; s=arc-20160816; b=blqE9liUhUqCZIFrYoJ49fNcDTf5cx9BfVztVoS3t55SiDE0LoqP92lOOez1cauRcT xRbtTNn5GHdQn88M2hw/jrlRlMHz7PrS4XS4edmbY0N3U+JSJSt0RA2ATIllLvYSOQLY t+67CVEkeorChyjatb5q4uNJh2ErDkcmErqLvs/kShYnWlaGHnuqMGrnExYkV0p7b000 RX7iyrQlPxxX0rkJb/7ol/qplL7WIrhE6guhVcIf1aanMF8GcWMn9xLCrQzGHCCp7Zsm 98A2ZkLdH2vnQ/juhhuF36L84U1bpvJBW9/EFulCpiuUh5xWw5hFejR7zW5uq4TPMoqy ndEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=zX+yAwxxXXeDB9MLA4OJTL2/Dp/CPy6h0+KrCbKhYSQ=; fh=rrHjsbeIRRdqSoieHnaPPCFKbGdCtcZhs5bVnCQzxEE=; b=PQVN/PjyAgV1ZAPDgRxU2SiZAqi8kY4b0QERKsUTrVE6UCk0UBrPxV8JBRvOGJF9xI SqtSV8zmDzTkdJXBRE/KeYorP2Yo4eC/C8e8MTrjCf0uGNy5qaaC2ZkDBycHs2GycSsf wiaLPGlDwIapdmU5z3jHO2BE22DD2yMuD8pB8BsznuQjaFWVpLHCMkOP3N0MW4FzMEey SmWLjoTnbtwqKuWdlZGtvcwLuWqDDc4apnFUh83ZP6/Ag62hV8RGCjfLgowrQ0r+7TGT XhpZ/ZM7ebfxhKiEbOnJ1RPlfBbfkkLaBNKbvZfQGjmrxwwrE2GUFjINEm2kv1MOxqPs ypcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s10-20020a65690a000000b0056457fb5761si3139503pgq.586.2023.08.05.03.19.49; Sat, 05 Aug 2023 03:20:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229825AbjHEIgX (ORCPT + 99 others); Sat, 5 Aug 2023 04:36:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjHEIgW (ORCPT ); Sat, 5 Aug 2023 04:36:22 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D56803A9B; Sat, 5 Aug 2023 01:36:21 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 981B468AA6; Sat, 5 Aug 2023 10:36:17 +0200 (CEST) Date: Sat, 5 Aug 2023 10:36:17 +0200 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Al Viro , Christian Brauner , Chris Mason , Josef Bacik , David Sterba , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Chao Yu , Ryusuke Konishi , "Darrick J. Wong" , Jens Axboe , linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH 06/12] fs: use the super_block as holder when mounting file systems Message-ID: <20230805083617.GB29780@lst.de> References: <20230802154131.2221419-1-hch@lst.de> <20230802154131.2221419-7-hch@lst.de> <20230803115131.w6hbhjvvkqnv4qbq@quack3> <20230803133330.dstks7aogjogqdd5@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230803133330.dstks7aogjogqdd5@quack3> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Aug 03, 2023 at 03:33:30PM +0200, Jan Kara wrote: > As a side note, after this patch we can also remove bdev->bd_super and > transition the two real users (mark_buffer_write_io_error() and two places > in ocfs2) to use bd_holder. Ext4 also uses bd_super but there it is really > pointless as we have the superblock directly available in that function > anyway. I actually have a series to kill bd_super, but it uses b_assoc_map as the replacement, as nothing in buffer.c should poke into the holder and the buffer_head codes uses b_assoc_map a lot anyway. Let me rebase it and send it out.