Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     linux-ext4@vger.kernel.org,
        "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Cc:     "Theodore Ts'o" <tytso@mit.edu>,
        Ojaswin Mujoo <ojaswin@linux.ibm.com>,
        Eric Whitney <enwlinux@gmail.com>
Subject: Re: [PATCH] ext4: Don't use CR_BEST_AVAIL_LEN for non-regular files
Date:   Sat,  5 Aug 2023 08:20:25 -0400
Message-Id: <169123801882.1434487.3791634089100240584.b4-ty@mit.edu>
In-Reply-To: <2a694c748ff8b8c4b416995a24f06f07b55047a8.1689516047.git.ritesh.list@gmail.com>
References: <2a694c748ff8b8c4b416995a24f06f07b55047a8.1689516047.git.ritesh.list@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On Sun, 16 Jul 2023 19:33:34 +0530, Ritesh Harjani (IBM) wrote:
> Using CR_BEST_AVAIL_LEN only make sense for regular files, as for
> non-regular files we never normalize the allocation request length i.e.
> goal len is same as original length (ac_g_ex.fe_len == ac_o_ex.fe_len).
> 
> Hence there is no scope of trimming the goal length to make it
> satisfy original request len. Thus this patch avoids using
> CR_BEST_AVAIL_LEN criteria for non-regular files request.
> 
> [...]

Applied, thanks!

[1/1] ext4: Don't use CR_BEST_AVAIL_LEN for non-regular files
      commit: 772c9f691dcf3a487f29ddb90a5a15c78d7328e1

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>