Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp1034316rwb; Sat, 5 Aug 2023 06:10:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHjAAkTqosKXg6jNy1EMoPsHawuYdjwVRvcflbov34vPpC6m8XEu4SIF42u99kFtiXJb3zY X-Received: by 2002:a17:902:6944:b0:1bb:9f04:d899 with SMTP id k4-20020a170902694400b001bb9f04d899mr3147199plt.8.1691241042873; Sat, 05 Aug 2023 06:10:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691241042; cv=none; d=google.com; s=arc-20160816; b=tg6gC3r491facaC9jY0l5fWBmHmwL0vo8XU5bi0hykp2HGjrGyhVROTip6toUiWc5k cBhAObhZSVZWUbmDdOrrGWHUyRpwqJw2hYD68Uule+OgrwXKTxskc+3XhotgnKqesOvH kfuGi2YJMUfIR5Z2X/BfKd36HBmvI28hxMagrn0wsINk3dne9W2mXq2+TK3bB2ZMEah5 C5V9dmQp0DLyJhwifSGIWvBz+dCn8R0kSXjISBMszh8q4fVzwE5XUpjjhdo2pV1hlzBX NOjYwLx7U46XcQbYona7hZJaxoOcovl9tjjyBllsR5j9nQ4i5NAGDOamAycr6vFMK6Qj SmhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1bGXm8gvH4V2sfyFgzqDNNlK6DqK9uVlqmWS8762+14=; fh=nLCSwaOClHC6LdADfnjxeJcYNONq/9AwC+rBuiQCZcI=; b=Fwb7vLwYqjm6jNju4NJbbcLPgm3W/Fze4N7pcgl5GxiOW5PzI/3TIYOuxnSJJjhAYy 1U6v63qyPhmRgq1pBdQ7cwuBuCO77NBTLbvhaaSuYwv1/qzv9rHLrabf3fE3xoX9G7XS JmsYzuXnnrRJI92XY7v9Bd+SNeNnKQcdp1GS9oZC5d8uqPOc7H4amGjSODymIMZBNRId Oq/zolU8uAntepS4aszu8fk3YSYry0xGfpSEusFf45aZc5pX1hqjWQyix4TiPFbfdCkC x8MdZriV6PYkrwT8o/tKDMzkzbLl204qw5P6OVp/dSLhZwavH0QF9K2lAXFY7IJWwwiX MXQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=PdPj1eY3; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p15-20020a170902e74f00b001bc552f1443si1563514plf.423.2023.08.05.06.10.28; Sat, 05 Aug 2023 06:10:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=PdPj1eY3; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229877AbjHEMV0 (ORCPT + 99 others); Sat, 5 Aug 2023 08:21:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbjHEMVZ (ORCPT ); Sat, 5 Aug 2023 08:21:25 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45AB94684 for ; Sat, 5 Aug 2023 05:21:23 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-112-100.bstnma.fios.verizon.net [173.48.112.100]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 375CKVdD027550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 5 Aug 2023 08:20:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1691238034; bh=1bGXm8gvH4V2sfyFgzqDNNlK6DqK9uVlqmWS8762+14=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type; b=PdPj1eY358x/1E/0HsJMV2YBcKqozc1wPOY1JoZtJIdxgeduTGeC0hLfvqhnY7s2M fWzFieJq0rlXGKV/t/+03bVPU4zviP5+78cfQMNxhbWNLWTWAlzorrSLCj85hbI0i6 oi111GDUhNOcAMp3uCPLQbTCh3AfKikO3/DkYluaweO9eoeMSpx+bsXDp/pRqcb495 aMNcoUPIa6pUt9mallbTjkAa+WWuo6xGERxXNvM2hPeo4Nf6ux7atwWuTOhzGsYgQz X4+tp9bYA+to+jxZeeuvqo/W8idoNl2Obq9+dLW37Y46MCEWUCSsMkmWBA4KDw56FD H/vzZa4StiTWw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 5938215C04F5; Sat, 5 Aug 2023 08:20:31 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, Zhang Yi Cc: "Theodore Ts'o" , adilger.kernel@dilger.ca, jack@suse.cz, yi.zhang@huawei.com, chengzhihao1@huawei.com, yang.lee@linux.alibaba.com, yukuai3@huawei.com Subject: Re: [PATCH 0/3] jbd2: some fixes and cleanup about "jbd2: fix several checkpoint inconsistent issues" Date: Sat, 5 Aug 2023 08:20:28 -0400 Message-Id: <169123801880.1434487.18031026925968851100.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230714025528.564988-1-yi.zhang@huaweicloud.com> References: <20230714025528.564988-1-yi.zhang@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, 14 Jul 2023 10:55:25 +0800, Zhang Yi wrote: > These patch set includes 2 fixes and 1 cleanup about "jbd2: fix several > checkpoint inconsistent issues" patch set[1] recently applied in dev > branch. The first patch fix a performance regression introduced while > merging journal_shrink_one_cp_list(). The second one add a missing > check before dropping checkpoint buffer that could lead to filesystem > inconsistent. The last patch which is from Yang Li, remove the unused > __cp_buffer_busy() helper. Please see the corresponding patch for > details. > > [...] Applied, thanks! [1/3] jbd2: fix checkpoint cleanup performance regression commit: 373ac521799d9e97061515aca6ec6621789036bb [2/3] jbd2: Check 'jh->b_transaction' before remove it from checkpoint commit: 590a809ff743e7bd890ba5fb36bc38e20a36de53 [3/3] jbd2: remove unused function '__cp_buffer_busy' commit: 5f02a30eac5cc1c081cbdb42d19fd0ded00b0618 Best regards, -- Theodore Ts'o