Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Andreas Dilger <adilger.kernel@dilger.ca>,
        Daniel Rosenberg <drosen@google.com>,
        Eric Biggers <ebiggers@kernel.org>,
        =?UTF-8?q?Lu=C3=ADs=20Henriques?= <lhenriques@suse.de>
Cc:     "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ext4: fix memory leaks in ext4_fname_{setup_filename,prepare_lookup}
Date:   Sat,  5 Aug 2023 08:20:24 -0400
Message-Id: <169123801881.1434487.6868481309254151521.b4-ty@mit.edu>
In-Reply-To: <20230803091713.13239-1-lhenriques@suse.de>
References: <20230803091713.13239-1-lhenriques@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On Thu, 03 Aug 2023 10:17:13 +0100, Luís Henriques wrote:
> If the filename casefolding fails, we'll be leaking memory from the
> fscrypt_name struct, namely from the 'crypto_buf.name' member.
> 
> Make sure we free it in the error path on both ext4_fname_setup_filename()
> and ext4_fname_prepare_lookup() functions.
> 
> 
> [...]

Applied, thanks!

[1/1] ext4: fix memory leaks in ext4_fname_{setup_filename,prepare_lookup}
      commit: 7ca4b085f430f3774c3838b3da569ceccd6a0177

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>