Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp1587291rwb; Sat, 5 Aug 2023 20:27:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGlmC2QCfjjM3qrjkAmpJGo/Tu+fl0ePY9+bPvM8FIJt0MsN/q2vS9VGKIzxNYT4pfDO5f X-Received: by 2002:a17:90a:1681:b0:267:fe84:6647 with SMTP id o1-20020a17090a168100b00267fe846647mr4063158pja.13.1691292456845; Sat, 05 Aug 2023 20:27:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691292456; cv=none; d=google.com; s=arc-20160816; b=AClckNl1YWnqRD4daa7WklpDGtykRH/yYLzMirUiFnt2Q5q+DVCeBvTNSGjn9L2Z9I glT9qPXHP6Q9D+FZBr1HiI/NRda7hdgBuTzmC7SIGH4DgnORxmlN593dxCKc1ChmxZbz Nu1idVhuKRxiKI6aEC4xKSD3mxZl1n267pL7SYpWEMAQgnyoJONKdQTZtyOWG/lOc1pq Gd/VS99EZPlKD65u4jmP9Z8rY8JOAquwIfZbNXrTNtaPJ0yb4KHrpnYfdh3m9junnMeH Ud9uNbnqq3BW+DjznaepqIddHpEgWxVff2WQN8dq/1cpHErB8dUUaARaVwCtLZ3m9zmM rGIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SCruttcJltnxZ4sLruLZ+cGABkR1q5BSel3LbUJKAhc=; fh=hJtbCKZNEyrTfmz7hSNkT50Hj0TRSBX2Q/RiFxoMuPI=; b=Jj4FKRd/6krINJPQKBzaBwf6nnskQsCEnQRUITrMGrg+WV7GG8JND+GssXv9SOntl6 lbHbKcT1TVwzPsNbRRPk8ZnTYwXWtDEEGqqwgPYW3q4SfatR6/JufGsi9rzDBC0LaZk7 cqHNp1miGhLcHlGfLBqDTv3WpPVIy++1xB8BwBHcsoKAsAroWNz8ShHTk8jbTJLP+pb7 n39YZO5cyd2T0/XtMdiotWndMYEbbvahQEv4d75YqUAMmQA86I6cwNW2o0arPd7HVwSB aaz9/POtvq0/SwRYdsClMIFHh8DZt8AZWRMoRGe/acm5OZqHVqGCo66Kn0OfgByQC8El u8PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ky3-20020a170902f98300b001b8867a7ce2si3819572plb.273.2023.08.05.20.27.15; Sat, 05 Aug 2023 20:27:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjHFDNN (ORCPT + 99 others); Sat, 5 Aug 2023 23:13:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjHFDNM (ORCPT ); Sat, 5 Aug 2023 23:13:12 -0400 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB681FE4; Sat, 5 Aug 2023 20:13:11 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R761e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=liusong@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Vp4wN7H_1691291537; Received: from localhost(mailfrom:liusong@linux.alibaba.com fp:SMTPD_---0Vp4wN7H_1691291537) by smtp.aliyun-inc.com; Sun, 06 Aug 2023 11:13:08 +0800 From: Liu Song To: adilger.kernel@dilger.ca, tytso@mit.edu, jack@suse.cz Cc: liusong@linux.alibaba.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com Subject: [PATCH] ext4: do not mark inode dirty which is already dirtied under append-write scenario Date: Sun, 6 Aug 2023 11:12:17 +0800 Message-Id: <20230806031217.13962-1-liusong@linux.alibaba.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: <20230711034256.72651-1-liusong@linux.alibaba.com> References: <20230711034256.72651-1-liusong@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi, Any comments on this? Considering the most extreme scenario where a file is appended with only one byte each time, "jbd2_journal_dirty_metadata" will be executed because i_size has changed. Therefore, it is better to update raw_inode's size after the writeback is completed, which can also ensure the consistency of metadata and data, and obtain better performance benefits in high-frequency append write scenarios. Thanks