Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp5285661rwb; Wed, 9 Aug 2023 01:23:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEgqEKt6T/JyFXVAGK8XFquPKMMEw1L3mgJUPPJ+jZIhZwyGohCMIxiGoURFfmKtimtcKg1 X-Received: by 2002:ac2:5471:0:b0:4f8:7781:9870 with SMTP id e17-20020ac25471000000b004f877819870mr1193461lfn.60.1691569414361; Wed, 09 Aug 2023 01:23:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691569414; cv=none; d=google.com; s=arc-20160816; b=mupPRPATYKElts4V0Vu4YYsd8vQdQIGTwbu5RTj6GSI+l4p7cqvORNXnTkgmNOQOwn kUYUmsE9lQ8L03BAtkpQLQtwZcQ6wvSRxP5hwHErU4bKTzWHK+EQXyKP1YHhBFJC3Hz9 tK4VzdLQnLdHazw4vr22LTMgnEBHkICvQoiCB1qxYYHniFFiKb1wBvYpg2L3//D9ToZk cpl2XR/fcgtqB2F8y+bVgGDAbXCrW8+SLLDvkoKb+lpc0PL/nqryISaXxuwK457Xx10G 1hcjjDe/+tbupS4iglMlpFg/V4+ua2LXwyH9JYUPVljl3zVUlduyfCjKcFWHZJ5RjljO HH0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1Fnd9+CM2hcjoie8BaJgoZBedbZj4eDhmjSmf+AxRbA=; fh=HSGQoq9MOkMhaHDtKtcv+XycPKvl9pEfvsRgWwSF+DE=; b=mSmtFy+8tQIBaKcvx0H2Sy6AyWuSRQna9veoD5vXtrxHEvYcpPW1nvd1W8XmkUtH3h EaVxWoRFkT8sfTAe6EuVoKkSPohgnggaJhuSmt6NUvdj7PXA9psvv3zjj/TE2Y/cHfa5 wtuHb5+X5dnkWpC1APT+0i9wXaIihma+8gkNwFC8ivDYZlDIdI8VjJdg1C55LbrFgZU3 ZUIkr+xvmAML7vx1DgPgeing3SzpNHh0lQ5Xandtr9unqJKP/8Ogl8dk3QvhlB4sbWST lrdN3dzuyYiujQNhZr9sZe7pIYCoTFreXfkRfUhxLagmtw7VitEfNQrMgTO3ppqEWfk8 FmSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=atzbLuiz; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b23-20020a05640202d700b005233f769158si3273846edx.348.2023.08.09.01.23.10; Wed, 09 Aug 2023 01:23:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=atzbLuiz; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230321AbjHIH5P (ORCPT + 99 others); Wed, 9 Aug 2023 03:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbjHIH5P (ORCPT ); Wed, 9 Aug 2023 03:57:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4FAB1736; Wed, 9 Aug 2023 00:57:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83BE062E80; Wed, 9 Aug 2023 07:57:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66230C433C8; Wed, 9 Aug 2023 07:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691567834; bh=v0xYfmG6wm9eg/WvvT9EQwYCv5EnapFNIDQZX7uEmsI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=atzbLuizD9CF2qTmbSqgkQ6N1iAapMzRg0pGKYLDxK1JFOy5RMGGk2QqiJN/CPVT+ IgXJWUItCz9lKaLxohz3lMVf0ba/+xPcELcTCG9Xdjhpf7D7g6JQnHu1zCA6L/EkoT 1xsAf7cq3k01UZJXy4w6mWwVBtvP5Vef3tJwkm5TOJuOT0Z8+NPZj6kczyOJ/V+IM2 7RoMpjntorgOVwaX4SL0dMJ29sNMMKk+fcLVdFVv45Y4fnR5VcmPbPYji8+yWz1hoA j2O+f5JqIGHfBZB0uQCBu172D/q5twktJ6f0y2qnQDPc3TLRtU/A+UAEEDXGLIpF40 K7J3/PFN0XxVw== Date: Wed, 9 Aug 2023 09:57:08 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Al Viro , Namjae Jeon , Sungjong Seo , Theodore Ts'o , Andreas Dilger , Konstantin Komarov , "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ntfs3@lists.linux.dev, linux-xfs@vger.kernel.org Subject: Re: [PATCH 12/13] ntfs3: don't call sync_blockdev in ntfs_put_super Message-ID: <20230809-schob-putzen-c667de925b90@brauner> References: <20230808161600.1099516-1-hch@lst.de> <20230808161600.1099516-13-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230808161600.1099516-13-hch@lst.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Aug 08, 2023 at 09:15:59AM -0700, Christoph Hellwig wrote: > kill_block_super will call sync_blockdev just a tad later already. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Reviewed-by: Christian Brauner