Received: by 2002:a05:6359:6284:b0:131:369:b2a3 with SMTP id se4csp5289146rwb; Wed, 9 Aug 2023 01:28:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEl9hW/iIZlIeg2U/AJjUW+aDl/dJIDBQ76b5B46wwBVjcm1EqVwi+ajPncsr6iq12jmp76 X-Received: by 2002:a17:902:8211:b0:1b6:649b:92cc with SMTP id x17-20020a170902821100b001b6649b92ccmr1772242pln.69.1691569726928; Wed, 09 Aug 2023 01:28:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691569726; cv=none; d=google.com; s=arc-20160816; b=pCusquLfgPh+bbyR3Zi9NDi8DXJC0Op0VqKP13u/Ycush+2Pv370WjDQ3twWPxLg7F jhk/U2weQjluNQ3GBWV3RktlC9ytEpnNU3LwBRhIAmkgpruZrqD7HloqFm0k6fzl6XYA cqxBqciwTt3IxGruVk5NgRUolvixzygOOZEAskoRXnVV5CHGZ4jDWZXe/Wdm0JoK9CrN HOhzORZhXacDjTZKlwcdzzKirq0a1GdMgAP1RtD58woHvi2FkntSxWPijzsY7VkbYilq OiHZe7NiIlYLKe5fini48y5qQUJHBQuEOtR2XCac1apczSbLTNIVuFsz2l4eIJvnxOwY Wt7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oWlJ8qcUZzYLlMAJ8MnidYcdUtKsKhdsQVibW0bK0M4=; fh=HSGQoq9MOkMhaHDtKtcv+XycPKvl9pEfvsRgWwSF+DE=; b=fVx1/0WUL0RKHHsqWa+r8OAxcdXPkkGl23H4NVhiBpzO86fE+Z1K6jpmRR5YtxuUqD 3w2n4e+VmRT0bWXPcdkJSCp0Ff0oAgrLm9zJXTHDUIIWAU9YmGqNEPDhlePMVIXtLUJU XpRymKczc5744+2G1QMOO0hMZNVSUDNmVTuJXkJBuTF97kezIxkXCoAQOigeVu8Wpx9e SpC5M69ucVWPrC60eLm0qQnWHqYkeh4FVBm5rxlHFdI5gi88NOnJP+LNxNN28SnitJhX 3DO5aRdb3ZIWQ6Tp5OBVq4pFAHeh77actTK08ojs3sqjSZivRQb1ZQod9MuGleTXkdmP KrOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GPCXNYec; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020a170902b78400b001b9d926ccdesi8729340pls.576.2023.08.09.01.28.33; Wed, 09 Aug 2023 01:28:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GPCXNYec; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229969AbjHIH4j (ORCPT + 99 others); Wed, 9 Aug 2023 03:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbjHIH4i (ORCPT ); Wed, 9 Aug 2023 03:56:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63CCC1736; Wed, 9 Aug 2023 00:56:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E2A226300B; Wed, 9 Aug 2023 07:56:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8D08C433C7; Wed, 9 Aug 2023 07:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691567797; bh=WQY/j1wRlLAF1gay3G00GCSxD4stoAKq0BiMQO5p9rY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GPCXNYecxQuiNJQEnEQp8yZaYu6iJySRdexI4jSuar+507/Y46g2iiu+kLfQa45mK T4GS+HU3tCfK0GuK5wsMw7nlsRzIgFgNOvH7tOwAFh/mRziRkxp/YgOUNN5hmE75qH qV5YEAnEboRMAqKP9/HNp84UdqdOaB/k/G/0O87YC4QRd5EC1eDLsmVQ54ib6IqPzM QxmZ5BmRDceLYLky88vlnCKQEKJI7Qgwz/bXxxvRhMYUppadwcV6UCX+gvfme2xjP1 m00ieueVSYJxe//aR9ihwdqEA95gko1caNgKGEd3OZ6CiLHREO/XSlmfcPYKLMRqua W+Hj8yMKH6OVg== Date: Wed, 9 Aug 2023 09:56:31 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Al Viro , Namjae Jeon , Sungjong Seo , Theodore Ts'o , Andreas Dilger , Konstantin Komarov , "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ntfs3@lists.linux.dev, linux-xfs@vger.kernel.org Subject: Re: [PATCH 11/13] ntfs3: rename put_ntfs ntfs3_free_sbi Message-ID: <20230809-ausziehen-melken-be7ae49e204f@brauner> References: <20230808161600.1099516-1-hch@lst.de> <20230808161600.1099516-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230808161600.1099516-12-hch@lst.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Aug 08, 2023 at 09:15:58AM -0700, Christoph Hellwig wrote: > put_ntfs is a rather unconventional name for a function that frees the > sbi and associated resources. Give it a more descriptive name and drop > the duplicate name in the top of the function comment. > > Signed-off-by: Christoph Hellwig > --- Looks good to me, Reviewed-by: Christian Brauner