Received: by 2002:a05:6358:51dd:b0:131:369:b2a3 with SMTP id 29csp390190rwl; Wed, 9 Aug 2023 16:37:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGKs07yeH0wDSAwX6lSDWJl6J7+vZLQZ2eLQSkb6M+8Hpnp8/m/30tvZGMUTMPOR5Uo7M56 X-Received: by 2002:a05:651c:1032:b0:2b9:dfd1:3803 with SMTP id w18-20020a05651c103200b002b9dfd13803mr494943ljm.30.1691624220640; Wed, 09 Aug 2023 16:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691624220; cv=none; d=google.com; s=arc-20160816; b=0EKI7oq+4SmUF4BljZs2HAABq4DALjILVUn9llDFSihEqAMj7pT0NEcSarNi6lQ6R+ P5RcuA5MSu84+77I2S/hvOMcB8CgtJf8FneWI+zBrQcFCoOxE7V3qFBinWfuziQI0/Jt E7R1d2Tf3Vx0mkn9Mqo/PQ4k3YAXjrZ+OCfO2L2BT6d+5bPRNO7g4PJeN5s0SM3sLuA5 rDVRA8CxHpQrqZ+nfWIhK++3IYqfPmp1VHWdE0xMs+fZFXGeFJCRoSeWKdQX2qv8bPup 3InBnBacB+TfmqCimRpQbEZBJB5QaV6Z2vD/ehmuuOVHzz5wOmbzvIbq/n3WVPR8mWFG MSYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=QErTeQkz1cVsGQxjUoASrFujfY4NBEiICWhnXG0gBV0=; fh=xYYCMLMJ+2IbWglp0JxrsK4EkPiHh2FQHcpFdt441VM=; b=c0JbmE8rCQKGIffkUdRUwfoBvFwq1SSa2UdpRZQXXecsDxiC+wpswBXic/nvAKujx6 rDfxmoxqIhcA8PtGPFCdLjfP5uu5hq2VzGYSi8JcR/AZBNYQZsPl+nnmYPyGjTHpoRLx cYIXJNM+eEkxVA6G3vacF8HKj7sjPj4SBRujnsP0nI/HHhhgXN3wTzTzPFll+JyXv8vH WA+noD7/pmjmmyeHOasfs9DtuVADTz9Mvjj+thXd5wn7NQBj4l51VZyRhamu5sEHp4tt byrCzOiyRhR5NIsw30ykOhOJWao1FwO0RWGzxwMzVdrevyqYqYQlpGv2sttI0k9lqsK1 5ntg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=aCZKusqH; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xa16-20020a170907b9d000b00992ad3f32d6si231950ejc.810.2023.08.09.16.36.09; Wed, 09 Aug 2023 16:37:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=aCZKusqH; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233057AbjHIWF5 (ORCPT + 99 others); Wed, 9 Aug 2023 18:05:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230212AbjHIWFz (ORCPT ); Wed, 9 Aug 2023 18:05:55 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 842371729; Wed, 9 Aug 2023 15:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=QErTeQkz1cVsGQxjUoASrFujfY4NBEiICWhnXG0gBV0=; b=aCZKusqHBKNCz29OEKtMrCA0hp H3ASUAefgwC2AqVwlmJVgJBQRdFlvWLqBrWITEhcCE5VoHY+OS70nmuUs7TplQ99030xLEX11gB0L amI17KAIn6duu/Mr17rJcXumsmN4y5HiSx0FpSADV+z7iFLgPLuGeGyEH6r3ihoG3SuEPpQi/vIIS riRg1P7lpsCZ/8zWjDKUEAt14j3I2xoHKu8QPPOkWNvcK4ZiC92iho70hhnAF9YDADQzWoRgN2KbM 1iludwYtrQxeVoPiIv3k3h8/i1M//8pkg5xw0TyR7sgZC4BMy3yLUydPZJpX0bW8w3nr4Hj2wEktI FwyoIhAg==; Received: from [4.28.11.157] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qTrJK-005xnv-0d; Wed, 09 Aug 2023 22:05:46 +0000 From: Christoph Hellwig To: Al Viro , Christian Brauner Cc: Namjae Jeon , Sungjong Seo , "Theodore Ts'o" , Andreas Dilger , Konstantin Komarov , "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ntfs3@lists.linux.dev, linux-xfs@vger.kernel.org Subject: s_fs_info and ->kill_sb revisited v2 Date: Wed, 9 Aug 2023 15:05:32 -0700 Message-Id: <20230809220545.1308228-1-hch@lst.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi all, this series is against the VFS vfs.super branch does two slightly related things: - move closing of the external devices in ext4 and xfs from ->put_super into ->kill_sb so that this isn't done under s_umount which creates lock ordere reversal - move freeing the private dta in s_fs_info into ->kill_sb for file systems that pass it in through the fs_context, as otherwise we could leak it before fill_super is called (this is something new on the vfs.super branch because of the changed place where blkdev_get is called) Changes since v1: - keep the invalidate_bdev call in XFS and actually document it - minor whitespace fixes