Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp815846rdg; Thu, 10 Aug 2023 23:56:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0+MnrocsBauZV8GMHgbz0rTD/dprVU3z4snsnTF6M2noyHe4G2BUN2tJvRNJjNg9BMRgV X-Received: by 2002:a05:6a21:9997:b0:134:9f4e:623f with SMTP id ve23-20020a056a21999700b001349f4e623fmr1271599pzb.14.1691736975439; Thu, 10 Aug 2023 23:56:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691736975; cv=none; d=google.com; s=arc-20160816; b=W9uVuE6zGpdk1g9EAAEVntLwgW1/diKXFEE1Jz/Vsg2ml+xA0/kbkRwEKXorxPoSo5 gqhxLt4l9tIosiKnHe+I1tIrpGHI/V7THPxJ4HijojAAYt3QmQeSU+xho6UjxotpCCGh ll7c0pbUfknlgBqioWZVvNlo36bC59zCV1QUUfaa1gkRdZbK2XZRRgkqujZD6qpb3Hq7 YG7hjTJplA+nFgWZHmQH+5jrn9A3hkz3Oi7Iws+ytaJYwkCE9o8vpZZh3Hoi7mhgsEaW qUbz94UdHKWYUwNfznBlI37RRlpoX7IcHIf8ER3A6RFVj1QLNN8PDaP7fcUntxrzkCMx 38lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=vq/ysKo+FbMr5bsSsGNgB1sh2QaChtRRuszykWtf9dg=; fh=fTSaBofNXp03thGUSjn2fCTzw7oFshHI80Fe6i8kpiM=; b=igGSL+gTc9BSyozysmuASfnyj70JVZGFlCEQfREvWXEM+HHWOD/8MAO87HZWCBcK5M jkwv2p2YdWZs5Ju/BcMdkngdydW0q/XpIHcnx4SXJk6nsQbdDbZDdzMkR3cWbJuPoiRw cY1jbsPsurjAWIpmGt5My1XDCbyATMsUICLMumjRc3ELvpGXboCCZTeEu5aqyUBKee3e dZ870GZ9iVxtnLD1y/Mhun4ljeA3n6XtOqsd2eS019s/NNs7vSf8wjQemcb0kPcicQXb 3lCg6k0hMBVYgyNN4vKdlvGv0gRjHjgnx87LGfgErj7/4g9WMH1oh1ix5K4AcSaT4YLv zMJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n9-20020a170902d0c900b001b22f31cce9si2820223pln.179.2023.08.10.23.56.01; Thu, 10 Aug 2023 23:56:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233607AbjHKGgg (ORCPT + 99 others); Fri, 11 Aug 2023 02:36:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232278AbjHKGga (ORCPT ); Fri, 11 Aug 2023 02:36:30 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52B5826A6 for ; Thu, 10 Aug 2023 23:36:30 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RMYwV3v5Tz4f3w0N for ; Fri, 11 Aug 2023 14:36:26 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.170]) by APP4 (Coremail) with SMTP id gCh0CgA3x6na1tVkKEbDAQ--.35746S13; Fri, 11 Aug 2023 14:36:27 +0800 (CST) From: Zhang Yi To: linux-ext4@vger.kernel.org Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, yi.zhang@huawei.com, yi.zhang@huaweicloud.com, yukuai3@huawei.com Subject: [PATCH v3 09/12] jbd2: drop useless error tag in jbd2_journal_wipe() Date: Fri, 11 Aug 2023 14:36:07 +0800 Message-Id: <20230811063610.2980059-10-yi.zhang@huaweicloud.com> X-Mailer: git-send-email 2.34.3 In-Reply-To: <20230811063610.2980059-1-yi.zhang@huaweicloud.com> References: <20230811063610.2980059-1-yi.zhang@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgA3x6na1tVkKEbDAQ--.35746S13 X-Coremail-Antispam: 1UD129KBjvdXoWrKFWrWry3GF1xCFy8ur45ZFb_yoWDJrb_Xa 10vrWxW39xJr47A3y5C3yUurs09rs7ur1kGw1xtw4DKryDJ3ZIqFn7try5tryxuw1kKrW7 Ja9rKr4Svr9rKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbTkFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUAVCq3wA2048vs2 IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28E F7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8Jr0_Cr 1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s0D M2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjx v20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMx C20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAF wI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20x vE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxK x2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI 0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUQSdkUUUUU= X-CM-SenderInfo: d1lo6xhdqjqx5xdzvxpfor3voofrz/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Zhang Yi no_recovery is redundant, just drop it. Signed-off-by: Zhang Yi Reviewed-by: Jan Kara --- fs/jbd2/journal.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 708d58d69592..061887368ad5 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -2498,12 +2498,12 @@ int jbd2_journal_flush(journal_t *journal, unsigned int flags) int jbd2_journal_wipe(journal_t *journal, int write) { - int err = 0; + int err; J_ASSERT (!(journal->j_flags & JBD2_LOADED)); if (!journal->j_tail) - goto no_recovery; + return 0; printk(KERN_WARNING "JBD2: %s recovery information on journal\n", write ? "Clearing" : "Ignoring"); @@ -2516,7 +2516,6 @@ int jbd2_journal_wipe(journal_t *journal, int write) mutex_unlock(&journal->j_checkpoint_mutex); } - no_recovery: return err; } -- 2.34.3