Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp1099523rdg; Fri, 11 Aug 2023 09:38:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGZor+i0H7izHgqsAObZ/gEyE9vgQDCkyTlWL1ugymz640XOvUwpRWMUAUI2szE1urxiNQa X-Received: by 2002:a05:6a00:c91:b0:686:290b:91f7 with SMTP id a17-20020a056a000c9100b00686290b91f7mr2717462pfv.22.1691771929310; Fri, 11 Aug 2023 09:38:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691771929; cv=none; d=google.com; s=arc-20160816; b=FyXMmvYn684iO3JXMGEGlJzJnjDQktWlCi07MfI6IsKm7b/wWVBJxaZ0jlfwuHRnP0 ewfp+VM6ZHP/H2BVN63eXdfHuh0QZ5hFjeSBpFs7pD88k7We4eW1V7KwnCxNe+Bei24D ySSIlFEluaYb2oXGJDMNf3hBmaIGY+jPj/qn6n6/tAIp1Hez39YGN/Um0iD4sq2z2VpT 981S7YDMUQHwOO+YDzGTt/uz/D0aH0HNNMGVEe5ItGNYVhRFLrjo3GimoRglhygeimAB 1Pd+TgLoBrGvo/HqIYdmNpW0HdFIF7IHcK+6gJr90dlG886XkyludyQKKaJEqnVLHms2 WSUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=k5Qh2OYLkpSlQk66Lde25fAnzUb2YDmr8WqLmkA15S4=; fh=V6S9226kxWvGYznPvp6KinfD7louPsVsfmBr0FiuqKU=; b=HqhUvSUOF72kH7m5IuwH2vwjCzXGz4cVxSF0r/jKb1hXVY6t2p1divqwPZW5pQ4bFV T+cT3QlJeNkzVn2oM18CUtOiea1VKzJCdYJf7MVk3CfmqMojNQAmleWiK2M+OUX4SztY iUM9XXwPTTejsb7PhGZZNdDNGpIprUO74Ug7inleWMYE3Ygixf+fpHazBDPsWCO1074O jrGbLZt7NifHevP5Ml8Rxdkb3YBhnCXKZOL7kx5HFJ/xg+Jx06btx+4w5SM9agFYu6qf tsUdMsmgy0hn1CiC+/PxEuEJUABG4nXkYuOvBhZdz8hjbFQhYHcwfhBV0TOcoz1xamh7 56SQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=NNc59xR7; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q7-20020a635c07000000b005644828f689si3349773pgb.458.2023.08.11.09.38.34; Fri, 11 Aug 2023 09:38:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=NNc59xR7; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230123AbjHKQRp (ORCPT + 99 others); Fri, 11 Aug 2023 12:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbjHKQRp (ORCPT ); Fri, 11 Aug 2023 12:17:45 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C696A26A2; Fri, 11 Aug 2023 09:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=k5Qh2OYLkpSlQk66Lde25fAnzUb2YDmr8WqLmkA15S4=; b=NNc59xR7jloaxMIqFQREnNwxsa eWsoUI+sHYJo0/elWtab56XDom5Y1JwCgYDBpiuxP+xy9rEkEZsFZ9I9IMIoxDlME4C4b6zgz3bKU LKvVUksCTobRW4i52okiQHfOj4NI/UHmbFZ+2jkNeuTlJfxyROt5YwRtWdZ7UflJ1JP7ilo5m7JMB 5A9IjfeEGNA4JuTzAt9nGQ3h5oLe3UAoYsRWu8m3HPDAUVyPAbtTtEmGFGxvQ0Q2Qdb7SXJuEXMGr hTzQLfCxh5Y2CnuPMkCMdR2ANFORAQWPzpK8D6H8fdjrxWCP4IWLefN1/PaKdpXNFgF+e5fjJ4GHL rqJiVDsQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qUUpa-0027sJ-AH; Fri, 11 Aug 2023 16:17:42 +0000 Date: Fri, 11 Aug 2023 17:17:42 +0100 From: Matthew Wilcox To: akpm@linux-foundation.org Cc: Hui Zhu , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 3/3] ext4: Use bdev_getblk() to avoid memory reclaim in readahead path Message-ID: References: <20230811161528.506437-1-willy@infradead.org> <20230811161528.506437-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811161528.506437-4-willy@infradead.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Aug 11, 2023 at 05:15:28PM +0100, Matthew Wilcox (Oracle) wrote: > + struct buffer_head *bh = bdev_getblk(sb->s_bdev, block, > + sb->s_blocksize, GFP_NOWAIT); Doh, I missed the __GFP_ACCOUNT from that. Will wait a day or two for other feedback.