Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3359186rdb; Wed, 13 Sep 2023 09:36:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHK+Yt4Q7DO45hhTf/62OfSzyaAu7koi0D5cbuTwvVdeYSheZTCHZVX68/v6SLHjuQYZGIh X-Received: by 2002:a05:6a00:14ca:b0:68f:cc0e:355d with SMTP id w10-20020a056a0014ca00b0068fcc0e355dmr3655045pfu.25.1694622989495; Wed, 13 Sep 2023 09:36:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694622989; cv=none; d=google.com; s=arc-20160816; b=ji0cZ9ibX5+NBGn0aafWdOpmZLs6l/cO0MQyTFh904FYEZcJ/Rb1uFaqGctAZK/wPG wrEaXMb5NgoDvfWLrajdIXDA/SDphujLQgAIKiAeM8lC29zM2F+E8RpNbH6rQzFH6xHU xCYtS1ClaXs++OE4V+GbMorhob4zXboVBFDLqkuJ3sC7phaXsLIqFlBb+HzXYvHycrWz /XS3es2B+9IhLGfQ6nO+tkrR6ZkSZ+K/5D1nQ7T7CGebUvG6BOLnAXttuTmAQ+H+sRjP RUd1cofOyFBj+1xG7dYTKSMDC+dFJBVWYj20iQnwARvO6ugmZJ0ir62vnxs9ptpjJWcU 8tqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q6aPtxLCYed//nrPJlN0YolEEgZg0w4fKTNV4B0HzRo=; fh=qMIi4C/KJ+3kj4orQXTAsnvLFqfJ5cNGlnx0PT2yNxA=; b=WqlXZ79tVJ+FuT4YWTMmOR6qV7MtG6xQHIAHPE1SdzKe8Q3W0uRcqSuy91Aghdonlj lI52I16mswvArW8zzolZ0VXs6YB2fXeHYO9BZxvfzBPGoZ69+Hage/rJcbWITJV01EpR MtO3mm2XBiJRNHCMxD5FmZno+qNnnbwn8PFoCCidVqkeQ5VWfV6vjHqWz61tWS0XlpNH UiHAneDKHqlDZJBAGoxEYFhyNd3m1xNA9Ubvg4VPLNbCs8/fCbksCIPBhcaUjl1p0JXR isOfmLJ37qKS/9ECyB84wpMwP4BtEb74sXoCzzsyIS2BWaANkSeuduQxWAl5taMV5A0i LFlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JEIWOoDe; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id r5-20020a632b05000000b00577549e67b9si7564600pgr.589.2023.09.13.09.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 09:36:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JEIWOoDe; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 736DF819D704; Wed, 13 Sep 2023 09:33:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229849AbjIMQdW (ORCPT + 99 others); Wed, 13 Sep 2023 12:33:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjIMQdW (ORCPT ); Wed, 13 Sep 2023 12:33:22 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 425B019A7; Wed, 13 Sep 2023 09:33:18 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6C43C433C8; Wed, 13 Sep 2023 16:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694622797; bh=/BE0SzPSHWJUDQnPrCfnTnaEO0Ee7ixrpqIiDWWi4pg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JEIWOoDeYw0Lf9hWj/zCyZ4x/rGCa/NQnygF+m0lMZeczRYWp/+IE53tvWyCKZsG+ up2zc8mQP9OdLjIt3ieHpSW+DbqQjZbKoxHgYka+ox5B/duraDYwWYC2flCW6yQuBT cv0SrfJZcsbNKoo8+UUGobBcO+5vSh//zaB0oCO1AkX/JNOxsSLnUA74YuG8d2qy// xSekU6sH/2OHlD59lMaI3d2pMSviFkxZRQRw7TX7MfD7+om+CEtOj6/4xJ6+C+s9aW E5R98PPdfp9ZT0xmFjYnC4VDDVH+LzbtHDEh8winSlhdDUVsFOEtHvfQKUUr5vKlnV kky/flcyBX0+w== Date: Wed, 13 Sep 2023 18:33:10 +0200 From: Christian Brauner To: Christoph Hellwig Cc: Al Viro , Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Hannes Reinecke Subject: Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write Message-ID: <20230913-aufgreifen-fehlleiten-204b36f3069d@brauner> References: <20230601145904.1385409-1-hch@lst.de> <20230601145904.1385409-4-hch@lst.de> <20230827194122.GA325446@ZenIV> <20230827214518.GU3390869@ZenIV> <20230913110010.GA31292@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230913110010.GA31292@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Sep 2023 09:33:19 -0700 (PDT) X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email On Wed, Sep 13, 2023 at 01:00:10PM +0200, Christoph Hellwig wrote: > > direct_write_fallback(): on error revert the ->ki_pos update from buffered write > > Al, Christian: can you send this fix on top Linus? Wasn't aware of this, sorry. I've picked it up and placed it with another set of small fixes I already have. I'm happy to have Al take it ofc.