Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3978228rdb; Thu, 14 Sep 2023 08:18:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGlhxtD22nV9k0tQI7P1SmlQU7TZQGzWQf1P6sKp460BjWV0BlQH04GOEVqGA9JXKkOOXni X-Received: by 2002:a17:902:ced1:b0:1bd:f7d7:3bcd with SMTP id d17-20020a170902ced100b001bdf7d73bcdmr7454772plg.50.1694704693551; Thu, 14 Sep 2023 08:18:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694704693; cv=none; d=google.com; s=arc-20160816; b=Gq/DUI/BANOYNx3bP6bA5Ub13UiEgEVbezbnIPBm4FV/T/KsNyFJ2V1sVj7ryJu1q5 RZ2Ir8i+t+rd6xGkUYjSC8SYUJMzHAWtMxmzkZ45PlXEmiEDdNLK+RDxIblLl8TpK/ey ulF9+HPH/BfptjoXI28lXvU1AmH4uHLccneUpnHNjzbFpU+GtHxoqMWARGx8Wr9lS/Cb dZRN7XWGiP5t2rlPJa30WX1sOO918szt0EbAP8y98GuTBEb0isNGZtmErPhAMl+7c8of fWarR6hjatId7mjlD39CXbiKrVUZzXu/aUOz0xmCStTksaw8ptsxPDK4JbGzhLMdR0+x Ciag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lrmQrJvIxyRlTUwEk2DAFIW09BK8fmo+w0FXcpX+fwo=; fh=BHOQJDZa9mj3aJkUoHuSlQnds5QvaQhTAtmXEb4+qDY=; b=h8ei8Qe73FDqSfgaAANOzXAF6DO3q9W5qxMhUAC30InmauOOHnz4N58APs0tS6th1U HdzLYYdIh57KX3P7/Jg8bCCZ2C+Z+SXdF7NsvC+Me6GdYw9SC8tvdqSHWOfHAPZJDxjf HojxhWmxFBM3oOWWNk1AYWXSNdI7IATW2m6E+ALIL23X0spxIMS6TXFlYiN1aOiUXSCK cO5TpYqGNRtLgbLH+PWRwnEf4SrEXC1Ct1r8VVl4KY95TEfDKMHId6BqgwKlzRl5ucPQ f2vgwkn0rehuvNCCEcmk9lPfhbOpsqfHFsHLrk2oASVdG0+lOFAqhvRyUQIxgaNjeDVI LfIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=DRrBl2ga; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id a10-20020a170902ecca00b001bb00cc105csi1898569plh.632.2023.09.14.08.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 08:18:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@mit.edu header.s=outgoing header.b=DRrBl2ga; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 8552A8065E1D; Thu, 14 Sep 2023 08:01:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235244AbjINPBV (ORCPT + 99 others); Thu, 14 Sep 2023 11:01:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240774AbjINPBU (ORCPT ); Thu, 14 Sep 2023 11:01:20 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 975FA1FC2 for ; Thu, 14 Sep 2023 08:01:15 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-113-225.bstnma.fios.verizon.net [173.48.113.225]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 38EF0jpt000409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Sep 2023 11:00:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1694703647; bh=lrmQrJvIxyRlTUwEk2DAFIW09BK8fmo+w0FXcpX+fwo=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type; b=DRrBl2gaykYyOeNDI6kPCZsGg//yU3c8kUacwsI8I2q3LoFP7nVm95MMLGfny86yK GNmS/14Tu7bDlczYFFbGCdEPRijJe11Rgvf8yb1NJXGB7HXnVnYmIX0bVUcQTywbFx Q4ifHqCJy64B1NNCy+E0iejZWVby6zyNzNiSF48QRYQsyAwsDym3xTmGSjQ3+yo56I 75AMa5aOilGMo6qKUgtzRW/GT+zPRQgLb+RjKx8Ev2PPXJg8jnPGwMBEiBxH9dT+ks XxpNIX9VRAolNo3NJWWwG1/l9TTs/iHGfRztXpso9ZJ38a2AJMpVvkzSRt+bCUKZo+ Ggr881zVnyHtQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id E7C8915C0266; Thu, 14 Sep 2023 11:00:44 -0400 (EDT) From: "Theodore Ts'o" To: Jan Kara Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, todd.e.brandt@intel.com, lenb@kernel.org Subject: Re: [PATCH 0/2] ext4: Do not let fstrim block suspend Date: Thu, 14 Sep 2023 11:00:42 -0400 Message-Id: <169470363119.1407074.11495845673817769127.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230913145649.3595-1-jack@suse.cz> References: <20230913145649.3595-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 14 Sep 2023 08:01:18 -0700 (PDT) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email On Wed, 13 Sep 2023 17:04:53 +0200, Jan Kara wrote: > these two patches fix a long standing issue that long running fstrim request > can block a system suspend as reported by Len Brown in [1]. The solution is > quite simple - just report whatever we have trimmed upto now since discard > is an advisory call anyway. What makes things a bit more complex is handling > of group's TRIMMED bit - we deal with that in patch 1. > > Honza > > [...] Applied, thanks! [1/2] ext4: Move setting of trimmed bit into ext4_try_to_trim_range() commit: 5e4a9f11b5d7cb70a4e4474f0ba25d5f1fd2a8ed [2/2] ext4: Do not let fstrim block system suspend commit: b016ebb300e514bc46151f8fc006caae141a8bde Best regards, -- Theodore Ts'o