Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <729CDEF6-F6B3-4290-8120-F73C990B0D9F@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_68A3AE40-B6AB-437C-A9F0-620A7F257F44";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [e2fsprogs PATCH v2] resize2fs: use directio when reading
 superblock
Date:   Mon, 18 Sep 2023 15:20:01 -0600
In-Reply-To: <20230911183905.GA1960@templeofstupid.com>
Cc:     Theodore Ts'o <tytso@mit.edu>, linux-ext4@vger.kernel.org
To:     Krister Johansen <kjlx@templeofstupid.com>
References: <20230911183905.GA1960@templeofstupid.com>
Precedence: bulk


--Apple-Mail=_68A3AE40-B6AB-437C-A9F0-620A7F257F44
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Sep 11, 2023, at 12:39 PM, Krister Johansen <kjlx@templeofstupid.com> =
wrote:
>=20
> Invocations of resize2fs intermittently report failure due to =
superblock
> checksum mismatches in this author's environment.  This might happen a =
few
> times a week.  The following script can make this happen within =
minutes.
> (It assumes /dev/nvme1n1 is available and not in use by anything =
else).

Krister,
thanks for submitting the patch.  This particular issue was already =
fixed
in commit v1.46.6-16-g43a498e93888, apparently based on your previous =
report:

    commit 43a498e938887956f393b5e45ea6ac79cc5f4b84
    Author:     Theodore Ts'o <tytso@mit.edu>
    AuthorDate: Thu Jun 15 00:17:01 2023 -0400
    Commit:     Theodore Ts'o <tytso@mit.edu>
    CommitDate: Thu Jun 15 00:17:01 2023 -0400

    resize2fs: use Direct I/O when reading the superblock for online =
resizes

    If the file system is mounted, the superblock can be changing while
    resize2fs is trying to read the superblock, resulting in checksum
    failures.  One way of avoiding this problem is read the superblock
    using Direct I/O, since the kernel makes sure that what gets written
    to disk is self-consistent.

    Suggested-by: Krister Johansen <kjlx@templeofstupid.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>

So it is landed on the e2fsprogs maint branch, but there has not been a
maintenance release since the patch was landed.

Cheers, Andreas

>   #!/usr/bin/bash
>   set -euxo pipefail
>=20
>   while true
>   do
>           parted /dev/nvme1n1 mklabel gpt mkpart primary 2048s =
2099200s
>           sleep .5
>           mkfs.ext4 /dev/nvme1n1p1
>           mount -t ext4 /dev/nvme1n1p1 /mnt
>           stress-ng --temp-path /mnt -D 4 &
>           STRESS_PID=3D$!
>           sleep 1
>           growpart /dev/nvme1n1 1
>           resize2fs /dev/nvme1n1p1
>           kill $STRESS_PID
>           wait $STRESS_PID
>           umount /mnt
>           wipefs -a /dev/nvme1n1p1
>           wipefs -a /dev/nvme1n1
>   done
>=20
> After trying a few possible solutions, adding an O_DIRECT read to the =
open
> path in resize2fs eliminated the occurrences on test systems. =
ext2fs_open2
> uses a negative count value when calling io_channel_read_blk to get =
the
> superblock.  According to unix_read_block, negative offsets are to be =
read
> direct.  However, when strace-ing a program without this fix, the
> underlying device was opened without O_DIRECT.  Adding the flags in =
the
> patch ensures the device is opend with O_DIRECT and that the =
superblock
> read appears consistent.
>=20
> Signed-off-by: Krister Johansen <kjlx@templeofstupid.com>
> ---
> v2:
>  - Only set DIRECT_IO flag when resizing a mounted filesystem. =
(Feedback from
>    Theodore Ts'o)
> ---
> resize/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>=20
> diff --git a/resize/main.c b/resize/main.c
> index 94f5ec6d..f914c050 100644
> --- a/resize/main.c
> +++ b/resize/main.c
> @@ -409,6 +409,8 @@ int main (int argc, char ** argv)
>=20
> 	if (!(mount_flags & EXT2_MF_MOUNTED) && !print_min_size)
> 		io_flags =3D EXT2_FLAG_RW | EXT2_FLAG_EXCLUSIVE;
> +	if (mount_flags & EXT2_MF_MOUNTED)
> +		io_flags |=3D EXT2_FLAG_DIRECT_IO;
>=20
> 	io_flags |=3D EXT2_FLAG_64BITS | EXT2_FLAG_THREADS;
> 	if (undo_file) {
> --
> 2.25.1


Cheers, Andreas


--Apple-Mail=_68A3AE40-B6AB-437C-A9F0-620A7F257F44
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmUIvwIACgkQcqXauRfM
H+AyCA/9Ev51deHY2Q+FZOIBr5M5nliWYUcFWx1ecaVB/tii/b77nbVoHhdIV8rW
xZ1LsguYZnh+Sb8hngmpNyu2iXLzC6zy/y2OXStea7rtozXwq3rbrZZ5sSaJ++fF
RCDrNj7RxveNdRcJdx8A504ag88ZfoHFCU7tJojIgLrCOJc5/IXNIq/rx/5kpVlO
dUTywkDU/DWsFUl/N09Gj/6MCo3q5BzHwzEa6GzesO8jKWjdzNx/9nUAFOqaptjA
GwRKgeXw5m2WbzjGscG0oRttUzSdBB9D9L1ls7f7ZuySC9tyIvMGMj9uK6SJqpS4
wxBJC83Gs90J6rOAILuFoySkIYPUq7TSNZEwRttnGFzwi+CDX7/t/QbRnKBxprMC
gWCvVOjHBRJnio/aZF/sFA4q7RIvNICnJ56TeFzt0Wd/oMUylZyZWRA2clIxXPms
WCHdb7X+d7ed3+aS69rNR6CTNReUuzuxFdOy5q4oqwpX7wUbwv0z8fMEAnADGucG
rk/bhhKa6BOhqPpurjHT9vCP7SzHJggLGb7HLH2546JsyHonEoKVYJKWZPvOlisb
ymcPOVn69ccWK9XdTjXJBJLmTrWrCBA6X1xMjeXGWSzD0kXetJGDuI8k1P6SaFtH
api1O2X2mSG4lw3Xl//UrXvB7/trQ29WnnYxFrME/1KjGnmWfbs=
=J6F4
-----END PGP SIGNATURE-----

--Apple-Mail=_68A3AE40-B6AB-437C-A9F0-620A7F257F44--