Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp519388rdb; Tue, 19 Sep 2023 02:24:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/4LWjK8G3La0Aa5n5kiQggm9o+axi9Fv5l9HLdM6sUIGULlkSWI/gY52jtjbcEvDCq+H2 X-Received: by 2002:a17:903:1249:b0:1bf:69af:b4e4 with SMTP id u9-20020a170903124900b001bf69afb4e4mr11290904plh.37.1695115458395; Tue, 19 Sep 2023 02:24:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695115458; cv=none; d=google.com; s=arc-20160816; b=sh7BO3EzGPblx7nh9XHwK4Ut6booflvFH1kYehrrW25WPdnvaVApNmwYgyvtdYbyxK WBIDo0w5DmAHbh6XhTsfEG0OFwe1seILZAkf30a+pwPZKN7zbTNpfdSLrV96FomnVfda o98puUdK4oTZPW1ff+nyvMQf2Kh1DRb7MWV9HRTzgJd7r3ozTzJYhSnTs/m20I5r6Yjz Q9AcNRcF72c896TRUFkSRKrOi9UxbsyhUiN7Jj9GPMwD9xCIzDlR7/8U/uLVeJBQN20o KnbQlviBsoVbu0Dh1PCtgmKAYQS1MkDIFWcjWhtyimF/TGGKz4FFU9JANhgrCAzbu/Qr 0Idw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AQlSme5gfgF1PuSREZ2XhDo5ATTymBH433vqXKy6HYA=; fh=Ex900LeWemyNv8v7eVaT25lhS5hAbxvedq4sD5vnIX8=; b=CQBW5S06r4Q/F7V7ew/xza0BpCZ8BgE8cB8nua/JWoZEIi5GYFFKj/fomZ2IjUvS9v NfORxQFEJj+fk564TxvZlNaW8pKyQHSB7bIrSbSwSvluo1vgBCAJ+guqXlXkRNYxPj47 91ks9gDMavaimdOsLorOSJn6t7UOZgsvzzLI8Olt0btIxrL0AS1PFrKSxkKEXqnBWLjM wITelQEsx3D3Mab+bPEOsva29tu2HIfWNInRi+TKLOJMlYVgesFgO6/rXn70mDQwT5EH Hicns9zfIDPFTIIvo4gwKzfV+T7YYzV/5U8ITTVyb9PiHttyAy7ueoZEJ4mux+8cLu8u Dcdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=JJppl7Ui; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id a5-20020a170902710500b001c0a165a219si8937526pll.134.2023.09.19.02.24.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Sep 2023 02:24:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=JJppl7Ui; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 92E6C819144B; Mon, 18 Sep 2023 21:53:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231635AbjISExZ (ORCPT + 99 others); Tue, 19 Sep 2023 00:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231752AbjISEwn (ORCPT ); Tue, 19 Sep 2023 00:52:43 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D8DB1BB; Mon, 18 Sep 2023 21:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=AQlSme5gfgF1PuSREZ2XhDo5ATTymBH433vqXKy6HYA=; b=JJppl7UiNVc9XOSJeWze4h14kq Juko1qtn8fJ4aHHuB7zu5C4R7OyJGaSJnUSgzpdxkZ+dqLlTOFpqyWhefQbRcNpLhpNLmvQltWSAn C7ZpO0FcFmc1xx7X5C4bcbD0FKdTf9sXQRQ+banVLKDHHuO/w3zdBvtlLbwI5sFdJ5HPdJW1F9QVO mtSFcSTpG0CM2ReAEuaIBc5UyqeV1+Jb/9DXQhP8hsSjdzGEM2kI/a0JqyP6E6v8V4SgKBYUkTGWg INxIijyxrRagUGRekiCKh78YPLq80p8LPEtBi1aM3YXPnXLahkvXsgQbtM+jDe7ms5QM2kyjHITyA rDOz3Q6Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qiSi2-00FFkT-Va; Tue, 19 Sep 2023 04:51:39 +0000 From: "Matthew Wilcox (Oracle)" To: Andrew Morton Cc: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, reiserfs-devel@vger.kernel.org, linux-ext4@vger.kernel.org, Pankaj Raghav Subject: [PATCH 07/26] gfs2; Convert gfs2_getjdatabuf to use a folio Date: Tue, 19 Sep 2023 05:51:16 +0100 Message-Id: <20230919045135.3635437-8-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230919045135.3635437-1-willy@infradead.org> References: <20230919045135.3635437-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 18 Sep 2023 21:53:24 -0700 (PDT) Use the folio APIs, saving four hidden calls to compound_head(). Signed-off-by: Matthew Wilcox (Oracle) --- fs/gfs2/meta_io.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index f1fac1b45059..b28196015543 100644 --- a/fs/gfs2/meta_io.c +++ b/fs/gfs2/meta_io.c @@ -400,26 +400,20 @@ static struct buffer_head *gfs2_getjdatabuf(struct gfs2_inode *ip, u64 blkno) { struct address_space *mapping = ip->i_inode.i_mapping; struct gfs2_sbd *sdp = GFS2_SB(&ip->i_inode); - struct page *page; + struct folio *folio; struct buffer_head *bh; unsigned int shift = PAGE_SHIFT - sdp->sd_sb.sb_bsize_shift; unsigned long index = blkno >> shift; /* convert block to page */ unsigned int bufnum = blkno - (index << shift); - page = find_get_page_flags(mapping, index, FGP_LOCK|FGP_ACCESSED); - if (!page) - return NULL; - if (!page_has_buffers(page)) { - unlock_page(page); - put_page(page); + folio = __filemap_get_folio(mapping, index, FGP_LOCK | FGP_ACCESSED, 0); + if (IS_ERR(folio)) return NULL; - } - /* Locate header for our buffer within our page */ - for (bh = page_buffers(page); bufnum--; bh = bh->b_this_page) - /* Do nothing */; - get_bh(bh); - unlock_page(page); - put_page(page); + bh = folio_buffers(folio); + if (bh) + get_nth_bh(bh, bufnum); + folio_unlock(folio); + folio_put(folio); return bh; } -- 2.40.1