Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2685933rdh; Wed, 27 Sep 2023 09:36:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnIbNZ6tI+2h1KwsS9VWLS6LKfpJu6unsmxhD+pAU/u0TXml5YwCUxIxc6KkLUrpxllCT+ X-Received: by 2002:a05:6a00:c91:b0:68a:53e6:1fed with SMTP id a17-20020a056a000c9100b0068a53e61fedmr3154349pfv.23.1695832570745; Wed, 27 Sep 2023 09:36:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695832570; cv=none; d=google.com; s=arc-20160816; b=gF8cQ50AM41uglzPU/CHOE4CM4Hz8DKwM5v2YKWJpL3eDW6PD/SW8h/mdxHSgn05Bo WKu4vxUw3VRnGM57j7ZuqHfRw4r/6hApzv7ril/tzmSitsDrEipvC8skbWChPeaZJB6o uT71xb0FJJ6hePwpzNmXNaUC19uPMGZlylyVDlkvDaYOZKRI30WTgxe10jGSX3vsPERm G8f7RqNxMnvGZgr7Oj/ilR1v7pJRu05NrVJ24mb30SjzTAkFfTk5odYsNgoIF8+O/H1s ILSytrZ/78PwTAbrHW0OS0idPVqdhtu7IBdRkED12iY3/xp+44VWBB9qqE7QtRzOrZw0 LwRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pGSXFW875XdfGIucswtJNPAM/ZfOGJND2OExEMVRxgE=; fh=zFxv3e3SLMAvmtcon/ss+mu7WkNyt+IX8BCi0fsOYa4=; b=TBvyn6WwdNMUuMlBoCCgvurMlJlz3NOQJqTjzyZP+myicITuKyBzM6/shn/1O+BKXy 92jpCzvytEd3f4XOahiBdlxntt26H9NBNFGXU8RYyCRuxIWgHdQcypVsoZVmHbSGoO1m tE6ptHeF5p/Mmi/TfFCHuPUODjuvH4ZQ2WG0zktZJcwMFaG3si7u418X1mkAj3XWn/MM aexWl0KzS/Ch9IxD/Z057bHfLDD58LXzcgNRyOfcGnjFwmivmVHql64a0sEo0Bv8ASur VqBg0oUbqXhs1AtTE5xqGdaMwL0Z67K/NnUnDgCcKBHH679t8xXnRP7wSFBzpGEPDTwL i6Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K+SdxwDZ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id n50-20020a056a000d7200b00690bc21d900si15073867pfv.136.2023.09.27.09.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 09:36:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=K+SdxwDZ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0210C806666B; Wed, 27 Sep 2023 09:21:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbjI0QVf (ORCPT + 99 others); Wed, 27 Sep 2023 12:21:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbjI0QVe (ORCPT ); Wed, 27 Sep 2023 12:21:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E702DD; Wed, 27 Sep 2023 09:21:31 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF3E3C433C7; Wed, 27 Sep 2023 16:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695831690; bh=5fVqTod0fsU3D85/NgpH5eX11yWtVW2s8jme29QI3SA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K+SdxwDZhx8uxbb5abeHgPolVgmwSiIBL6/AzX/eEpmg7s5Jd1TwEPpueT17Z+y1i r/3aJFhGZoIRaqB+ADboLRaAQZpJm6SMvyfu5jpdUX9fmjLLqHrtdJHSnoHaBHBoNB 1Ras0NDOeGzjZ5rjoNJ7hj3RFSgjPFHQeOCu0doiR1ZFlmc7Dtn7+Tg4yFYE5HRxY7 FflbgLOEB1zCas3wjtrhbqXfzlZd6DZqKcBXDoRDLeETsNHRLxD2cXgjOH7guvx0ma AufPlRnLwdi+pMqoWiBGk6SGa+Snjtz53w/pXkwTjOc2fDnSaUxFN105snuKm+T14u FBsBAdYo6oMFA== Date: Wed, 27 Sep 2023 18:21:19 +0200 From: Christian Brauner To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH v4 0/29] block: Make blkdev_get_by_*() return handle Message-ID: <20230927-prahlen-reintreten-93706074e58d@brauner> References: <20230818123232.2269-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230818123232.2269-1-jack@suse.cz> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 09:21:37 -0700 (PDT) On Wed, 27 Sep 2023 11:34:07 +0200, Jan Kara wrote: > Create struct bdev_handle that contains all parameters that need to be > passed to blkdev_put() and provide bdev_open_* functions that return > this structure instead of plain bdev pointer. This will eventually allow > us to pass one more argument to blkdev_put() (renamed to bdev_release()) > without too much hassle. > > > [...] > to ease review / testing. Christian, can you pull the patches to your tree > to get some exposure in linux-next as well? Thanks! Yep. So I did it slighly differently. I pulled in the btrfs prereqs and then applied your series on top of it so we get all the Link: tags right. I'm running tests right now. Please double-check. --- Applied to the vfs.super branch of the vfs/vfs.git tree. Patches in the vfs.super branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.super [01/29] block: Provide bdev_open_* functions https://git.kernel.org/vfs/vfs/c/b7c828aa0b3c [02/29] block: Use bdev_open_by_dev() in blkdev_open() https://git.kernel.org/vfs/vfs/c/d4e36f27b45a [03/29] block: Use bdev_open_by_dev() in disk_scan_partitions() and blkdev_bszset() https://git.kernel.org/vfs/vfs/c/5f9bd6764c7a [04/29] drdb: Convert to use bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/0220ca8e443d [05/29] pktcdvd: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/7af10b889789 [06/29] rnbd-srv: Convert to use bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/3d27892a4be7 [07/29] xen/blkback: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/26afb0ed10b3 [08/29] zram: Convert to use bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/efc8e3f4c6dc [09/29] bcache: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/dc893f51d24a [10/29] dm: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/80c2267c6d07 [11/29] md: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/15db36126ca6 [12/29] mtd: block2mtd: Convert to bdev_open_by_dev/path() https://git.kernel.org/vfs/vfs/c/4c27234bf3ce [13/29] nvmet: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/70cffddcc300 [14/29] s390/dasd: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/5581d03457f8 [15/29] scsi: target: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/43de7d844d47 [16/29] PM: hibernate: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/105ea4a2fd18 [17/29] PM: hibernate: Drop unused snapshot_test argument https://git.kernel.org/vfs/vfs/c/b589a66e3688 [18/29] mm/swap: Convert to use bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/615af8e29233 [19/29] fs: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/5173192bcfe6 [20/29] btrfs: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/8cf64782764f [21/29] erofs: Convert to use bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/4d41880bf249 [22/29] ext4: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/f7507612395e [23/29] f2fs: Convert to bdev_open_by_dev/path() https://git.kernel.org/vfs/vfs/c/d9ff8e3b6498 [24/29] jfs: Convert to bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/459dc6376338 [25/29] nfs/blocklayout: Convert to use bdev_open_by_dev/path() https://git.kernel.org/vfs/vfs/c/5b1df9a40929 [26/29] ocfs2: Convert to use bdev_open_by_dev() https://git.kernel.org/vfs/vfs/c/b6b95acbd943 [27/29] reiserfs: Convert to bdev_open_by_dev/path() https://git.kernel.org/vfs/vfs/c/7e3615ff6119 [28/29] xfs: Convert to bdev_open_by_path() https://git.kernel.org/vfs/vfs/c/176ccb99e207 [29/29] block: Remove blkdev_get_by_*() functions https://git.kernel.org/vfs/vfs/c/953863a5a2ff